@foxly Are you guys having trouble coming up with a fix, or is it just a workflow/deployment/release issue?
I have the latest versions of WordPress and BuddyPress on a live site, and this fixes it for me.
THIS IS A FRAGMENT OF THE FILE, meant to replace the broken implementation of the ‘bp_core_check_avatar_type’ function ONLY. Don’t replace the whole file with this!
// buddypress/bp-core/bp-core-avatars.php
function bp_core_check_avatar_type_original_version($file) {
if ( ( !empty( $file['file']['type'] ) && !preg_match('/(jpe?g|gif|png)$/', $file['file']['type'] ) ) || !preg_match( '/(jpe?g|gif|png)$/', $file['file']['name'] ) )
return false;
return true;
}
/* Patched version by Andrew Koster */
function bp_core_check_avatar_type($file)
{
// Uncomment the following line to examine the data structure.
// print_r($file);
if (isset($file['file']))
{
// Before WordPress 3.1.
return bp_core_check_avatar_type_original_version($file);
}
else
{
// After WordPress 3.1 (sometimes).
if ( ( !empty( $file['type'] ) && !preg_match('/(jpe?g|gif|png)$/', $file['type'] ) ) || !preg_match( '/(jpe?g|gif|png)$/', $file['name'] ) )
return false;
return true;
}
}
The problem comes from the fact that we’re trying to validate a data structure that is extremely loosely defined. It has been changed it in some places, but not in others, so two different versions of the function are now needed.
This is why using arbitrary data structures everywhere is a bad idea, IMO. A “FileInfo” class or something similar would avoid this kind of problem, or at least make it easier to debug.
EDIT: The twitter link given in a previous post doesn’t work.
