Group Mods

  • Profile picture of @mercime
  • Profile picture of r-a-y
  • Profile picture of Hugo

Time Offset still present in BP 1.2.6 (34 posts)

Started 1 year, 7 months ago by: paulhastings0

  • Profile picture of paulhastings0 paulhastings0 said 1 year, 7 months ago:

    Running WP 3.0.1 with a child theme of the BP default, just upgraded to 1.2.6 and I’ve confirmed that the GMT time lag still exists for private messaging.

    I believe Ticket 2203 was supposed to fix this and was committed to the 1.2.6 release. Help?

  • Profile picture of Hugo Hugo said 1 year, 7 months ago:

    I really hope you’re wrong about that as this ongoing issue was meant to have been corrected once and for all in 1.2.6. :(

  • Profile picture of paulhastings0 paulhastings0 said 1 year, 7 months ago:

    I’m afraid so.

    But if my memory doesn’t betray me, I think it’s a different part of the private messaging system that’s showing the wrong time now.

  • Profile picture of Hugo Hugo said 1 year, 7 months ago:

    it’s displaying utc time by the looks of things at least my time stamp is an hour behind our present utc +1

  • Profile picture of Hugo Hugo said 1 year, 7 months ago:

    checking and on the dev install I was working on I hadn’t set local time in WP settings

  • Profile picture of Paul Gibbs Paul Gibbs said 1 year, 7 months ago:

    Let me know what you discover, hnla

  • Profile picture of Hugo Hugo said 1 year, 7 months ago:

    Not looking good having set my local time correctly and WP settings showing UTC and my local time messaging time stamps have now jumped ahead of my local time by 1 hour

  • Profile picture of Paul Gibbs Paul Gibbs said 1 year, 7 months ago:

    Alas, both of you are correct.

  • Profile picture of Hugo Hugo said 1 year, 7 months ago:

    trying to track down bp_core_current_time() my batch find locates references to it but I can’t find actual parent function

  • Profile picture of Paul Gibbs Paul Gibbs said 1 year, 7 months ago:

    bp core, line 1312

  • Profile picture of Hugo Hugo said 1 year, 7 months ago:

    cool cheers.

    this is/was the relevant ticket I guess?

    http://trac.buddypress.org/ticket/2203

  • Profile picture of Paul Gibbs Paul Gibbs said 1 year, 7 months ago:

    Yes

  • Profile picture of Hugo Hugo said 1 year, 7 months ago:

    Thinking the issue lies with:

    /messages/messages-loop.php

    bp_message_thread_last_post_date()

    function lives in:
    /buddypress/bp-messages/bp-messages-templatetags.php: line 288

    would guess at the filter

    bp_format_time(get_date_from_gmt(

    is possibly to blame but will have to see if the ticket sheds light on it

  • Profile picture of Hugo Hugo said 1 year, 7 months ago:

    Fix is simply that

    bp_format_time(get_date_from_gmt(

    should have been changed but likely missed to:

    bp_core_current_time(get_date_from_gmt(

  • Profile picture of Hugo Hugo said 1 year, 7 months ago:

    Nope that isn’t correct :(

    can’t be ‘current’ time