Group Mods

  • Profile picture of r-a-y
  • Profile picture of Hugo
  • Profile picture of @mercime

Support: Miscellaneous

Everything else.

Plugin Hall of Shame! :) Plugin Devs Please Read (41 posts)

Started 2 years, 1 month ago by: Andy Peatling

  • Profile picture of Andy Peatling Andy Peatling said 2 years, 1 month ago:

    Based on this topic.

    Plugin Authors — If your plugin does not appear in the “Confirmed Update Friendly” PLEASE UPDATE IT ASAP. It’s really important as your plugins are crashing/have the potential to crash user’s WordPress installations when BuddyPress is updated. This reflects poorly on the project, even though BP is not the problem.

    This will take you less than 5 minutes to do if you create a loader.php file and add the code in the link below, then just include your existing main plugin file when BuddyPress has loaded.

    http://codex.buddypress.org/how-to-guides/checking-buddypress-is-active/

    Not Update Friendly (crashes site):

    Any plugins in this list that have not been updated for 1.2 will be removed from http://buddypress.org/extend/plugins/.

    BuddyPress Events Calendar
    bpPicture Album
    BuddyPress AJAX Chat
    BP-TagBox
    Twire / Twitter to Wire
    Auto Group Join
    Achievements
    BuddyPress Stats
    CD BuddyBar Logo Changer ( is_site_admin() doesn’t exist in WP 2.9.2 before bp_init – should be current_user_can(‘install_plugins’) )
    Remove Avatars ( is_site_admin() doesn’t exist in WP 2.9.2 before bp_init – should be current_user_can(‘install_plugins’) )
    BP Translate ( is_site_admin() doesn’t exist in WP 2.9.2 before bp_init – should be current_user_can(‘install_plugins’) )

    Potentially Not Update Friendly (does not crash site but needs updating):

    Plugins that don’t crash but do not check if BuddyPress is active:

    BP Group Documents
    BuddyPress Group Tags
    BuddyPress Rate Forum Posts
    BuddyPress Multilingual
    BuddyPress Profile Widget for Blogs
    TDLC Birthdays
    Jet Random Members Widget
    Jet Random Groups Widget
    BuddyPress Admin Bar Mods
    BP Announce Group
    BP Redirect to Profile
    BuddyPress Real Names
    Buddypress Pages to Navigation
    BP Tiny MCE
    Inbox Widget
    BP Paginated Posts
    BP Registration Options
    BuddyPress Friends On-line (FOL)
    Remove BuddyPress AdminBar
    Invite Friends

    Plugins that use an old method of BP detection and need updating to use bp_init loader method:

    BuddyPress Maps
    BuddyPress Group Blog
    BuddyPress My Friends Widgets
    BuddyPress Widget Pack
    BuddyPress-Kaltura Media Component)
    BuddyPress Group Email Subscription
    BuddyPress Classifieds
    BuddyPress Quick Press
    BuddyPress Group Wiki
    BuddyPress Sitewide Featured Posts
    BuddyPress Group Activity Notifications ( Error in live version: First argument is expected to be a valid callback, ‘ass_init’ )

    Confirmed Update Friendly (high-fives!):

    Tweetstream
    Facestream
    BP Group Management
    BP Groupblog
    BP Expand Activity
    Invite Anyone
    BuddyPress Forums Extras (all)
    BuddyPress Like
    oEmbed for BuddyPress
    Forum attachments for BuddyPress
    BP Profile Privacy
    BP Notification Widget
    BP Import Blog Activity
    Custom Profile Filters for BuddyPress
    BP Include non Member Comments
    BP MPO Activity Filter
    BuddyPress Links
    BuddyPress Group Twitter
    BuddyPress External Group Blogs
    BP Random Members Widget
    BuddyPress Template Pack
    Group Forum Subscription for BuddyPress
    Enhanced BuddyPress Widgets
    BuddyPress Album+
    BuddyPress Geo
    BP Member Filter (but should move all BP specific code to separate file to be safe)
    BP Member Map (but should move all BP specific code to separate file to be safe)
    BuddyPress Restrict Group Creation (but should move all BP specific code to separate file to be safe)
    BuddyPress Sitemap Generator (but should move all BP specific code to separate file to be safe)
    Welcome Pack

    Please post a followup message if you have updated your plugin, or if you find any other plugins that crash.

    Checking your BuddyPress plugins

    Deactivate all of your plugins. Individually activate a single BuddyPress plugin. If it activates and you do not get a white screen or white screen with error message, then the plugin is update friendly. Otherwise please post it in this thread to add to the hall of shame! :) If you get a white screen then to fix this remove the plugin folder from wp-content/plugins/

  • Profile picture of francescolaffi francescolaffi said 2 years, 1 month ago:

    O.o??? isn’t is_site_admin in the bp-core-wpabstraction? I’ll check if it uses it before bp-init

  • Profile picture of Andy Peatling Andy Peatling said 2 years, 1 month ago:

    Yes but you can’t be sure bp-core-wpabstraction.php is loaded until bp_init fires. Regadless, try to use current_user_can() instead.

  • Profile picture of Paul Gibbs Paul Gibbs said 2 years, 1 month ago:

    I’m a bit offended at having some of my work in this “Hall of Shame”; a message or email to the plugin developers would have been more polite.

    I’ll update my plugins as and when I get time; client work continues to take priority.

  • Profile picture of Andy Peatling Andy Peatling said 2 years, 1 month ago:

    It’s a lighthearted hall of shame, I’m calling them out because it’s important. The updates take 5 minutes, we can’t continue to have BuddyPress crash because of plugins every time it updates.

  • Profile picture of Hugo Hugo said 2 years, 1 month ago:

    Not sure why ‘offended’, this matter cuts to the core of the issue of third party plugins causing potential damage to projects such as BP, I would have thought experienced plugin authors would have got this matter dealt with straightaway if as Andy says it’s a matter of 5 minutes work.

    I understand the pressures of work and time constraints having, as I do, to work 7 days a week to hold a small web dev company together but comments like ‘I’ll update my plugins as and when I have time’ ?! is a comment like that really necessary?

  • Profile picture of Magganpice Magganpice said 2 years, 1 month ago:

    I guess there are no experienced BP plugin authors because BP hasn’t been around for a long time.

    It’s important to get this topic out there and the frequently used plugins fixed quickly. Otherwise people will have strange feelings every time an update for BuddyPress comes out. That hurts BuddyPress.

    (I don’t understand though: is there really no way to take care of “white screens” from the other side – from WordPress side? Like a try…catch fatal error thing which would deactivate the plugin causing the error?)

  • Profile picture of Andy Peatling Andy Peatling said 2 years, 1 month ago:

    @Magganpice – yes there is a fatal error catcher when activating plugins, but not when a plugin is deactivated on upgrade.

  • Profile picture of rich! @ etiviti rich! @ etiviti said 2 years, 1 month ago:

    # BuddyPress Restrict Group Creation
    # BuddyPress Sitemap Generator

    both use
    add_action( 'bp_init',

    but i just noticed restrict group used wp_head so i’ll change that to bp_head

  • Profile picture of Andy Peatling Andy Peatling said 2 years, 1 month ago:

    @etiviti (rich!) – Yes, but the code needs to move to a separate file as it’s as simple as referencing a BP function in that code and it will break. It’s risky.

  • Profile picture of rich! @ etiviti rich! @ etiviti said 2 years, 1 month ago:

    ah the loader.php way (i had the older check)

    When the new and cool bp-org site comes online – possible to have a plugin developer group where best practices, codex updates, etc can be communicated? (just auto assign the user when it picks up the plugin?)

    also what about instances where we need to modify items before bp_init? is loading the file on bp_core_loaded ok? (only way I can get restrict group to function properly)

  • Profile picture of Boone Gorges Boone Gorges said 2 years, 1 month ago:

    OK, you can take me off the Shame List. I’ve just put new versions of Group Forum Subscription and Enhanced BuddyPress Widgets into the repo that use the loader method. HIGH FIVE FOR MYSELF!!

  • Profile picture of Andy Peatling Andy Peatling said 2 years, 1 month ago:

    @etiviti (rich!) – Modifying items before bp_init is fine in the main file, but you must be careful not to reference any functions in BuddyPress.

  • Profile picture of Chouf1 Chouf1 said 2 years, 1 month ago:

    Hem…

    Is it possible to have BP updating without wipping out the previous version .mo file from bp-languages ?
    Or at least a warning message telling “bp was succesfully updated, but thi erased your language file. You can upload a new language file at http://i18n.trac.buddypress.org/browser

    It is a bit annoying for us foreigners, to suddenly have all in english after each BP update.
    Ihttp://i18n.trac.buddypress.org/browser

    I know, this should be on trac under Future enhancement, but not only 3rd party plugins authors need to be remembered to correct their work.

  • Profile picture of Andy Peatling Andy Peatling said 2 years, 1 month ago:

    A bit off topic but – yes, I’m committed to making this happen in 1.3.