Skip to:
Content
Pages
Categories
Search
Top
Bottom

Adding template_notices to theme files

  • Avatar of Travel-Junkie
    Boris
    Participant

    @travel-junkie

    How about we add “ calls to normal theme files?
    Most of the time they won’t be used, but I’ve written a few plugins now that deal with posts and it’d be useful to output any error/success messages. They won’t do any harm there neither if they’re not used.
    Just a thought…

Viewing 19 replies - 1 through 19 (of 19 total)
  • Avatar of Tammie
    Tammie
    Moderator

    @karmatosed

    You mean just add in the page.php / index / single and so on?

    Avatar of Hugo
    Hugo
    Moderator

    @hnla

    It’s a good point, where would it go ? Directly after do_action(‘bp_before_blog_home’) ?

    It would need to be in a minimum of ‘index’, ‘page’, and possibly ‘archive’

    Avatar of Travel-Junkie
    Boris
    Participant

    @travel-junkie

    Just below div class=”padder” works good. I’d say in archive.php, index.php, page.php, single.php.

    Make a patch and I’ll look at it after work

    Avatar of Hugo
    Hugo
    Moderator

    @hnla

    :( forgot about Billy Nomates single.php

    yep after .padder makes sense, ensures it claims static position rather than following after whatever might be hooked into those various bp_before_blog_… actions

    Avatar of Tammie
    Tammie
    Moderator

    @karmatosed

    Lol to Billy Nomates single.php :)

    So this would be for messages / alerts that type of thing?

    Avatar of Travel-Junkie
    Boris
    Participant

    @travel-junkie

    http://trac.buddypress.org/ticket/2739

    @karmatosed
    yup, just your regular old error/success messages you get on all the BP files

    Avatar of Hugo
    Hugo
    Moderator

    @hnla

    Just added ticket and patch so may have duplicated your efforts there @travel-junkie – sorry but wanted to verify for myself how multiple file patching worked .

    http://trac.buddypress.org/ticket/2740

    Avatar of Hugo
    Hugo
    Moderator

    @hnla

    @DJPaul Paul is it my imagination or do a lot of files seem to be missing add_action(template_notices) or be using an older implementation?

    Not all the files need them. Quite often the notices are in the components’ -header.php files.

    Avatar of Hugo
    Hugo
    Moderator

    @hnla

    Understood.

    Avatar of Travel-Junkie
    Boris
    Participant

    @travel-junkie

    Hmm, how do you actually add patches to trac. Maybe I’m just being thick, but all I could find was just normal attachments..

    Avatar of Hugo
    Hugo
    Moderator

    @hnla

    it is attachments you just upload a .patch file of course if one had commit accessor were working on ones own svn repository you would simply add / merge the changes to a branch or trunk

    I can find you some instructions on how to make patch files from a svn repo if you let me know what OS you use, Travel-Junkie?

    Avatar of Travel-Junkie
    Boris
    Participant

    @travel-junkie

    @DJPaul
    Cheers, mate! I’m on Windows 7, but I found out in the meantime myself.

    Avatar of Hugo
    Hugo
    Moderator

    @hnla

    Tortoise! One of those times where it beats trying to wrestle with the command line /shell :)

    @hnla Following on from what you said earlier, I’m checking all theme files in branch and trunk just in case trunk has missed any changes.

    Everything’s in-sync.

    Avatar of Hugo
    Hugo
    Moderator

    @hnla

    Edit// too slow sorry I should have run comparisons earlier.

    @DJPaul it might be worth a check, might also be me worrying , but wasn’t sure where this add_action should occur. I note 7 files in bp-default with 8 occurrences in 1.2.6 and the same for trunk in my local checkouts so think all is ok a wild goose chase? sorry!

Viewing 19 replies - 1 through 19 (of 19 total)

The forum ‘BP-Default’ is closed to new topics and replies.