Skip to:
Content
Pages
Categories
Search
Top
Bottom

bp-events for bp 1.1 needs testing!

  • Avatar of Mariusooms
    Mariusooms
    Participant

    @mariusooms

    I have, with the plugins authors permission, ported and refactored the bp-events plugin. A lot of code has been cut, tons of stuff changed, but the functionality remains the same. Now based on the new bp group architecture.

    Features that were not yet implemented or half working have been left out for now. The plugin has the basic events functionality with the added bonus of working event forums. It now also includes date validation so you can not set events in the past or start dates that are later than end dates. It also has more template tags to list your events in group pages.

    Now this plugin needs some testing for those that are using (testing) bp trunk. The installation of the plugin has changed as it is now located in the plugins folder along side buddypress. Please view the readme for installation instructions if needed.

    NOTE: The author has not yet reviewed / approved these changes, but I am confident they are good. Therefore it would actually help the author if you would participate in testing and posting your results.

    If you have any questions…shoot!

    Send me a message with your email, so I can send you a zippie!

Viewing 25 replies - 1 through 25 (of 39 total)
  • Avatar of Mariusooms
    Mariusooms
    Participant

    @mariusooms

    You can get the trunk version here:

    http://svn.ywamnetworks.com/bp-events/trunk/

    Avatar of Alex Cragg
    Alex Cragg
    Participant

    @epicalex

    Fantastic! I’m running a live blog on trunk, (yeah yeah I know), and really need the events plugin working for the site to work. Downloading from trunk now, will give feedback in due course.

    Thanks for your work on this.

    Avatar of Alex Cragg
    Alex Cragg
    Participant

    @epicalex

    OK, well I had a few problems to start with, mainly due to remnants from the previous plugin version’s structure.

    Another thing to note is that I tried putting the events directory in the framework directory rather than the default theme directory, and that caused things not to work. I think it would be better, and in line with groups and member directories, if events could be added to the framework, not just the theme.

    When I look at an event that was already created prior to installing this version, I see the location as it should be, however, when going to the front end admin screens, the location is set to the tagline. Updating the location instead adds the new location to the recent news, and leaves the location unchanged IN THE FRONT END ADMIN SCREENS.

    There are no icons for the event menu list.

    Event invite isn’t working, but I don’t think it is for groups either.

    The ajax loading icon has gone from the widget; although the ajax change in newest etc still works, without the loading icon it isn’t necessarily clear that anything is happening.

    Also for the widget, can we have event details back in?

    Going to domain.com/events doesn’t bring anything up; I’m assuming that this will be where the calendars will be put back in?

    This is definitely a step in the right direction. Things seem cleaner. But some of those features really need building back in once this base is established.

    Avatar of Mariusooms
    Mariusooms
    Participant

    @mariusooms

    OK, well I had a few problems to start with, mainly due to remnants from the previous plugin version’s structure.

    The main purpose was actually moving forward as I had no way of testing backwards compatibility. Therefore please don’t expect to much out of old events, rather focus on creating new ones.

    Another thing to note is that I tried putting the events directory in the framework directory rather than the default theme directory, and that caused things not to work. I think it would be better, and in line with groups and member directories, if events could be added to the framework, not just the theme.

    Actually when dealing with parent and child themes, it is best to leave the framework alone imo. Since than you don’t lose any information when updating the frame work. I think this is common with parent/child themes. Evens so, it should just work in the framework folder as well. What exact errors were you having in regards to this.

    When I look at an event that was already created prior to installing this version, I see the location as it should be, however, when going to the front end admin screens, the location is set to the tagline. Updating the location instead adds the new location to the recent news, and leaves the location unchanged IN THE FRONT END ADMIN SCREENS.

    Again, this is probably due to incompatibility with the previous version. Namely the website field has been left out, which is likely to shift everything around. I’m not sure.

    There are no icons for the event menu list.

    Hmmm, they work fine on my install. Please check where the path is pointing to for the image that is missing.

    Event invite isn’t working, but I don’t think it is for groups either.

    Yeah…did not get around testing this, but should behave the same way as groups as the architecture is identical.

    The ajax loading icon has gone from the widget; although the ajax change in newest etc still works, without the loading icon it isn’t necessarily clear that anything is happening.

    Ajax functionality is lacking yes.

    Also for the widget, can we have event details back in?

    I actually did not change the widgets. I would have to check this out.

    Going to domain.com/events doesn’t bring anything up; I’m assuming that this will be where the calendars will be put back in?

    The directory still needs to be ported. You could theme your own.

    This is definitely a step in the right direction. Things seem cleaner. But some of those features really need building back in once this base is established.

    It is essential that the base is solid imo. Before the plugin was so much and much of it did not work. I think it could also be versioned better, but that is really up to the author. At this point my aim was to help jump start this plugin. Code and patches are welcome if you would like to help.

    Avatar of Alex Cragg
    Alex Cragg
    Participant

    @epicalex

    For the missing icons, I’ve checked the css, and the source file screen.css, and there aren’t actually any rules set up for styling the list items.

    http://svn.ywamnetworks.com/bp-events/trunk/events/_inc/css/screen.css

    Also, just noticed that the link to create a new event says “Create a Event”, not ‘an’.

    I just set up a new event, and the issue with the location still exists.

    Is there a trac where I can submit patches?

    Avatar of Mariusooms
    Mariusooms
    Participant

    @mariusooms

    No trac, but you can just send patches or code through my profile or irc. The svn at the moment is temporary until Erwin takes over again. I should note, that while testing is really appreciated and that you for sure can use the plugin as is, there is no guarantee that Erwin will actually use this code base and he could take a different direction all together. Just to disclaim on my part :) So, also new features will not be implemented as the base code first needs to be accepted.

    That being said. On what url or you missing icons? I might have completely overlooked it. I have gone through a LOT of code, so it easy to miss something. I’ll fix the translation as well. Thanks…

    I just set up a new event, and the issue with the location still exists

    This could be because you have upgraded? On a clean install I am pretty sure this is not the case, but I will verify later today.

    Avatar of Simon
    Simon
    Participant

    @conceptfusion

    Hi Mariusooms

    Looks like your code contains a sql bug I pointed out to Erwin (that was fixed in the .59 trunk) a couple months ago… see the first (bottom) wire post on the a href=”http://buddypress.org/groups/bp-events”>bp-events group here on buddypress.org. Occurs when you select Events in the user menu.

    Also, when you select Groups from the user menu both Groups and Events are set to their selected state.

    Avatar of John James Jacoby
    John James Jacoby
    Keymaster

    @johnjamesjacoby

    @conceptfusion, I have that bug fixed in the next bp-events.php file. I’m going to lend a hand trouble shooting this while I do the bp trunk at the same time.

    Avatar of Mariusooms
    Mariusooms
    Participant

    @mariusooms

    Thanks conceptfusion and major props to John James Jacoby for helping out.

    Avatar of John James Jacoby
    John James Jacoby
    Keymaster

    @johnjamesjacoby

    :D

    bp-events.php updated in trunk to take care of the navigation issues and hopefully knock out a notifications bug or two.

    Anyone using a windows machine to SVN, I’d recommend TortoiseSVN and WinDIFF to be able to keep up with changes. Will help you a lot to see what changes and why.

    Avatar of Alex Cragg
    Alex Cragg
    Participant

    @epicalex

    About the missing icons, it’s when viewing an event, so /events/event-name .

    I’ve added code to the screen.css so that the images show. Also added a rule so that the event icon shows on the recent activity stream.

    Can I commit them to the svn, or send you the file? Or was I the only one who didn’t see them anyway?!

    Avatar of Alex Cragg
    Alex Cragg
    Participant

    @epicalex

    OK. There seems to be larger problems afoot. I wanted to start from scratch, to try and sort issues with the event fields, so I dropped all the event tables and deleted all the plugin files.

    I re-uploaded and went to the plugin admin page. Activated the plugin, and checked the mysql tables; nothing had been created. I tried a few other things to try and get the tables created. Logged out and in, went to the event settings page, resaved settings. Still no new tables.

    I then took the sql code from the plugin and created the tables manually. When I then tried to create an event, it tells me an error has occurred.

    Mariusooms, you said that this should work with a fresh install, but something doesn’t seem to be right!

    So has the original developer abandoned bp-events?

    Avatar of Mariusooms
    Mariusooms
    Participant

    @mariusooms

    so I dropped all the event tables and deleted all the plugin files

    This will not work because every plugin sets a table version number, so you would have to up the number in the plugin. It is in the first few lines of bp-events.php. Also, possibly tables will get created when you actually create an event, not on install.

    So has the original developer abandoned bp-events?

    No, but he is still very busy getting a stable version out for the bp1.0.3 branch. With BP1.1 around the corner there is a huge need for many site owners to have an events plugin that supports bp1.1. I can’t afford to wait, so I’m picking up the torch for now and John James Jacoby has offered to help.

    This is the beauty of open source, nobody has to sit on side lines and watch the development. Jump in and get your hands dirty.

    Avatar of Mariusooms
    Mariusooms
    Participant

    @mariusooms

    epicalex at line 15:

    define ( 'BP_EVENTS_DB_VERSION', '1700' );

    So, disable the plugin, up the number and re-enable the plugin. Create an event and you should have tables.

    Avatar of Alex Cragg
    Alex Cragg
    Participant

    @epicalex

    OK, done that. I’m now getting an error after the first creation screen, and this error in my logs

    WordPress database error Unknown column ‘avatar_thumb’ in ‘field list’ for query INSERT INTO wp_bp_events ( , referer: http://domain.com/members/admin/events/create/

    It appears as though the plugin isn’t creating that field in bp-events.php, I can’t find any reference to it anyway, and then in bp_events_classes.php, avatar_thumb and avatar_full have commands to have information inserted into them in the save() function.

    I added the necessary lines to add those fields in the sql create and everything works…

    Avatar of Mariusooms
    Mariusooms
    Participant

    @mariusooms

    Sorry, that field is a remnant. avatar_thumb is deprecated in core so also for bp-events. Just remove the references as they don’t do anything. I must have forgotten some as I updated from core code. That’s working with trunk, it changes daily.

    Avatar of Mariusooms
    Mariusooms
    Participant

    @mariusooms

    Hang on epixalex, it looks like the fault is at my end as I’ve juggled a few things around since my last copy and created a few misbehaves. Let me sort those out first as we continue.

    Avatar of Mariusooms
    Mariusooms
    Participant

    @mariusooms

    Okay, things should be better now. Pending what jjj will add, I fixed the issue with tagline and location as well as cleaned up references in regards to avatar_thumb and avatar_full.

    Please test and report back. Thank you for you patience and sorry for the inconvenience.

    http://svn.ywamnetworks.com/bp-events/trunk/

    If you have a svn client you can track changes easier.

    Avatar of John James Jacoby
    John James Jacoby
    Keymaster

    @johnjamesjacoby

    Since BP Events basically started out as the core groups component but was reverse engineered to include event specific code and contents, you’ll find some references to the groups functionality in random places still. I’m trying to weed those out and keep up with the BP trunk changes.

    Avatar of matthijsv
    MatthijsV
    Participant

    @matthijsv

    Installed the plug-in, it’s looking good! I’ll post results after I’ve done some testing.

    Question: I want to create a widget just like the wordpress calender: http://www.sajidmc.net/wp-content/uploads/2009/04/screenshot-1.png

    but than for the events. Any idea’s how I can do this quickly?

    I know how to script, but don’t know where to start with this.

    Avatar of Alex Cragg
    Alex Cragg
    Participant

    @epicalex

    Just working on a clean install of BP, and tried activating bp-events, running trunk. I get the following error a couple of times on different lines:

    Call-time pass-by-reference has been deprecated; If you would like to pass it by reference, modify the declaration of do_action(). If you would like to enable call-time pass-by-reference, you can set allow_call_time_pass_reference to true in your INI file in /wp-content/plugins/bp-events/bp-events.php on line 2221

    and also Failed opening required ‘/wp-content/plugins/bp-events/bp-events-cssjs.php’ (include_path=’.:/usr/local/php5/lib/php:/usr/local/lib/php’) in /wp-content/plugins/bp-events2/bp-events.php on line 21

    @matthijsv You could look at how WP constructs the calendar, ie how it populates it with posts, and work from that.

    Avatar of Mariusooms
    Mariusooms
    Participant

    @mariusooms

    With the many core changes as of late, I’m updating the different functions as 1.1 beta roles out. However I am unable to duplicate the issues you mention as of yet. It actually looks like a config issue with your server as it is suggesting a solution to adjust your ini file.

    Also it looks like your bp-events folder is name bp-events2, which will not work since it will not load the required files appropriately.

    Avatar of Alex Cragg
    Alex Cragg
    Participant

    @epicalex

    Surely if the paths are coded dynamically, it shouldn’t matter what it’s called? Could use the plugin_basename and basename functions?

    However…I changed the name to bp-events, and the plugin activated, but I have some stray code in my header lters.php' ); } ?>

    Seems like it’s just been left in at the end of the file.

    Avatar of Mariusooms
    Mariusooms
    Participant

    @mariusooms

    Okay… abit of Googling, it looks like Call-time pass-by-reference is indeed deprecated, which should be fixed. It is probably a warning error, so for the time being you could turn off error-reporting or google for a fix to set a flag in your ini file to allow that reference. If you are on a shared host you can do it also via your htaccess file.

Viewing 25 replies - 1 through 25 (of 39 total)

You must be logged in to reply to this topic.