Skip to:
Content
Pages
Categories
Search
Top
Bottom

Bug when deleting posts

  • Avatar of rossagrant
    rossagrant
    Participant

    @rossagrant

    Hi Frances,
    Awesome plugin by the way!

    Just been testing it out. Reported a couple of posts which I could then view in the backend as reported. All worked great.

    Only thing is when I came to delete them, if I click on the red ‘delete’ link under a post in the moderation backend it processes and tells me ’0 items have been deleted’. The post actually has been deleted but it still remains in the content section with all of the moderation links under it.

    IF however I tick the box next to the post and then hit delete it tells me ’1 item has been deleted’ and then changes the moderation links to just view or edit.

    Just wanted to let you know as it looks like a small bug but one that you could perhaps fix quickly if it’s not a massive issue.

    It really is a great plugin though and exactly what BP needs!
    Let me know your thoughts!
    Ross :)

Viewing 12 replies - 1 through 12 (of 12 total)
  • Avatar of rossagrant
    rossagrant
    Participant

    @rossagrant

    Just to let you know, when clicking on ‘Send PM’ under a user in the moderation backend, it throws up a ‘Page Not Found’ error too.
    Thanks again for your time,
    Ross :)

    Avatar of rossagrant
    rossagrant
    Participant

    @rossagrant

    @francescolaffi just a note on the above bug regarding PM’s.
    The url it tries to direct to is

    http://sharespeak.co.uk/compose/?r=username of whom i want to message

    when I think it should be

    http://sharespeak.co.uk/members/myusername/messages/compose/?r=username of whom i want to message

    Thanks again.

    Avatar of francescolaffi
    francescolaffi
    Participant

    @francescolaffi

    @rossagrant thanks for the issue reports, I’ll check those problems.
    What’s your test environment? knowing php, wp, bp versions could help me finding the problem.

    Avatar of rossagrant
    rossagrant
    Participant

    @rossagrant

    @francescolaffi

    Hi, I’m using WP 3.0, BP 1.2.4.1 and php ver 5.2.13

    Hope that info helps.
    The moderation plugin is perfect it really is great. If we could just iron out these couple of bugs then it would be spot on!
    Thanks for your hard work!

    Avatar of francescolaffi
    francescolaffi
    Participant

    @francescolaffi

    I committed a version that fixes the send PM links and group flagging.
    Sadly I wasn’t able to reproduce the bug when deleting posts, I’ve tried in both single and multi site installs but it always gives success message.
    So I’ll probably need some more details on this one:
    do you get the same error on a fresh install with only wp, bp and bp-moderation?
    - if no I need more details on the site on which you have the problem (other plugins, update history)
    - if yes I need detailed step-by-step instruction on how to reproduce the problem, with the capability of each user involved (who write the post, who flag it, who tries to delete it) and the relationship between them. Also don’t forget to mention if you are testing on single or multi site install

    Thanks!

    Avatar of rossagrant
    rossagrant
    Participant

    @rossagrant

    @francescolaffiSo is there a new version to download with the above fixes in?

    With regards to the delete bug I am experiencing it does happen with only BP and BP Moderation activated.

    I have tested it a few times and these are the steps I take.

    1.) Log in as a regular user and make a forum post.
    2.) Log in as a different user and report the post.
    3.) Log in as admin and go to ‘Moderation’ in the backend.
    4.) The flagged message is there.
    5.) I do not tick the box next to the flagged message I just hover over the red delete button and click it.
    6.) I get a message, ’0 items have been deleted’.
    7.) If I click on the view button under the message it takes me to the forum but the message is gone so it HAS been deleted even though the plugin told me, ’0 items have been deleted’.

    8.) If I then tick the box next to the message and hit delete for a second time, the plugin tells me, ’1 message has been deleted’ and the links underneath the message change to just ‘view’ or ‘ignore’.

    It looks like it comes down to whether I tick the box next to the message or not. If the box is ticked it works, if not it still works but says it hasn’t deleted anything and leaves all of the moderation options still there.

    I am using BP 1.2.5.2 and WP 3.0 on a single install.

    Can anyone else recreate this?
    Thanks Frances, let me know if you can recreate this too.
    Ross :)

    Avatar of techguy
    techguy
    Participant

    @crashutah

    I think I’m having a similar problem and I can reproduce what @rossagrant said above. Although, I tested the “ticking the box” on the left side. That makes no difference. It’s just the fact that you go and delete it the second time that it gives the message that it’s been deleted (even though it really deleted it the first time you click it).

    The more disturbing part of this is that when you click the view it doesn’t actually take you to the forum posts (I think this only happens when a forum post is moderated and not other items).

    I think i found the problem too. The view link for the moderated forum post looks something like this:
    http://domain.com/groups//forum/topic/test/#post-2

    You can see that the slug of the group is missing in the URL. I added the slug and the group forum post that I’d moderated appears. I haven’t dug into the code to see why it’s not pulling the group slug properly, but hopefully this will make it so @francescolaffi can put out a fix pretty quickly.

    Avatar of rossagrant
    rossagrant
    Participant

    @rossagrant

    @crashutah nice spot! I thought it was ticking the box that was deleting it second time round but it may well be that second time round regardless of whether the box is ticked that BP moderation reports it’s been deleted even though it was deleted first time!

    At least I know I’m not going mad then!

    The plugin is still functional and does it’s job but it just needs these tiny things ironing out.
    I can’t wait for the official release of it and maybe the option to change the ‘flag this post as innappropriate text’.
    Great addition and essential to any BP site!
    Keep me posted on any fixes for the above issue!

    Avatar of francescolaffi
    francescolaffi
    Participant

    @francescolaffi

    @rossagrant @crashutah thanks for the detailed report, it helps a lot, I’ll look deeper in it asap and post here updates

    the checkbox should make no difference, it is there for ‘bulk actions’ but I still have to implements them :) . ‘bulk action’ will work selecting some contents and an action from a dropdown menu like in wp posts or comments tables.

    Avatar of francescolaffi
    francescolaffi
    Participant

    @francescolaffi

    @rossagrant @crashutah fixed! at least it seem so and i hope so ;)

    It is already in the gsoc repo but still not in the wp repo, by today/tomorrow I’ll commit in the wp repo this fix along with others and some new features to test. I’ll open another topic for it.

    Avatar of francescolaffi
    francescolaffi
    Participant

    @francescolaffi

    Avatar of rossagrant
    rossagrant
    Participant

    @rossagrant

    @francescolaffi I can confirm this update fixes this bug! THANKS SO MUCH!
    This is without a doubt the most essential BP plugin around now!

    Looking forward to even more functionality in the future! Great job! :)

Viewing 12 replies - 1 through 12 (of 12 total)

You must be logged in to reply to this topic.