Skip to:
Content
Pages
Categories
Search
Top
Bottom

Localization problems in 1.0b1 and 1.0b2

  • A few random notes for now. I’ll add others as I proceed. Having reviewed the BuddyPress files in mu-plugins root for 1.0b1 and 1.0b2, I find a lot of the following:

    Presentation of date and time differs from culture to culture. Its better to mark these as translatable strings than to hard code in a western standard.

    My understanding is that when a text domain is used to denote a language file other than the main WordPress MU language file, it needs to be added to every marked string, not just the first marked string in a line.

    I’ve found a couple of instances like this from line 63 of bp-blogs/bp-blogs-ajax.php:

    _e( sprintf( 'Latest Post: %s', '<a>blog_id ) . '">' . apply_filters( 'the_title', $post[0]->post_title ) . '</a>' ), 'buddypress' );

    That won’t be recognized. This will:

    sprintf( __('Latest Post: %s', 'buddypress'), '<a>blog_id ) . '">' . apply_filters( 'the_title', $post[0]->post_title ) . '</a>' );

    I also find a lot of instances of sentence fragments interspersed between segments of code. Syntax varies significantly between languages; sentence fragments are often untranslatable – without going in and tweaking the code.

    Here’s what I have so far, line numbers only I’m afraid. I expect I’ve missed a lot even in these few files. Line numbers are from 1.0b2

    bp_core.php: 785, 788

    bp-friends.php: 261, 265, 271, 275

    bp-groups.php: 1100, 1103, 1114, 1116, 1127, 1129, 1141, 1143, 1154, 1156, 1167, 1169

    bp-messages.php: 372, 374

    bp-xprofile.php: 577, 580

    bp-blogs/bp-blogs-ajax.php: 53

    bp-blogs/bp-blogs-ajax.php: 44

    bp-blogs/directories/bp-blogs-directory-blog.php: 106, 177

    If you’ll leave this string open, I’ll add to it as I go along.

    Michael

Viewing 9 replies - 1 through 9 (of 9 total)
  • Avatar of Andy Peatling
    Andy Peatling
    Keymaster

    @apeatling

    Can you add this to a ticket please?

    Sorry, I don’t have a good experience with the BuddyPress trac. I can stop here, if you prefer.

    bp-core/bp-core-activation.php: 128, 129

    bp-core/bp-core-ajax.php: 112

    bp-core/bp-core-signup.php: 154, 243, 301

    bp-core/directories/bp-core-directory-member.php: 105, 171

    I’m starting again with 1.0 rc1 and will post results in trac. So far, I see many improvements in the area of localization. Thanks.

    I’m assuming there’s no reason to upgrade from 1.0b1 to b2 first, rather than directly from b1 to rc1.

    I’m starting again with 1.0 rc1 and will post results in trac. So far, I see many improvements in the area of localization. Thanks.

    I’m assuming there’s no reason to upgrade from 1.0b1 to b2 first, rather than directly from b1 to rc1.

    Avatar of MartinNr5
    MartinNr5
    Participant

    @martinnr5

    There should be no problem going from B1 -> RC1.

    Thank you Martin – seems we share some of the same concerns. You’re working with one of the Scandinavian languages?

    Avatar of MartinNr5
    MartinNr5
    Participant

    @martinnr5

    Yes, Swedish.

    I’m 85% done and should be able to wrap the RC1 translation up over the weekend.

    A friend in Budapest and I have a Hungarian .mo based on 1.0b1 with only 2 untranslated strings, but there are so many unmarked strings in the code its hard to say how close we really are to being done. Hopefully there won’t be many new texts among the unmarked strings.

Viewing 9 replies - 1 through 9 (of 9 total)

You must be logged in to reply to this topic.