Skip to:
Content
Pages
Categories
Search
Top
Bottom

Members directory code

  • Avatar of Tammie
    Tammie
    Moderator

    @karmatosed

    I’ve done a version one of the code for the new members directory:
    https://gist.github.com/3743761

    Image here:

    This is very much a concept not a set version. The CSS is at the bottom of the file – I’ve also commented out or removed (if needed) CSS that I’ve done changes to (for instance submit buttons).

    Few points to kick off the debate:
    1. Do we want to have as a li or a dl?
    2. Do we want things like ‘generic’ classes and specific ones ie; member-title item-title?
    3. I removed the role=main as most themes assign roles – seems potential duplicates if we also add
    4. Do we want a prefix ie; buddypress- or are we going to use a #buddypress
    5. Where possible I am using things like % and this includes for fonts. I think best to avoid any exacts like px – if we have to a rem could of course work.
    6. I added in a style for the submit / button but we need to consider if we do that or leave that up to defaults be they browser or theme.

    Thoughts welcome and feel free to poke the code around and suggest changes via gist.

Viewing 10 replies - 26 through 35 (of 35 total)
  • Avatar of Hugo
    Hugo
    Moderator

    @hnla

    @DJPaul

    Less/lass has done it’s work as supplied via the install package it’s simply there for convenience if someone wanted to edit CSS they would have choice of doing so using the supplied less file if they wanted or not.

    A basic workflow would be writing to css less file compiling locally then committing two files, the CSS actual and the less file; so if I was supplying a patch for styles I would edit the css.less file that would – on my setup – compile automatically on file save I would then upload both styles.css and styles.less as a patch.

    It’s an interesting idea.

    To put it another way, Hugo: what you’re saying could apply to the regular minified CSS. So, if someone makes a chance, they’d have to regenerate the minified CSS and commit that too. I hope you can understand that is inefficient and worse than how it’s done now.

    Avatar of Roger Coathup
    Roger Coathup
    Participant

    @rogercoathup

    @djpaul – Who would be changing the minified CSS file? The only people generating the default CSS file for committal (and released with a version of BP) would be the core devs.

    You’d be supplying the end user / developer with both CSS files and the SCSS (or LESS) files – they can then develop with whatever paradigm they prefer — either exactly as they have to to-date with the CSS, or more efficiently with the SCSS files.

    If you set they SCSS files up in a well structured manner, they can then easily reimplement the parts of interest to them, and generate their site CSS more efficiently.

    Have a look at Compass or Foundation to get a better feel about how this works in practice.

    I know exactly how it works, I use LESS with my Achievements plugin.

    Minifying CSS and building from a LESS file are both extra steps. Core has the first done automatically, and I strongly doubt we would consider using LESS unless that could also be automated.

    Avatar of Roger Coathup
    Roger Coathup
    Participant

    @rogercoathup

    Unless you are not explaining the issue well enough, I don’t see what the problem is.

    Any LESS / SCSS compiler generates the CSS for you (and creates the files automatically), which you can then pass to your minifier bot.

    Are you working with a system where the LESS is ‘interpreted’ by Javascript when the site is rendered, rather than a compiler integrated with your IDE?

    [Edit: but the comment wasn't about how LESS / SCSS compilers work. It was about the paradigm for core releases / end user development that frameworks such as COMPASS, Foundation, Bootstrap, etc. support]

    Avatar of Hugo
    Hugo
    Moderator

    @hnla

    @DJPaul
    Where is this minified file? I’ve never noticed BP minifying anything certainly the file I have here isn’t and that is the point at which one edits the file whether it be less or regular css file so regardless not sure what minifying has to do with things, but is this new to BP 1.7?

    btw “I hope you can understand” is a little bit patronizing :)

    Avatar of Tammie
    Tammie
    Moderator

    @karmatosed

    @rogercoathup: Don’t worry I don’t need to have it explained what less is as I use less in all my own work however in this case I think working with plain CSS is going to be easier to start off with for people contributing and the setup (or at least until a decision is made).

    Avatar of Roger Coathup
    Roger Coathup
    Participant

    @rogercoathup

    @karmatosed – comment was not any reference to you — it’s a direct reply to something Paul posted (see earlier in the thread), and is a comment about the way frameworks based on the language work from an end user / developer perspective, and NOT about general use of the language (e.g. LESS)

    Avatar of Tammie
    Tammie
    Moderator

    @karmatosed

    @rogercoathup: I was on time delay responding to your first comment :)

    suggest rather than writing raw CSS, you work in LESS, or better still SASS — will make it much easier to work with BP styling — supporting factoring out into different files / template, easier separation of colours / layouts / typographic, etc, colour (and font) schemes (i.e. using variables for the colours, which might be a real boon for basic BP themers) .., but most importantly given the nature of BP (and this discussion)… it deals much better with nested selectors.

    You still have CSS files churned out that ‘non-savvy’ devs can work with, but also provide a much more useful set of files for those who can.

    Note: of the major frameworks out there — Twitter Bootstrap provides LESS files, whilst Zurb Foundation provides SASS / SCSS. They really are the future for high powered CSS work and definitely the way BP should be going to support development on future versions of the platform.

    Avatar of Tammie
    Tammie
    Moderator

    @karmatosed

    I just updated the code: https://gist.github.com/3748782

    Here is the current image:

    What I’ve done is removed all traces of styling for now focusing on the simple formatting.

Viewing 10 replies - 26 through 35 (of 35 total)

The forum ‘BP-Default’ is closed to new topics and replies.