Skip to:
Content
Pages
Categories
Search
Top
Bottom

Opened some tickets in response to threads

Viewing 6 replies - 1 through 6 (of 6 total)
  • I’ve dealt with 2752

    Avatar of Tammie
    Tammie
    Moderator

    @karmatosed

    Cool thank you. My only thoughts on that would be maybe then go with for the id sidebar-default but we may be messing up existing stuff for people. Totally get not calling it sidebar and sorry blind mind spot on that one in my suggestion.

    The big reason for ids and it being drummed into theme designers was it auto created and often got messed up and was particularly relevant for child themes. But all of this may be overkill if we’re only having one without an id maybe?

    This seems as good as topic as any. I’ve just put in a fairly substantial commit to functions.php; full notes at http://trac.buddypress.org/changeset/3496/?utm_source=twitterfeed&utm_medium=twitter

    I’m going to look at the new styles tomorrow when I get a chance to test them, but as long as they work OK, they’ll be put in :)

    Regarding the styles, thank you for the changes @karmatosed, I put in all of them other than the following:

    .sticky — didn’t look visually appealing with the rest of BP-Default.
    .big — please can this be done in pixels, not a percentage, like the rest of the font sizes in the theme?
    I left out the IE6 underscore hack for sub/sup as I don’t believe BP-Default should support an obsolete browser.

    I’ve left the ticket open until we get these sorted. Again, thanks very much for your efforts around the theme so far :)

    Avatar of Tammie
    Tammie
    Moderator

    @karmatosed

    Cool ty for that and no problem just glad to be able to add something.

    I’ve updated a sticky and big style with some suggestions for the sticky. Put them on the ticket. http://trac.buddypress.org/ticket/2753#comment:7

Viewing 6 replies - 1 through 6 (of 6 total)

The forum ‘BP-Default’ is closed to new topics and replies.