Skip to:
Content
Pages
Categories
Search
Top
Bottom

Page and template suggestions from Theme Unit and Review

Viewing 25 replies - 1 through 25 (of 38 total)
  • Avatar of Hugo
    Hugo
    Moderator

    @hnla

    Bit of a moot point in both senses of the word, but if choices are going to be made then lets stick to the more traditional ones.

    As for
    left sidebar
    3 column
    not sure how these fit but would think that they may be more worthy of consideration when the time comes to think about developing the next kick arse default theme, that way more time and thought can be given to providing a more flexible framework with choices in respect of columnar layouts etc.

    I’m still hoping that some effort and thought will be expended in looking towards the core app and it’s interaction in terms of themes / presentational layer and how that can be improved and there are many areas where it could and which will mean a more flexible sophisticated app that suits full themes and designers better – I’ll probably set a group running soon that I’ve been trying to push towards for the last year here, that will attempt to identify and address what are seen to be issues, but I would expect that that group would run in tandem with this as there are natural crossover / convergence points – but I digress and take thread off tangent – my bad!

    Avatar of Tammie
    Tammie
    Moderator

    @karmatosed

    I get your point about traditional templates more listing things out there than anything so that’s cool. I guess the big one standing out would be full width then onto ‘do we include ones Twenty-Ten do’.

    “I’m still hoping that some effort and thought will be expended in looking towards the core app and it’s interaction in terms of themes / presentational layer and how that can be improved and there are many areas where it could and which will mean a more flexible sophisticated app that suits full themes and designers better “

    Really interested in what you’re thinking there so will check out that group when you do start it. Anything that takes themes forward can’t be bad in my book.

    Just added a full width page template to trunk: http://trac.buddypress.org/changeset/3428/. Also, I don’t believe we need to worry about author.php as we are redirecting the links which would go to those author pages to the member’s BP profile.

    Avatar of Tammie
    Tammie
    Moderator

    @karmatosed

    @DJPaul ooo ah and other noises that would fit Guy Fawkes night.. that is so cool.

    Ok will cross that one off from list thank you. You’ve just dealt with the big one though there people are going to love that I totally agree @modemlooper was bang on money there.

    Avatar of @modemlooper
    @modemlooper
    Moderator

    @modemlooper

    These two need to be added

    sup { vertical-align:super }
    sub { vertical-align:sub }

    Avatar of @modemlooper
    @modemlooper
    Moderator

    @modemlooper

    Ok uploaded a new theme and got back some failures. This is going to be an issue now that people already have child themes in the repo.

    Results of Automated Theme Scanning: Fail

    REQUIRED: This theme doesn’t seem to support the standard avatar functions. Use get_avatar or wp_list_comments to add this support.
    REQUIRED: The theme doesn’t have comment pagination code in it. Use paginate_comments_links() or next_comments_link() and previous_comments_link() to add comment pagination.
    REQUIRED: The CSS is missing the .gallery-caption class.
    REQUIRED: Could not find wp_list_comments in the PHP files. The theme must use wp_list_comments() to display comments.
    REQUIRED: Could not find wp_footer in the PHP files. The footer of the page must have the wp_footer() call before the ending /body.
    REQUIRED: Could not find post_class in the PHP files. The post_class() function should be called from within the wrapper around a post.
    REQUIRED: Could not find content_width in the PHP files. The content_width variable does not appear to be set in the functions.php file.
    REQUIRED: Could not find comment_form in the PHP files. The theme must use comment_form() to display the comment reply form.
    REQUIRED: Could not find comment-reply in the PHP files. The theme must enqueue the comment-reply script on pages where there are comments displayed.
    REQUIRED: Could not find automatic-feed-links in the PHP files. You must have add_theme_support(‘automatic-feed-links’) called from the after_setup_theme action hook in the functions.php file.
    RECOMMENDED: The CSS is missing the License.
    RECOMMENDED: The CSS is missing the License URI.
    RECOMMENDED: The CSS is missing the .bypostauthor class.
    RECOMMENDED: No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.
    RECOMMENDED: No reference to post-thumbnails was found in the theme. If the theme has a thumbnail like functionality, it should be implemented with add_theme_support(‘post-thumbnails’) in the functions.php file.
    RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
    RECOMMENDED: No reference to add_custom_image_header() was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
    RECOMMENDED: No reference to add_custom_background() was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
    INFO: No reference to nav_menu’s was found in the theme. Note that if your theme has a menu bar, it is required to use the WordPress nav_menu functionality for it.
    Note: While the automated theme scan is based on the Theme Review Guidelines, it is not a complete review. A successful result from the scan does not guarantee that the theme will pass review. All submitted themes are reviewed manually before approval.

    Avatar of Tammie
    Tammie
    Moderator

    @karmatosed

    @modemlooper: Ok going through that list and ouch what a list..

    Implemented:
    RECOMMENDED: The CSS is missing the License.
    RECOMMENDED: The CSS is missing the License URI.
    INFO: No reference to nav_menu’s was found in the theme. Note that if your theme has a menu bar, it is required to use the WordPress nav_menu functionality for it.

    Planned (I have patches for these need to wrap up this weekend from discussion here and will do tickets):
    REQUIRED: The CSS is missing the .gallery-caption class.
    RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
    RECOMMENDED: No reference to add_custom_background() was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.

    Needs planning (I am wandering how many of these are a result of it being a child not default’s fault):
    REQUIRED: This theme doesn’t seem to support the standard avatar functions. Use get_avatar or wp_list_comments to add this support.
    REQUIRED: The theme doesn’t have comment pagination code in it. Use paginate_comments_links() or next_comments_link() and previous_comments_link() to add comment pagination.
    REQUIRED: Could not find wp_list_comments in the PHP files. The theme must use wp_list_comments() to display comments.
    REQUIRED: Could not find wp_footer in the PHP files. The footer of the page must have the wp_footer() call before the ending /body.
    REQUIRED: Could not find post_class in the PHP files. The post_class() function should be called from within the wrapper around a post.
    REQUIRED: Could not find content_width in the PHP files. The content_width variable does not appear to be set in the functions.php file.
    REQUIRED: Could not find comment_form in the PHP files. The theme must use comment_form() to display the comment reply form.
    REQUIRED: Could not find comment-reply in the PHP files. The theme must enqueue the comment-reply script on pages where there are comments displayed.
    REQUIRED: Could not find automatic-feed-links in the PHP files. You must have add_theme_support(‘automatic-feed-links’) called from the after_setup_theme action hook in the functions.php file.
    RECOMMENDED: No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.
    RECOMMENDED: No reference to post-thumbnails was found in the theme. If the theme has a thumbnail like functionality, it should be implemented with add_theme_support(‘post-thumbnails’) in the functions.php file.
    RECOMMENDED: No reference to add_custom_image_header() was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
    sup { vertical-align:super }
    sub { vertical-align:sub }

    Avatar of pcwriter
    pcwriter
    Participant

    @pcwriter

    I uploaded a new theme too this morning and got back the same list of errors. Fingers crossed…

    Avatar of @modemlooper
    @modemlooper
    Moderator

    @modemlooper

    @karmatosed I think some of it is because the auto scan is not taking into consideration it’s a BP child theme. I’ll post their review when I get it.

    Avatar of Hugo
    Hugo
    Moderator

    @hnla

    The results don’t make sense do they? in the ‘Required’ list it references wp_footer as missing but how could it be ? it only features in the one file doesn’t it? footer.php and in the bp-default files it’s present. Strikes me that the automated process is confused by some aspect of the BP structure but you would think it would be looking at stock files only?

    Avatar of @modemlooper
    @modemlooper
    Moderator

    @modemlooper

    Got the review back and it was rejected.

    Reviewers Comment:

    ”’Theme Check:”’
    * Deprecated: get_the_attachment_link found in the file attachment.php.
    Use wp_get_attachment_link() instead.
    * Line 15: ID,
    true, array(450, 800)); // Th

    * Deprecated: get_links_list found in the file links.php. Use
    wp_list_bookmarks() instead.
    * Line 19:

    * Deprecated: get_the_author_email found in the file search.php. Use
    get_the_author_meta(‘email’) instead.
    * Line 28:

    * Deprecated: delete_usermeta found in the file ajax.php. Use
    delete_user_meta() instead.
    * Line 95: delete_usermeta( $bp->loggedin_user->id,
    ‘bp_new_mention_count’

    * Required: Could not find post_class. See: post_class
    * <div id="post-” >

    * Required: .gallery-caption is missing.

    * Recommended: The CSS is missing the .bypostauthor class.
    * Recommended: bloginfo(‘url’) was found in the file searchform.php. Use
    echo home_url() instead.
    * Line 3: <form method="get" id="searchform" action="<?php
    bloginfo(‘url’); ?>/”>

    ”’Debogger:”’
    * OK

    ”’Test Data:”’
    * Required: ‘Clearing Floats’ page needs to be fixed.

    Avatar of @modemlooper
    @modemlooper
    Moderator

    @modemlooper

    I think these may be high priority due to it being the default theme that’s missing these requirements.

    Avatar of pcwriter
    pcwriter
    Participant

    @pcwriter

    Got a response from the WP review team. Not good news I’m afraid :-(
    There seems to be a bunch of deprecated tags still present in templates I copied over from bp-default (I just needed to modify some container IDs and stuff).
    Before I modify the templates with the suggested updates, I thought I’d post the reviewer’s comments here to see if anyone has any other suggestions.
    Here’s the review I got:

    Comment:

    ”’Theme Check:”’
    * Deprecated: get_the_attachment_link found in the file attachment.php.
    Use wp_get_attachment_link() instead.
    * Line 15: ID,
    true, array(450, 800)); // Th

    * Deprecated: get_links_list found in the file links.php. Use
    wp_list_bookmarks() instead.
    * Line 19:

    * Deprecated: get_the_author_email found in the file search.php. Use
    get_the_author_meta(‘email’) instead.
    * Line 28:

    * Deprecated: delete_usermeta found in the file ajax.php. Use
    delete_user_meta() instead.
    * Line 95: delete_usermeta( $bp->loggedin_user->id,
    ‘bp_new_mention_count’

    * Required: Could not find post_class. See: post_class
    * <div id="post-” >

    * Required: license.txt is missing you must include a licence.txt or put
    License: and Licence URI: in style.css header.
    * Required: .gallery-caption is missing.

    ”’Debogger:”’
    * OK

    ”’Test Data:”’
    * Required: ‘Clearing Floats’ page needs to be fixed.

    —-

    ”’Overall: Not-Approved”’

    Avatar of pcwriter
    pcwriter
    Participant

    @pcwriter

    @modemlooper

    Huh… you got the same review I did…
    Yup, it’s in default.

    Woah :)

    For BP 1.3 BP Default, you need to be checking against the trunk version. I appreciate you have submitted your own themes for review that are based from the current BP Default, or child themes thereof. Should anyone want to try the trunk dev version of BP Default, you can get that out of SVN here: http://svn.buddypress.org/trunk/bp-themes/bp-default/ I haven’t checked to see if that will work on a BP 1.2.x install ;)

    I quite like the idea of sending in BP-Default to the theme review team once we are much closer to release, but for now, I’ve been using Pross’ theme check plugin http://pross.org.uk/plugins/theme-check/ which apparently runs the same automated checks. I’ve just run it on trunk and results are here. Some of the recent theme commits I have done have been to sort out feedback from this tool.

    Avatar of @modemlooper
    @modemlooper
    Moderator

    @modemlooper

    Great! So 1.3 will fix these issues then.

    Avatar of Tammie
    Tammie
    Moderator

    @karmatosed

    Cool test. Seems 1.3 has sorted as already down to get patches in for rest I see on that list. Only thing I don’t is post thumbnails but we’re not using excerpts so hmmm why should we unless we just have to have the function?

    Like idea of submitting theme once fixed up then we can be sure anything based on it won’t get thrown out because of default.

    I’ve just added http://trac.buddypress.org/changeset/3452/ which adds comment classes to the comments’

  • elements; this is so that if/when we add CSS for .bypostauthor, the template will actually put that class into the html ;)

And I’ve taken an idea from @karmatosed — thanks Tammie — and put in CSS for nested comments. It looks a bit heavy at the moment, too much white space. But as @modemlooper is working on a new style for the comments to match the activity stream, I didn’t want to spend hours on this at the moment as things will probably change!

http://trac.buddypress.org/changeset/3453/

Avatar of @modemlooper
@modemlooper
Moderator

@modemlooper

@djpaul I’ve put up some starter drop downs css, will probably need some fine tuning and or changes http://trac.buddypress.org/ticket/2691

And I made a comment about the home tab going awol with new install

Avatar of Tammie
Tammie
Moderator

@karmatosed

Woot and so looking forward to @modemlooper‘s swish comments, that’s great @DJPaul

Avatar of @modemlooper
@modemlooper
Moderator

@modemlooper

Oh, and the functions:

Recommended: No reference to add_custom_background() was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
Recommended: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
Recommended: No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.
Recommended: No reference to post-thumbnails was found in the theme. If the theme has a thumbnail like functionality, it should be implemented with add_theme_support(‘post-thumbnails’) in the functions.php file.

Background should be used in default IMHO. Thumbnails should be included for child themes to tap. Editor style should be in a child theme.

Avatar of Tammie
Tammie
Moderator

@karmatosed

Just got a bit ticket happy…

Custom background: http://trac.buddypress.org/ticket/2749 – I did remove the background image as it’s so subtle and we’re adding this feature thought ok if only to have as debate point / starting point of getting function in. We can always adjust if problems?

.bypostauthor: http://trac.buddypress.org/ticket/2748 – Minimal styling as figured @modemlooper your changes may want to impact on that.

Right, I think I’ve looked at and replied to both of your comments on trac. *tired*

@modemlooper About the home tab. You are probably right, I took out “home” when adding support in for the WP 3.0 menus as it would have required a re-write anyway.

Viewing 25 replies - 1 through 25 (of 38 total)

The forum ‘BP-Default’ is closed to new topics and replies.