Skip to:
Content
Pages
Categories
Search
Top
Bottom

Regarding 2.7.6

  • Avatar of chestnut_jp
    chestnut_jp
    Member

    @chestnut_jp

    Note: this is moved from http://buddypress.org/community/groups/buddypress-group-email-subscription/forum/topic/regarding-2-7-5/

    @dwenaus
    Thanks for releasing the new version.
    Though I am still searching the reason, because sometimes “cache” cause something wrong, updated to the new version doesn’t show Japanese any more.

    Looking at your-made pot file, some words seems to be deleted from my original pot, ex: “yes”, “no”, or “Yes”, “No”, all of which you mentioned, were already in my pot file, but they are disappeared.

    Some words were using “buddypress” because they were not translated, for unknown reason or maybe due to the definition of “global $bp”, or they are existing buddypress.

    As for “date_default_timezone_set”, it might affect other plugin or BP settings.
    Setting the “date_default_timezone_set(‘America/New_York’);” in the “bp-activity-subscription-digest.php” may not affect, while setting it to “date_default_timezone_set(‘Asia/Tokyo’);” may result in that the time displayed in activity stream shows “sometime ago” instead of “0 second ago” or “10 minutes ago” unless that activity passes a long time, due to the time zone difference from UTC.

    This happens because, in bp-core.php file, the time displayed in the activity stream was decided by “$since = $newer_date – $older_date;”, and the older_date goes bigger than newer_date accoring to the setting of “date_default_timezone_set” in this plugin.

    This is not only this plugin but some other plugins appear to have the same problem.

    Because I first did not notice the reason why the time displayed “sometime ago”, which is not this plugin’s fault but others that are already disabled, I reported it as buddypress bug. Nevertheless, the reason is not buddypress but plugins.

    I will send you my email address via email.

    Please once again review my new customized package available at:
    http://staff.blog.bng.net/downloads/buddypress-group-email-subscription-2.7.5.1.zip

    This package is not included cron bug fixed, though.

    I will continue to verify your new version.

    P.S.:
    Your made pot file has some error due to rn, which should be n only.
    So, please continut using my pot file.

    I will add or change after comparing with your pot file.

Viewing 7 replies - 1 through 7 (of 7 total)
  • Avatar of chestnut_jp
    chestnut_jp
    Member

    @chestnut_jp

    I made 2.7.5.2 based on the previous version of 2.7.5.
    I am now stop upgrading to 2.7.6, because no word is translated in 2.7.6 for unknown reason.

    2.7.5.2 is available at:
    http://staff.blog.bng.net/downloads/buddypress-group-email-subscription-2.7.5.2.zip

    My 2.7.5.2 was made by fixing my 2.7.5.1, so that digest sending time, which can be selected by Administrator, is now set to the proper local time.

    When you use my package, you must open “bp-activity-subscription.php” first, and change “Asia/Tokyo” according to your location. If you do not know how to write, do not worry. You can refer to PHP manual following to the lik written there.

    Search “2010/11″ through all php files, and you will find what is the difference from original 2.7.5.

    The reason why I changed them is:

    1) setting date_default_timezone_set in bp-activity-subscription-digest.php appears to have an influence on BP setting.

    =>

    I changed the localtime zone setting to bp-activity-subscription.php and call it as it is needed in every function.

    2) I whould like to confirm whether the digest delivery time is set properly.

    =>

    I added “Schedules” in preview screen, which can be invoked by “sum=1″.

    3) The way of load_plugin_texdomain is changed, because in the original way, some words were not translated which I had no choice but to use “buddypress” language file.

    =>

    Accordingly, all words are chnged to use the plugin’s language file.
    Language files should be named as bp-ass-$locale.po and bp-ass-$locale.mo, where $locale means your locale.

    Japanese Translation files are therefore renamed to bp-as-ja.po and bp-as-ja.mo. So is the pot file stored in languages directory.

    Because I changed the way of setting the localtime zone, most of the changes I made is based on it.

    Nevertheless, the new 2.7.6 and my 2.7.5.2 seem to have the same problem that Daily Digest is properly delivered but Weekly Digest is not. It is not shown even in the preview screen.

    In addition, the daily digest is not sent until someone accesses to the site. For this reason, I made crontab in my server like this:
    30 6,7 * * * /path-to-lynx -dump URL-OF-SITE> /dev/null 2>&1

    The double set of “hour” is for Daily and Weekly digest, as Weekly digest is supposed to be delivered one hour later than Daily.

    If your site’s traffic is heavy, you do not need to set this cron, because someone will access to your site at any time.

    Anyway, I am still searching the reason why digest is not delivered at the time. I am afraid if it happens only under my environments.

    Any comments will be appreciated.

    @dwenaus
    I hope you have got my email address.

    Avatar of chestnut_jp
    chestnut_jp
    Member

    @chestnut_jp

    @dwenaus
    Regarding cron, digest mail delivery, I noticed that it might be due to my environments.
    I have installed wp-dbmanager plugin, which worked properly until late October. Since then, however, it never create db backups automatically.

    The dbmanager plugin also uses cron, and now that it has stopped automatically create backup files since early November, the problem may be due to conflicts or something like that with other plugins.

    I am using WP3.0.1 with multi-site features, and my buddypress site is the primary domain. On the same network, I have many blog sites as subdomains.
    One of them is staff.blog.bng.net and when I enable dbmanager plugin from the site, the plugin works and creates backup files automatically.

    Thus, I must conclude cron problem might be due to environments of mine.
    Any idea? I still have no choice but to use crontab…

    Avatar of chestnut_jp
    chestnut_jp
    Member

    @chestnut_jp

    @dwenaus
    Now I am making a brand new multisite in order to see if cron works and in order to verify 2.7.6.

    It will take some time but I will report when I find something.

    Avatar of Dwenaus
    Dwenaus
    Participant

    @dwenaus

    your pot file had japanese characters in it. that’s why i didn’t use it. I will look into making a better POT. I have no idea about the time zone problems. can you shed light on it? thanks again.

    Avatar of chestnut_jp
    chestnut_jp
    Member

    @chestnut_jp

    @dwenaus
    Yes, you are right.
    I noticed it (pot includes Japanese) when I created 2.7.5.2, and I already removed Japanese characters from the pot file in the 2.7.5.2 package.

    I have been very glad to cooperate with you on the plugin, so tell me when you find something wrong.

    I am still preparing the brand new buddypress site. I hope I will soon reviewing 2.7.6.

    Avatar of chestnut_jp
    chestnut_jp
    Member

    @chestnut_jp

    @dwenaus

    I have just made a brand new buddypress site and installed 2.7.6.
    When activating the plugin, no Japanese are shown.
    The “languages” directory surely has “buddypress-group-email-subscription-ja.mo”.

    I just installed the plugin. Thus, there seems to be a bug for translation.
    Have you changed something about internationalization of the plugin?

    For above reason, I will postpone verifing 2.7.6 until translation problem is resolved.
    Of course I will investigate what is wrong.
    At the same time, I now would like to verify my 2.7.5.2 to see if cron features work as the plugin wp-dbmanager’s cron featreus do in my new buddypress site.

    Avatar of Dwenaus
    Dwenaus
    Participant

    @dwenaus

Viewing 7 replies - 1 through 7 (of 7 total)

You must be logged in to reply to this topic.