Skip to:
Content
Pages
Categories
Search
Top
Bottom

Regarding 2.7.8

  • Avatar of chestnut_jp
    chestnut_jp
    Member

    @chestnut_jp

    2 years, 5 months ago

    @dwenaus

    I have almost finished the addition of the function to switch to the user’s local timezone. It will take some more time for me to announce, as I need more time for verification.

    By the way, I have faced two problems, one is that weekly digest does not appear to be sent, but this needs to be tested more until I have the confidence that it is a problem.

    The other that I want help now is that “function ass_group_notification_activity( $content )” in bp-activity-subscription-functions.php does not accept any translation.

    When a user selects “All Email”, every notification email is sent to him/her.

    Email notification for new forum topics (unction ass_group_notification_new_forum_topic), for forum replies (function ass_group_notification_forum_reply), and email to all group members (function ass_admin_notice) all work properly as they are sent in Japanese.

    However, only email notifications of update (function ass_group_notification_activity) is sent in English.

    I know the phrase is changed from “To view or reply, log in and follow the link below” to “To view or reply, log in and go to”. This is not the reason.

    Because I did not test 2.7.6 and 2.7.7 enough as I had been busy, I cannot compare 2.7.8 with these two versions, but with 2.7.5.

    In 2.7.5, all email notifications are, yes, translated. When I downgraded to 2.7.5, it still works naturally.

    Seeing bp-activity-subscription-functions.php of 2.7.5 and 2.7.7, there seems to be no big difference that might have an influence on email translation.

    Thus, I think this problem may lay in the other php files, but I have not yet founded it.

    Any help?

Viewing 5 replies - 1 through 5 (of 5 total)
  • Avatar of chestnut_jp
    chestnut_jp
    Member

    @chestnut_jp

    2 years, 5 months ago

    I am still investigating the way to translate for “function ass_group_notification_activity” which is the only that is not translated.

    Since it is inconvenient, I now wrote Japanese directly into the script so that email notification is translate.

    When I specify the language file to buddypress, switching from bp-ass, the mail is translated except that part of ass_subscribe_translate( $group_status ). Anyway, other emails are correctly translated, so I will continue investigation until I find the answer.

    Does anyone face the same problem?

    Avatar of chestnut_jp
    chestnut_jp
    Member

    @chestnut_jp

    2 years, 5 months ago

    I just fixed it.

    In bp-activity-subscription.php,

    [ Original ]
    `
    function activitysub_textdomain() {
    load_plugin_textdomain( ‘bp-ass’, false, dirname(plugin_basename(__FILE__ ) ) . ‘/languages/’ );
    }
    add_action( ‘init’, ‘activitysub_textdomain’ );
    `
    =>
    [ Changed ]
    `
    //function activitysub_textdomain() {
    load_plugin_textdomain( ‘bp-ass’, false, dirname(plugin_basename(__FILE__ ) ) . ‘/languages/’ );
    //}
    //add_action( ‘init’, ‘activitysub_textdomain’ );
    `

    I am not sure the reason why, but the above change makes it.
    I have made translations for plugins, and I always use:
    `
    load_plugin_textdomain(‘bp-ass’, PLUGINDIR.’/’.dirname(plugin_basename(__FILE__)).’/languages’);
    `
    `load_plugin_textdomain(‘bp-ass’, false, dirname(plugin_basename(__FILE__ )).’/languages/’);` is also valid.

    Now I am about to verify how “weekly digest” works, because it does not seem to work.

    Avatar of Dwenaus
    Dwenaus
    Participant

    @dwenaus

    2 years, 5 months ago

    great!

    Avatar of chestnut_jp
    chestnut_jp
    Member

    @chestnut_jp

    2 years, 5 months ago

    @dwenaus

    I have been misunderstood how “weekly summary” works.
    It includes only topics in the forum. I thought it includes all, such as an update.

    Now that weekly summary appears to work, I will incorporate some alternations regarding timezone in the latest version, which I have just upgraded the plugin to.

    And then, after testing awhile, I will announce about the corrections.

    Avatar of chestnut_jp
    chestnut_jp
    Member

    @chestnut_jp

    2 years, 5 months ago

    Here is another solution.

    Though I do not know how important to add_action for load_plugin_textdomain, because just write load_plugin_textdomain() has power over the whole plugin, I decided not to delete add_action as described above.

    Since translation is not made only in “function ass_group_notification_activity( $content )”, I just add “activitysub_textdomain();” just before the line of “sprintf”, which is successful.

Viewing 5 replies - 1 through 5 (of 5 total)

You must be logged in to reply to this topic.

Topic Info