Skip to:
Content
Pages
Categories
Search
Top
Bottom

Using filter options dropdown on activity page causes a post form to display under every entry

  • Avatar of Henry
    Henry
    Member

    @thirstcard

    http://static.inky.ws/image/2069/image.jpg

    My activity feed loads like expected but when I use the filter options to change the content of the activity feed to “updated” items only, I get the post form display under each entry in the feed (see link above for a screenshot).

    Does anyone know why the post form (circled red) is displayed under every entry? It only happens when I use the filter options (circled blue).

    Hope someone can help

Viewing 6 replies - 1 through 6 (of 6 total)
  • Avatar of Hugo
    Hugo
    Moderator

    @hnla

    Been having the same issue – in my case working up a custom set of files and the most likely reason is that I’ve upset the markup structure/class tokens . Despite spending a little time recently going through the default bp global.js file to reduce dependency on markup (this won’t be of benefit until 1.6) you do have to be very careful to respect the markup structure in activity stream and it’s various classes as the necessary JS depends and expects certain elements to exist.

    So check and compare your entry.php template in activity so see if you have left out any classes or changes markup.

    Avatar of Henry
    Henry
    Member

    @thirstcard

    @Hugo

    We seem to be in the same position and I agree as a developer you really do need to respect the BuddyPress classes and IDs in order for the JS to work properly. I found that out the hard way :}

    Anyway, my solution to my question was a CSS one. This works nicely for me.

    div.activity-comments form.ac-form {
    display: none;
    }

    Avatar of Hugo
    Hugo
    Moderator

    @hnla

    hmm yes but that doesn’t correct the issue and you shouldn’t need to do that really, the point is that the file global.js handles this and if it isn’t one needs to look to where it’s been broken. We’ve endeavoured to reduce the need to keep the structure intact in global.js for 1.6 which should make life easier for developers.

    I’m concerned with this though as I use that revised global.js file as I’m deving on 1.6 and shouldn’t be seeing this issue so it needs tracking down.

    Avatar of Henry
    Henry
    Member

    @thirstcard

    +1 to making global.js less dependent on theme markup. It would be nice to be able to run riot on a new theme and not have to worry about removing any of the default markup.

    Also, as BuddyPress is developed further, it would be nice to see more of the language removed from the core. At the moment I have to create a new language file with isn’t ideal.

    All this said, BuddyPress is a fantastic product. Very impressed how far it has come in such a short time.

    Avatar of Hugo
    Hugo
    Moderator

    @hnla

    > +1 to making global.js less dependent on theme markup. It would be nice to be able to run riot on a > new theme and not have to worry about removing any of the default markup.

    Download global.js from the repo trunk it should run on 1.5 and 1.6 will drop pretty soon, then you can experiment with what you can change, classes and ID’s are sacrosanct but element selectors have been removed and jQuery elements removed which traverse the dom based on structure rather than tokens.

    Avatar of Henry
    Henry
    Member

    @thirstcard

    Thanks Hugo! I will give it a go

Viewing 6 replies - 1 through 6 (of 6 total)

You must be logged in to reply to this topic.