Skip to:
Content
Pages
Categories
Search
Top
Bottom

Version 1.7 Beta

Viewing 19 replies - 51 through 69 (of 69 total)
  • Avatar of thekmen
    thekmen
    Participant

    @thekmen

    @pcwriter @hnla do you know of any plugins built using the skeleton component that do work on MU?
    could give us a good starting point to figure this out…

    Avatar of Hugo
    Hugo
    Moderator

    @hnla

    Avatar of pcwriter
    pcwriter
    Participant

    @pcwriter

    @hnla

    Thanks! That works just fine!

    Avatar of Hugo
    Hugo
    Moderator

    @hnla

    guys I’m confused 1.6 was a different beast altogether wasn’t it or did I miss a revision? Originally the plugin wasn’t built with the skeleton component or if it was it was a far more simple implementation without the class constructor files, screens etc. The Skel comp must work with WPMU as the whole nature of BP was designed in the first instance to work with WPMU.

    It was only the attempt to bring in the profile points page and sitewide points screens that have caused the issues. The db prefix issue I have highlighted and there is a fix to be had for this whole general issue surrounding DB prefixes for both plugins. the only thing I need now to see working are upgrades from WPMU to WP 3.0 to see how the upgrade or rather how WP 3.0 handles WPMU migration then I’ll be able to show a definitive method of establishing correct DB prefixes regardless of type of install.

    @thekmen can you briefly describe how the page pagination is meant to work? I see no means of determining how many records per page at present and it’s only the pagination links that are missing.

    Avatar of thekmen
    thekmen
    Participant

    @thekmen

    @hnla I am completely confused too. I can’t figure out if you have it working or not with your changes.
    Does CubePoints work for you on MU?
    Did the 1.6 versions of this plugin work for you on MU?

    Yes, the 1.7 branch was a complete rewrite using the skeleton component.
    The records per page are set on installation as 20, in a future version we will be moving this to an admin option.

    Avatar of Hugo
    Hugo
    Moderator

    @hnla

    @pcwriter at present the cubepoint family can’t work over user blogs – the original cubepoints parent plugin was only written for single WP xberserker then extended the plugin so that it was BP aware and would work with general components like group updates, profile updates etc. I should think it isn’t vastly difficult to get it working across user blogs just a fair bit of coding to do, I would hope that when things are fully settled and working for BP then that aspect could be tackled?

    Avatar of Hugo
    Hugo
    Moderator

    @hnla

    @thekmen Yes and Yes :)

    I had it working for 1.6 point release? .3? but that was more simply sorting out the parent cubepoint.php file which was really where the original issues were.

    1.7 wouldn’t fetch results to display for the two screens in user accounts/profiles, this was the issue with message “no points to display” when in fact there were. This was due to not finding the correct table prefix cured by changing from ‘base_prefix’ to ‘prefix’

    My concern now is the division by zero why is that still an issue? what is that block dealing with paginate links? I have no display no means of setting rows to display and for paginate links to kick in on.

    Avatar of Hugo
    Hugo
    Moderator

    @hnla

    @thekmen

    The records per page are set on installation as 20, in a future version we will be moving this to an admin option.

    Ok I have some 34 odd records displayed? should not they be paginating automagically then?

    Avatar of thekmen
    thekmen
    Participant

    @thekmen

    @hnla, yes, if you have more than 20 records displayed on the users points table, they should paginate.
    I’d suggest you go back to using 1.6.3 for now until we have the 1.7 branch tested on WP3.

    Avatar of Hugo
    Hugo
    Moderator

    @hnla

    @thekmen this is simply trying to track down the issues with 1.7 I’m not running 1.7 live! and my references to WP 3.0 are simply to establish what WP has changed or not, with both plugins and WP in general regardless of type this DB prefix issue should simply not be an issue there should be an established method of checking the install type and always prepending necessary table prefix, it’s daft that it seems to cause this much trouble.

    Somewhere I suspect perhaps in $defaults = bp_cubepoint_default_query_args(); it’s not picking up the correct table or some detail

    Avatar of pcwriter
    pcwriter
    Participant

    @pcwriter

    @hnla

    Thanks for the update re user blogs :-)

    Avatar of Hugo
    Hugo
    Moderator

    @hnla

    @xberserker @thekmen

    The reason there has been much of this confusion is in some senses that the chaps who wrote cubepoints needlessyy? coded themselves into a corner, when coding in various disciplines we try to ‘Anticipate’ you try to account for possible eventualities and keep code can adjust itself to the right conditions.

    The huge flaw I see in the logic of the original plugin is that in creating the CP tables they were created with the database prefix prepended this meant that they got trapped within the WPMU prefix, when it looks as though they simply need the ‘base_prefix ‘, the flaw originates I guess due to not considering that the plugin might be run on WPMU and why would it? it was written for single WP blog and doesn’t work across MU user blogs, yet… as we can see it has happened.

    It’s a case that things were probably too rigidly coded an assumption was made rightly or wrongly, ‘prefix’ would normally work happily, but equally NOT prepending ‘prefix’ would also have worked but in both circumstances.

    Ideally the cubepoint tables should not find themselves prepended with ‘wp_1_’ on an MU install but then perhaps they do otherwise they won’t be able to ‘see’ the correct primary blog?

    Guys it might be worth just passing comment on to the cubepoint developers for consideration I think that there is a better approach to setting up these tables now that BP-integration and WP MS are in the equation.

    Avatar of thekmen
    thekmen
    Participant

    @thekmen

    @hnla, I can now reproduce this problem again.
    Just did a fresh install of WP3.0 beta 2 and it works in single blog mode, however when I enable multisite the issue pops up.

    I’ll see what I can do.

    Avatar of Hugo
    Hugo
    Moderator

    @hnla

    to what? :) If you can identify the issue that is preventing the pagination from kicking in that will be great, if you need the page views/screens correctly displaying data simply effect the change to the DB prefix I described in earlier posts in this thread.

    The ultimate result desired is a correct global WP approach to checking what type of install is running , something that one would have somewhat expected existed?

    Avatar of thekmen
    thekmen
    Participant

    @thekmen

    @hnla, we should all be running one version of WP soon enough anyway so I’m going to concentrate on getting it working with that.
    I have a functioning version working on WP 3 beta 2, with multi site enabled & no need for CubePoints.
    I need to fix up a few bugs but if you want to give it a try I can send it over in a few days.

    as for a fix on the pagination issue, can you replace the line
    $this->pag_per_page = $per_page;
    with
    $this->pag_per_page = '20';
    on line 29 of bb-cubepoint-templatetags.php

    and let me know how it goes.

    Avatar of Hugo
    Hugo
    Moderator

    @hnla

    Hmm had thought I’d tried that – yes it does kick in the pagination links! but the actual pagination is not working or rather the query result is not divided on that number string? I can link to page 2 but it simply runs all the results again.

    There is a danger in being too narrow in ones testing, although things will start to settle down with the help of the move to WP 3.0 in general terms, there may well be quite a few people still running WPMU for a while, experience tends to make one cautious of hurtling into upgrades and experience with WP from the very early days far preceding V 2.0 is going to mean I take things very slowly in any major upgrade of this nature, in fact the posts are building up on issues with BP 1.2.4 to the extent that I will hold off upgrading that on my test installs. However in theory CPBP should run on WP 3.0 and by default run on WPMU, as I said earlier I would like to see an upgrade run as the MS notes instruct that no set up is required if already MS enabled from WPMU so I’m guessing that the missing prefix ‘wp_1_’ in 3.0 when MS enabled is reserved for upgrades.

    Good to hear you have actually forked cubepoints as such, it makes sense I think to have the one plugin, yes if you would like to send me the work when it’s a reasonable stable condition I’ll run it on WPMU and WP 3.0 and put it through it’s paces. We’ll need to find a means of exchanging email or something, this forum really badly needs some finishing off and common elements such as PM brought back.

    Avatar of Tosh
    Tosh
    Participant

    @xberserker

    @hnla @thekmen Glad to see some progress being made.

    Was thinking some more about dropping cubepoints support and not sure about it yet. Because I use the CubePoints API to integrate manually into a few other plugins for earning points. Like Simple:Press forum, creating calendar items. Plus the other features that CubePoints has like donate, ranks, to be able to display all the users on one page, update points manually or take away when needed, admin logging page to see a whole overview, Prefix & Suffix for display of points, widgets. daily points for logging in, being able to give points for blog posts and comments, maybe for another site I’ll use the PayPal module, etc. I don’t want to lose all that functionality. I understand the concern with WPMU and WP 3.0 though.

    Avatar of Hugo
    Hugo
    Moderator

    @hnla

    @xberserker Well WPMU & WP 3.0 should resolve it self and oughtn’t really to present any issues now that the generic issue of DB prefixing confusion is understood. If CPBP continues to roll with CP as a parent then it will simply be a matter of keeping a CP version with any necessary DB fixes in place for those that do not want to rush into an upgrade to WP 3.0, the CP guys have corrected the image path issue I see so that is one less fix to maintain.

    Avatar of josh101
    josh101
    Participant

    @josh101

    So we have to wait tell wp3.0 then. Dang guys you made the plugin to powerful for 2.9.2 its a good thing 3.0 is coming out just dont kill that one to it will be a long time before 3.1 comes.

Viewing 19 replies - 51 through 69 (of 69 total)

You must be logged in to reply to this topic.