Nowhere in your function do you tell BuddyPress to change the user’s role to subscriber, therefore the problem must be coming from elsewhere. Try disabling all plugins and activating the Twenty Fifteen theme to see if the issues resolves.