Skip to:
Content
Pages
Categories
Search
Top
Bottom

BP 1.5 required fields become prefilled with the first option on reg page – Watch Screencast

  • Avatar of rossagrant
    rossagrant
    Participant

    @rossagrant

    Screencast now at http://screenr.com/Fjrs

    Hi all!

    This didn’t used to happen in BP 1.2.x. but when you have required profile fields in BP 1.5, the fields get prefilled with the first option in the list when you visit the registration page. They are already filled in with those first options as opposed to how it used to be with a


    line above all options in the dropdown.

    This isn’t a big problem in itself, but I use a ‘search profile fields’ plugin which needs to be able to search by say just one profile field.

    The way the profile fields now behave (prefilled) means that ALL of the available fields are always filled with the first option. I need there to be the line above the options which was displayed as


    back.

    Therefore people can just select one option from one prodile fields to search, leaving the rest displaying


    .

    I hope this is clear, it’s quite hard to explain.

    I’m sure this will cause others problems though. Users will no longer miss required fields but it would be very easy for them to overlook the prefilled option and end up with wrong info on their profiles.

Viewing 4 replies - 1 through 4 (of 4 total)
  • Avatar of rossagrant
    rossagrant
    Participant

    @rossagrant

    I’ve done a screencast to illustrate this point a little better.

    Does anyone agree that the required profile field behaviour should revert back to how it behaved pre BP 1.5?

    Would love to hear opinions as this may affect other plugins for people.

    http://screenr.com/Fjrs

    Avatar of Boone Gorges
    Boone Gorges
    Keymaster

    @boonebgorges

    Yes, it’s a change: http://buddypress.trac.wordpress.org/ticket/3378#comment:2

    The plugin you’re using is using for search is using core functions to render the dropdowns. That’s great, of course. But, in all the ways that the dropdowns are used in BP core, it does *not* make sense to have a null option for required dropdowns. So, while it’s inconvenient and I wish it had been raised at an earlier point, I think it’s incumbent on the plugin to create the fields in the way necessary for the plugin’s functionality to work right.

    Alternatively, I would be happy to see a patch for BP that allows bp_get_the_profile_field_options() to take an argument along the lines of show_null_value_for_required (maybe not that wordy, but you get the idea). That way, we could default to false (1.5 behavior) but allow the 1.2.x behavior optionally, at http://buddypress.trac.wordpress.org/browser/trunk/bp-xprofile/bp-xprofile-template.php?annotate=blame&rev=5230#L431. It would be an easy patch to write; I encourage you to do it yourself, or at least to open a ticket for it.

    Avatar of rossagrant
    rossagrant
    Participant

    @rossagrant

    @boonebgorges Nice one Boone.

    I’m not a developer, but I’ll gladly donate to have it put together.

    I’ll open a ticket and thanks again.

    Sorry to put you through all of the screencasts, but I find it so much easier than writing it all down! :)

    Avatar of Boone Gorges
    Boone Gorges
    Keymaster

    @boonebgorges

    No problem – happy to get accurate issue reports, however they may come in :)

Viewing 4 replies - 1 through 4 (of 4 total)

You must be logged in to reply to this topic.