Skip to:
Content
Pages
Categories
Search
Top
Bottom

Buddypress bug still happening 1 year after mentioning it here,effects all users


  • mcpeanut
    Participant

    @mcpeanut

    8 years, 11 months ago

    Sorry I didn’t have enough space to be descriptive in the title…it meant to read, effects all users of Buddypress because it happens on every install.

    Ok guys let me explain, about 1 year and 2 months ago I made a post about strange behaviour with the Buddypress comments not collapsing and displaying the SHOW ALL link if a post has more than 5 comments when you have clicked on the LOAD MORE tab at the bottom of the page.

    I have tested this now on 5 SERVERS! with every version of Buddypress for over 2 years with same result. I cannot believe people are not noticing this when testing their builds 🙂

    Please bare with me as its such a simple thing to spot once you know what you are looking for yet so hard to explain to you guys so you understand what I am going on about. So let me do it in steps so that you understand what I have been going on about all this time.

    Ok, we all know that when someone posts an activity and people comment on it that Buddypress by default only shows 5 comments then gives you a link to click to show all the other comments. (lets just say 15 comments has been added to an activity as an example) By default Buddypress will show the latest 5 comments then add a link saying ‘SHOW ALL 15 COMMENTS’ that a user can click to see the remaining 10 comments that are out of view, this is designed to conserve space in the sitewide activity, YES? you with me so far?

    NOW THE PROBLEM! Yes this works great and works for everyone UNTIL you scroll down the sitewide activity and click on the the load more tab. any activitys that have received more than 5 comments will no longer show the SHOW ALL 15 COMMENTS (15 used as an example again). Instead all the comments will be visible and showing instead of being hidden from view taking up loads of the activity stream space which kind of defeats the purpose of having this feature in the first place, people tend to scroll down and click the load more tab if they have not logged in for a while to see previous updates they may of missed.

    Another example: if someone is browsing down the sitewide activity using the load more button to see what they have missed and one of the activitys has received lets say 200 comments on a busy website then all the 200 comments will be visible instead of having the default 5 comments visible with a show all 200 comments link. Now can you see the problem? 🙂 and can someone please take note of this and check it out, it is such an easy thing to see and recreate and i am totally still baffled as to why other are failing to spot this.

    Easiest way to see it first hand is install any theme a fresh Buddypress install with only Buddypress active, go to sitewide activity and post loads of updates until they activate the load more button, then post one last update and comment on it over 10 times, you will see after reloading the page it has 5 comments visible and a link saying show all 10 comments which is correct.

    Now scroll down to the bottom of the sitewide activity and click the load more tab and pick the bottom activity you can see and post 10 test comments on it, then reload the page so it takes you back to the top of sitewide activity, now scroll back down to the bottom of sitewide activity and click the load more button again and take note of the activity you just added 10 comments too, guess what? they are all visible with no link to show all 10 comments because they are already shown.

    Ok, did that explain everything? phew! 🙂

Viewing 7 replies - 1 through 7 (of 7 total)

  • Ben Hansen
    Participant

    @ubernaut

    8 years, 11 months ago

    is there a trac ticket for this issue?


    mcpeanut
    Participant

    @mcpeanut

    8 years, 11 months ago

    Not that I am aware, this is not a recent thing @ubernaut, it is something I have mentioned a few times over the years, this has been happening since I started using Buddypress well over 2 years ago (probs 3 years), The reason I haven’t added a trac ticket is because of how descriptive I have to be when explaining the issue, it may be better that a few mods confirm it and add the ticket to make it easier to explain, I felt like I had to write a story about it above just to explain the issue correctly and make it understandable.

    This is why I keep mentioning feeling baffled as to why after a couple of years no-one else has spotted this??? Maybe its because most websites that use Buddypress don’t often receive more than 5 comments on an activity huh? who knows.


    Ben Hansen
    Participant

    @ubernaut

    8 years, 11 months ago

    i hear ya, it does sound rather convoluted but i do know the best way to get the dev’s attention is in trac. in my experience they are a pretty understanding lot. 🙂


    mcpeanut
    Participant

    @mcpeanut

    8 years, 11 months ago

    @ubernaut , Yer maybe your right about adding it to trac directly for attention I think I will wait until morning as its so late and I need sleep, maybe in the mean-time @henrywright could take another read of this as he commented on my original thread over a year ago, but I gave up explaining as no-one was quite seeing what i was getting at back then.

    Ok, fair enough no-one is noticing the problem that this could cause yet because it seems most Buddypress sites just are not active enough to realise this yet for themselves, but I can guarentee that if a few Buddypress websites started to get really popular and used by masses of people this would become a real big issue when it comes to popular activity posts because these posts would just scroll on forever in the sitewide activity.


    Henry Wright
    Moderator

    @henrywright

    8 years, 11 months ago

    @mcpeanut I’m unable to test right now but can you give this a try on Twenty Fifteen or Twenty Sixteen and if the problem persists, would you mind opening a Trac ticket for this? Copying and pasting some of what you’ve wrote already should be fine.

    The core devs might not see this forum topic.

    Ref: https://buddypress.trac.wordpress.org/


    mcpeanut
    Participant

    @mcpeanut

    8 years, 11 months ago

    @henrywright yes I will add it to trac later today when I have some spare time, there is no need for me to test on the default themes again as it will be the 100th time or more I have tested this over and over and over and over and yes you guessed it over again! for the past 2 years 🙂

    It happens on every single theme that you use Buddypress on, it has never worked as I think it was intended to, its probably been completely overlooked and always has. If you test every version back to Buddypress 1.7 you will find the same issue in every single version of Buddypress up until the most recent, I havent gone further back than 1.7 so if it ever did work it was pre 1.7.


    mcpeanut
    Participant

    @mcpeanut

    8 years, 11 months ago

    The reason I havent really mentioned it again for over a year is because I have been so damn busy and I have implemented my own sort of work around by adding an expand/collapse comments button next to the favourite and delete button that lets users close and open all comments at will when scrolling further down sitewide activity, if a post has too many comments they don’t want to read because of this issue they can just click collapse and all the comments will collapse until they re-click it, it was the only solution I could think of and works well, but would be much better if this got fixed as I could then use both.

Viewing 7 replies - 1 through 7 (of 7 total)
  • The topic ‘Buddypress bug still happening 1 year after mentioning it here,effects all users’ is closed to new replies.

Topic Info

Skip to toolbar