Topic: Unclosed PHP tag In Template File – messages.php · BuddyPress.org

Skip to:: Content; Pages; Categories; Search; Top; Bottom

Unclosed PHP tag In Template File – messages.php

Hastig
Participant

@hastig

8 years, 10 months ago

WP 4.4 / BP 2.4.3 / Custom Theme

The template file for messages.php ends at endswitch; with no closing php tag. Is this by design?

/wp-content/plugins/buddypress/bp-templates/bp-legacy/buddypress/members/single/messages.php

I was unable to include the WP get_footer tag without first closing it in my custom version.

If by design, will my closing it affect any functionality that I cannot foresee?

Viewing 2 replies - 1 through 2 (of 2 total)

Hugo Ashmore
Participant

@hnla

8 years, 10 months ago

It’s by design:
https://buddypress.trac.wordpress.org/browser/trunk/src/bp-templates/bp-legacy/buddypress/members/single/messages.php

Closing php tags shouldn’t be necessary, WP instructs not to close out files in this way. If you’re having issues they must lie with the custom templates?

Hastig
Participant

@hastig

8 years, 10 months ago

1. Not neccesary but won’t hurt anything if I do? Seems that way, so far anyway.

I feel I’m missing something fundamental with Buddypress’s structure, still trying to get a handle on it.

2. Is buddypress/members/single/messages.php a template page or normally a file that’s included in a template page?

What I mean is, for example, messages-loop.php is a not a page but a file that is called by messages.php

2b. So is messages.php normally called by another template higher up and the php in question is closed in that?

Viewing 2 replies - 1 through 2 (of 2 total)

The topic ‘Unclosed PHP tag In Template File – messages.php’ is closed to new replies.