Skip to:
Content
Pages
Categories
Search
Top
Bottom

BP 2.5 RC1: php syntax error?


  • dave-turnbull
    Participant

    @dave-turnbull

    When pushing the 2.5.0 RC1 to WPEngine (via SourceTree), I receive this error:

    remote: PHP Fatal error:  Call-time pass-by-reference has been removed in - on line 179        
    remote:   - [1;31mwarning:[00m syntax Error Found in wp-content/plugins/buddypress/bp-forums/bbpress/bb-includes/backpress/functions.wp-taxonomy.php ...

    Line 179 of functions.wp-taxonomy.php reads:
    return $wp_taxonomy_object->_pad_term_counts(&$terms, $taxonomy);

    Is that an extra ‘&’ in there? I’m no developer! Ha! But I can’t push this plugin unless I figure this out.

    Cheers,
    Dave

Viewing 5 replies - 1 through 5 (of 5 total)

  • r-a-y
    Keymaster

    @r-a-y

    See:
    https://buddypress.trac.wordpress.org/ticket/6633

    Particularly:
    https://buddypress.trac.wordpress.org/ticket/6633#comment:3

    If you are interested in testing BP 2.5, maybe you can try in a local environment?


    dave-turnbull
    Participant

    @dave-turnbull

    Thanks r-a-y for the link. I’ll know to search in Trac from now on.

    As the error is with the bundled bbPress 1, I’m guessing the next thing to do is exclude BackPress from my repo/push. It seems this might be a way for me to get through the WP Engine syntax gatekeeping.

    Could I bother someone to let me know if simply deleting the BackPress folder is the legit way to handle this-assuming that I’m using a separate, late model install of bbPress.

    Note: the issue is present in the previous version of BuddyPress too, so it’s not a matter of using 2.5 locally, for now. In fact the bug is reportedly not being addressed (“wont fix”), so there’s no fix in sight.

    I’d say you’ve got an interesting problem here though, as anyone pushing to WP Engine is going to have the same issue as I am, and some won’t know where to turn for help. It’s a bit of a hassle for WP Engine to field support calls too, I imagine.


    r-a-y
    Keymaster

    @r-a-y

    I believe you can simply delete /bp-forums/bbpress/ and you should be good to go.

    However, I understand that this is annoying for WP Engine as you might have to do this manually each time BuddyPress has an update.

    An alternative is to pull the development version of the codebase (SVN or Git) from buddypress.trac.buddypress.org. Then, you can checkout the current maintenance branch (currently 2.4, but will be 2.5).

    The development version does not include the older version of bbPress; we only include the older version when bundling it for a release.

    Hopefully that helps somewhat.


    dave-turnbull
    Participant

    @dave-turnbull

    Thanks r-a-y! That’s super helpful. Much appreciated!

    Onwards…

    Running the dev build means you’re not getting the optimised CSS / JS files.

    If you’re able to deploy with a SVN checkout instead of Git, you could use svn co https://plugins.svn.wordpress.org/buddypress/tags/xxx/ --ignore-externals which will not include the bbPress folder from the checkout.

Viewing 5 replies - 1 through 5 (of 5 total)
  • The topic ‘BP 2.5 RC1: php syntax error?’ is closed to new replies.
Skip to toolbar