Skip to:
Content
Pages
Categories
Search
Top
Bottom

Missing %s in notification [BUG]

  • @dreampixel

    Participant

    5 days, 3 hours ago

    Hello @emaralive

    I’m sorry for tagging you out like this, but I thought you should know. 🙂

    I noticed that when a user has requested membership in a group and then goes to delete their account later, the notification is still there but it changes from:

    “XXX is requesting group membership” (or what the original string is – mine is translated now)

    to

    “[EMPTY SPACE] is requesting group membership”

    I’m not currently aware if there is more notifications that is affected, but for now I noticed this one. Maybe something that could be looked into and fixed in the next update? 🙂

    Thank you 🙂

    WP: Version 6.7.1
    BP: Version 14.3.3

Viewing 3 replies - 1 through 3 (of 3 total)

  • @dreampixel

    Participant

    5 days, 3 hours ago

    Update:

    Noticed that the following are doing the same:

    You have 1 new reply to the topic from [MISSING]

    So maybe it would make sense to check all the notifications? 🙂

    @emaralive

    Participant

    1 day, 21 hours ago

    Hi @dreampixel,

    Thanks for bringing this to my attention. It looks like some of the notifications are not being deleted when in actuality all should be deleted that are related to the deleted user.

    For example:

    • new_membership_request <- this is what you initially indicated
    • bbp_new_reply <- this what you indicated next
    • new_message <- notification for Private Messages

    The issue is that the function that deletes notifications in the event of a deleted user does not take into account that some notifications have the user_id of deleted user placed in the secondary_item_id column in the bp_notifications`database table.

    Long story shorter, I have a tentative patch that I am testing that will provide a remedy for this bug. I’ll create a ticket for a fix once I’m satisfied with the patch. I’ll keep you updated as to the progress and I’ll try to fit this into the next available release.

    @dreampixel

    Participant

    1 day, 12 hours ago

    Sounds great, thank you! 🙂

Viewing 3 replies - 1 through 3 (of 3 total)
  • You must be logged in to reply to this topic.

Topic Info

Topic Tags

Skip to toolbar