Skip to:
Content
Pages
Categories
Search
Top
Bottom

are there potential issues with completely dequeuing legacy CSS?


  • Steve Taylor
    Participant

    @gyrus

    7 years, 3 months ago

    We want to gain full control of styling, so we’re looking at dequeuing bp-legacy-css and starting styling of BP elements from scratch, integrated with our custom theme styles.

    Dequeuing itself is easy enough, but there’s a thread here which (1) contains a warning that completely ditching BP styles may break the site’s BP elements, but which (2) gets derailed into a conversation about whether to dequeue the minified version or not, and doesn’t really clarify the warning about breakage.

    What might break if we start styling from scratch? Is there not a system whereby ‘core’ CSS can be kept, but we can dequeue all CSS which won’t break anything if it’s missing?

Viewing 5 replies - 1 through 5 (of 5 total)

  • Henry Wright
    Moderator

    @henrywright

    7 years, 3 months ago

    Hi @gyrus

    You can de-queue BuddyPress styles like @r-a-y suggested in that thread (see #202777). This won’t break anything functionality wise although, of course, it will change your theme’s look and feel because all of the styling information will be gone.


    Steve Taylor
    Participant

    @gyrus

    7 years, 3 months ago

    Thanks. I was wary because @danbp suggested otherwise: ‘Yes i understand (i’m also using a bootstrap theme), you can do like you want. But don’t claim after that that BP doesn’t work correctly.’ You’re saying that ‘doesn’t work correctly’ means ‘won’t be styled correctly’? There seems to be a confusion between functionality and presentation here.


    Henry Wright
    Moderator

    @henrywright

    7 years, 3 months ago

    If you change the template markup things could break because the BP JavaScript relies on various classes. However, changing or removing a CSS file will change the look and feel only.


    Steve Taylor
    Participant

    @gyrus

    7 years, 3 months ago

    Thanks @henrywright. I’m discovering a few bits that are ‘utility’ styles that I’m copying over (e.g. screen reader text class). It’d be really useful if things like this were in a separate ‘core’ include for people who want to strip back to a minimum. Anyway, I’m ploughing ahead, I’ll keep an eye on the markup.


    Henry Wright
    Moderator

    @henrywright

    7 years, 3 months ago

    The screen-reader-text accessibility class is something that all themes should have I agree. You’ll likely find some RTL styles that are worth keeping also.

Viewing 5 replies - 1 through 5 (of 5 total)
  • You must be logged in to reply to this topic.

Topic Info

Topic Tags

Skip to toolbar