Topic: bp_get_the_thread_recipients() math is wrong · BuddyPress.org

Skip to:: Content; Pages; Categories; Search; Top; Bottom

bp_get_the_thread_recipients() math is wrong

colabsadmin
Participant

@colabsadmin

10 years, 10 months ago

bp_get_the_thread_recipients() count is off when there are more than 3 recipients. Its counting the sender as a recipients. So, for example, if I send a message to 4 people, the displayed recipients says

“Conversation between 5 Recipients and you” instead of “Conversation between 4 Recipients and you”

Viewing 4 replies - 1 through 4 (of 4 total)

Henry Wright
Moderator

@henrywright

10 years, 10 months ago

I think the wording here is the problem, not the math.

‘recipients’ would be far better is if said ‘participants’. There’s no real need for the ‘and you’ bit. That part is obvious as you know you’re in the conversation 🙂

colabsadmin
Participant

@colabsadmin

10 years, 10 months ago

Even if you changed ‘recipients’ to ‘participants’ it would still be wrong. Notice the “and you” at the end. If they change to ‘participants’ and removed ‘and you’ then you’re right, its no longer a count/math issue.

Henry Wright
Moderator

@henrywright

10 years, 10 months ago

@colabsadmin agreed!

You could raise a Trac ticket for this?

https://buddypress.trac.wordpress.org

Alternatively you could create your own version on bp_get_the_thread_recipients() – which is what I did.

colabsadmin
Participant

@colabsadmin

10 years, 10 months ago

done

Viewing 4 replies - 1 through 4 (of 4 total)

The topic ‘bp_get_the_thread_recipients() math is wrong’ is closed to new replies.