BuddyPress.org

Thanks for the feedback. I thought I’d seen somewhere that some Ajax had been taken out or simplified, but that’s not what’s going on here then.

I must have broken something. What parts do I need to put Ajax back together? Where is the Javascript for these delete buttons?

My delete link looks the same, including the class. I also have the template_notices line. I probably get the popup because Javascript is missing.

This thread has some clues. I’ll get back to this next week…

In version 1.0 the delete link was part of a file bp-wire-ajax.php (deprecated in version 1.1.3.), via a bp_wire_delete_link() function in bp-wire-templatetags.php that looked like this:

function bp_wire_delete_link() {

echo bp_get_wire_delete_link();

}

function bp_get_wire_delete_link() {

global $wire_posts_template, $bp;



if ( empty( $bp->current_item ) )

$uri = $bp->current_action;

else

$uri = $bp->current_item;



if ( ( $wire_posts_template->wire_post->user_id == $bp->loggedin_user->id ) || $bp->is_item_admin || is_site_admin() ) {

if ( $bp->wire->slug == $bp->current_component || $bp->profile->slug == $bp->current_component ) {

return apply_filters( 'bp_get_wire_delete_link', '<a href="' . wp_nonce_url( $bp->displayed_user->domain . $bp->wire->slug . '/delete/' . $wire_posts_template->wire_post->id, 'bp_wire_delete_link' ) . '">[' . __('Delete', 'buddypress') . ']</a>' );

} else {

return apply_filters( 'bp_get_wire_delete_link', '<a href="' . wp_nonce_url( site_url( $bp->{$bp->current_component}->slug . '/' . $uri . '/wire/delete/' . $wire_posts_template->wire_post->id ), 'bp_wire_delete_link' ) . '">[' . __('Delete', 'buddypress') . ']</a>' );

}

}

}

The same function in version 1.1.3 has some subtle differences:

function bp_wire_delete_link() {

echo bp_get_wire_delete_link();

}

function bp_get_wire_delete_link() {

global $wire_posts_template, $bp;



if ( empty( $bp->current_item ) )

$uri = $bp->current_action;

else

$uri = $bp->current_item;



if ( ( $wire_posts_template->wire_post->user_id == $bp->loggedin_user->id ) || $bp->is_item_admin || is_site_admin() ) {

if ( $bp->wire->slug == $bp->current_component || $bp->profile->slug == $bp->current_component ) {

return apply_filters( 'bp_get_wire_delete_link', '<a class="item-button delete-post confirm" href="' . wp_nonce_url( $bp->displayed_user->domain . $bp->wire->slug . '/delete/' . $wire_posts_template->wire_post->id, 'bp_wire_delete_link' ) . '">' . __('Delete', 'buddypress') . '</a>' );

} else {

return apply_filters( 'bp_get_wire_delete_link', '<a class="item-button delete-post confirm" href="' . wp_nonce_url( site_url( $bp->{$bp->current_component}->slug . '/' . $uri . '/wire/delete/' . $wire_posts_template->wire_post->id ), 'bp_wire_delete_link' ) . '">' . __('Delete', 'buddypress') . '</a>' );

}

}

}

I’ll try to replace some code and will report back…

I installed the Buddymatic theme, but get exactly the same error. The problem must be in the Buddypress core files somewhere – I had reuploaded those to make sure they are the untouched 1.1.3 files.

Any other suggestions what I could try to fix this or pinpoint the problem? This is driving me nuts…

The delete link looks like this:

<span class="activity-delete-link"><a href="http://mysite.com/activity/delete/20?_wpnonce=0f239e493d" class="item-button delete-activity confirm">Delete</a></span>

When I click I get the ‘Are you sure?’ popup and then when I click OK it redirects to ‘Page not found’ with the same wpnonce URL still in the address bar.

Why? Where is it supposed to go? Which piece of code is supposed to handle this wpnonce URL?

The problem is not in the theme. I tested two clean themes, default and buddymatic. Both had the same problem.

The problem has to be in the bp core code…

The delete button is produced by this function in bp-activity-templatetags.php:

function bp_activity_delete_link() {

echo bp_get_activity_delete_link();

}

function bp_get_activity_delete_link() {

global $activities_template, $bp;



return apply_filters( 'bp_get_activity_delete_link', '<a href="' . wp_nonce_url( $bp->root_domain . '/' . $bp->activity->slug . '/delete/' . $activities_template->activity->id, 'bp_activity_delete_link' ) . '" class="item-button delete-activity confirm">' . __( 'Delete', 'buddypress' ) . '</a>' );

}

When I remove ‘confirm’ from the class, the annoying ‘Are you sure?’ popup disappears, but the page still redirects to ‘Page not found’ and the unwanted wire item is still on the page.

I assume this function only produces the link; there must be another function somewhere that is supposed to process it. Where?!

ajax.js is loaded – I double-checked… – but what is the connection between the delete link and the javascript? Is that where the processing should take place?

ajax.php has this:

<div class="wire-post-metadata">

<?php bp_wire_post_author_avatar() ?>

<?php _e( 'On', 'buddypress' ) ?> <?php bp_wire_post_date() ?>

<?php bp_wire_post_author_name() ?> <?php _e( 'said:', 'buddypress' ) ?>

<?php bp_wire_delete_link() ?>

</div>

bp_wire_delete_link, not bp_activity_delete_link…

Probably same problem reported at the top of this thread, before I derailed it…

I’ve worked on another Ajax problem here. The delete buttons is probably something similar. I’ll have to go through the code in _inc/js/ajax.js when I have time again – assuming the delete button code is there as well.