Skip to:
Content
Pages
Categories
Search
Top
Bottom

BuddyPress child themes are getting rejected from WordPress repo.

  • @modemlooper

    Moderator

    14 years, 1 month ago

    The page.php doesn’t include the comments coded. Can you add it to the default theme? I know I can add it myself to child theme but It kinda defeats the purpose of a child theme :)

    @DJPaul @boonebgorges

Viewing 7 replies - 1 through 7 (of 7 total)

  • @djpaul

    Keymaster

    14 years, 1 month ago

    I don’t know what you mean. Plus I think we are reluctant to change the default theme at all before 1.3.

    @modemlooper

    Moderator

    14 years, 1 month ago

    The page.php file for the default theme is missing

    comments_template();

    So theme reviewers are rejecting BP child themes because they test a page and the comments are not showing. I’m not sure why now after months they have decided to reject any new themes due to this but it’s happening to themes already in the repo that i’m trying to fix.

    @hnla

    Participant

    14 years, 1 month ago

    Isn’t the simple answer to copy across page.php fix up and submit? they are testing the child theme after all, it will perform as expected then, it may defeat the purpose of a child theme but fixes the issue from your perspective?

    @djpaul

    Keymaster

    14 years, 1 month ago

    @modemlooper https://trac.buddypress.org/changeset/3334/
    I’ve just put this into trunk. Thank you for the heads-up.

    @hnla

    Participant

    14 years, 1 month ago

    Darn it I could have added that ages ago is this really the first time it’s been noticed :)

    @modemlooper

    Moderator

    14 years, 1 month ago

    I posted about it awhile back :P This happened on another theme and I added the page.php file but it should be in the default. I forgot about the issue until I just updated a child theme and they rejected again. The last time it happened it took 6 weeks to get the theme finally approved. I guess they were backed up reviewing themes. I may stop using the repo. It takes too long to fix minor things. Why do they have to review themes but not plugins? Never understood this.

    @hnla

    Participant

    14 years, 1 month ago

    Themes more obviously break things, they are for more obvious if they perform badly, and reflect that much more on WP as a whole would be my guess. I’ve always been of the opinion that they really ought to be vetting plugins as a badly written plugin could have far more serious consequences it would be nice to see a two tier repository where there were approved /recommended /tested plugins and a second general pool but it’s probably a lot of work.

    It had crossed my mind to mention the lack of comment tag in pages but sort of thought that it might have been for a reason and that I’d be pointing out the obvious.

Viewing 7 replies - 1 through 7 (of 7 total)
  • The topic ‘BuddyPress child themes are getting rejected from WordPress repo.’ is closed to new replies.

Topic Info

Skip to toolbar