Skip to:
Content
Pages
Categories
Search
Top
Bottom

Child Themes, 1.2 & bp-default: No Child Theme Left Behind


  • Mike Pratt
    Participant

    @mikepratt

    @Andy – In the Codex, you state (re bp-default and child theming):

    NOTE: This will be changing for the upcoming BuddyPress 1.2. The overall idea remains exactly the same, however you should be using the new bp-default theme as a parent theme instead. This theme is much simpler to work with.

    Could you elaborate a little more on using bp-default as a parent? The guide as is would imply deactivating bp-default and setting it as “Template: bp-default” in a new child theme.

    But then in bp-default you state:

    ** IMPORTANT – DO NOT COPY THIS THEME **

    If you want to make a custom theme based on this theme, DO NOT copy and edit it. By

    doing this you will make upgrades and maintainence much harder for yourself.

    Instead, please read this codex page on how to build a BuddyPress child theme:

    So what do you suggest as a starting point for child theme dev? Or will bp-default morph into a parent with a skeleton child theme emerging a la how bp-classic was?

Viewing 6 replies - 26 through 31 (of 31 total)

  • fostertime
    Participant

    @fostertime

    Ok, I got it to work.

    Basically the extent of my customizations are so extreme that it was just a smarter route to not use Template: bp-default.

    I removed that from style.css, reloaded the theme and all is working fine. I am assuming that since I am not using the bp-default option that nothing will inherit from that theme, correct?


    designodyssey
    Participant

    @designodyssey

    @Mike

    I had a long post on my troubles dealing with the default image and header issues. I’m using BP1.2 beta with Hybrid as parent and Hybrid News as child. Added BP default folders to Hybrid News theme folder. Modified functions.php and ended up with the same/similar problem as you. I deleted

    /* Set the defaults for the custom header image (http://ryan.boren.me/2007/01/07/custom-image-header-api/) */
    define( 'HEADER_TEXTCOLOR', 'FFFFFF' );
    define( 'HEADER_IMAGE', '%s/_inc/images/default_header.jpg' ); // %s is theme dir uri
    define( 'HEADER_IMAGE_WIDTH', 1250 );
    define( 'HEADER_IMAGE_HEIGHT', 125 );

    function bp_dtheme_header_style() { ?>
    <style type="text/css">
    #header { background-image: url(<?php header_image() ?>); }
    <?php if ( 'blank' == get_header_textcolor() ) { ?>
    #header h1, #header #desc { display: none; }
    <?php } else { ?>
    #header h1 a, #desc { color:#<?php header_textcolor() ?>; }
    <?php }
    ?></style>
    }

    but that didn’t help.

    Solved it for me by commenting out all the CSS in default.css under the heading “Header” since Hybrid News is taking care of all of this. Obviously, mileage may vary.


    Roger Coathup
    Participant

    @rogercoathup

    @Andy – I’m having the same issues as @Mike and @designodyssey:

    I want to use bp-default as the parent, but don’t want the custom header, and other inline css settings.

    Unfortunately, functions.php in bp-default is adding inline css, which is therefore difficult / cumbersome to override in the child theme.

    As a quick fix, I suspect I’ll remove functions.php from bp-default theme, and just copy over the functions I want into a functions.php in my child theme. Obviously this is not ideal.

    Is there a better way to solve this? Perhaps a hook to remove the offending functions?


    Roger Coathup
    Participant

    @rogercoathup

    Update: I’ve just seen the comment in the functions.php, advising how to remove the custom header:

    /****

    * Custom header image support. You can remove this entirely in a child theme by adding this line

    * to your functions.php: remove_action( ‘init’, ‘bp_dtheme_add_custom_header_support’ );

    */

    Thanks!


    Roger Coathup
    Participant

    @rogercoathup

    Further update:

    I’ve tried adding the remove_action line to my functions.php in the child theme, but it makes no difference… the custom header / inline CSS is still being inserted.

    Any suggestions?


    Leia Scofield
    Participant

    @leiascofield

    Roger — MrMaz has the solution to that over here.

Viewing 6 replies - 26 through 31 (of 31 total)
  • The topic ‘Child Themes, 1.2 & bp-default: No Child Theme Left Behind’ is closed to new replies.
Skip to toolbar