Child themes are not being accepted to the REPO at this time
-
FYI: For anyone wanting to add BP child themes got this in last review
This submission cannot be approved at the moment simply because there is
no support for Child Themes. Please check back and once we start accepting Child Themes feel free to
resubmit.Thank you for your contribution.
-
Got a back and forth convo of reviewers that’s quit comical. They did approve. I think BuddyPress should be an exception but at the same time must use all BuddyPress functions / components and of course pass WordPress theme scan.
The child theme they are questioning is just a CSS file one page template and a funtions file. That should pass 100% but they scan it and it fails 99% because they are scanning against WordPress not BuddyPress
How big is BP? Should it have it’s on theme section in the repo or will the requirement be that it will work as WP theme when BP is switched off? Do we as a community need our own site for free BP child themes? These questions and many more when we come back from this commercial break.
Reviewers requirements for bp-default:
`REQUIRED: No content width has been defined. Example:
if ( ! isset( $content_width ) ) $content_width = 900;
REQUIRED: Could not find post_class. See: post_class <div id="post-” >
REQUIRED: Could not find comment_form. See: comment_form
REQUIRED: Could not find add_theme_support( ‘automatic-feed-links’ ). See: add_theme_support
REQUIRED: options.php. Themes should use add_theme_page() for adding admin pages.
Line 5: add_action( ‘admin_menu’, array( ‘Bp_Dtheme_Options_Page’, ‘add_options_page’ ) );Line 8: function add_options_page() {
REQUIRED: get_the_author_email found in the file search.php. Deprecated since version 2.8. Use get_the_author_meta(’email’) instead.
Line 28:
REQUIRED: get_the_attachment_link found in the file attachment.php. Deprecated since version 2.5. Use wp_get_attachment_link() instead.
Line 15: ID, true, array(450, 800)); This also popREQUIRED: get_links_list found in the file links.php. Deprecated since version 2.1. Use wp_list_bookmarks() instead.
Line 19:
REQUIRED: delete_usermeta found in the file ajax.php. Deprecated since version 3.0. Use delete_user_meta() instead.
Line 95: delete_usermeta( $bp->loggedin_user->id, ‘bp_new_mention_count’ );
REQUIRED: .gallery-caption css class is needed in your theme css.`The lack of BP theme authors, and the newness and complexities of supporting child themes in the repo makes this an easy target for confusion for everyone. I remember glancing over Otto’s update but I never got a heads up it was official for BP. Unless it’s just alwas been that way and it predates me.
Ideally we would want a dedicated BuddyPress theme reviewer that’s familiar with BP and has the time to maintain those specific themes, test them with future versions of BuddyPress, etc. Even more ideally if it was someone active in the forums and trac. Being a theme reviewer is a volunteer position that comes with it lots of responsibilities and expectations. It also doesn’t help that bp-default triggers a ton of debug notices in the 1.2 branch.
As my focus shifts around and as I settle in to my new role at Automattic, I’m slowly picking up access and getting familiar with things like this that I’ve never rounds before.
- The topic ‘Child themes are not being accepted to the REPO at this time’ is closed to new replies.
