In friends only activity plugin change the following code
/* if member of a group – we want the activity even if nonfriend */
if ( $activity->component != 'groups' && $activity->user_id != 0 && !my_is_friend_check($activity->user_id) && !my_is_atme_check($activity->content) ) {
Into
/* if member of a group – we want the activity even if nonfriend */
if ( $activity->component != 'no_activity_component_shown' && $activity->user_id != 0 && !my_is_friend_check($activity->user_id) && !my_is_atme_check($activity->content) ) {
@informerfrk I am running that plugin, and made the change to the code, but it had no effect.
I even approved some people after updating the new code and they still showed in the group activity feed.
Ahh, so it worked to show me only my friends joining. Which is work-able.
But now I get
Warning: Division by zero in /home/recivity/public_html/wp-content/plugins/buddypress/bp-activity/bp-activity-template.php on line 783
Add this if your using that old outdated plugin:
/* Stop errors if any */
error_reporting(E_ERROR | E_PARSE);
/* End Stop Errors */
Generally I’d rather fix the problem than just mute the error. But in this case I gave it a try, re-enabled the code, and suppressed the error.
But it turns out, the code above is hiding ALL activity from non admin accounts. Not just joins.
There has to be a “right” way to do this that doesn’t involve an “old outdated plugin”
Any suggestions, @bphelp?
Rather than filter it, prevent the entry from being created.
Try this in your theme/functions.php or plugins/bp-custom.php
It won’t remove existing entries, but should stop new ones.
function victor_dont_save_join_group_activity( $activity_object ) {
$exclude = array( 'joined_group' );
if( in_array( $activity_object->type, $exclude ) )
$activity_object->type = false;
}
add_action('bp_activity_before_save', 'victor_dont_save_join_group_activity', 1, 1 );
@Shanebp you are my hero.
