BuddyPress.org

Hi @valuser

Could be a stupid question, but have you enabled ‘site tracking’?

Any chance you can post all of your code? Perhaps in Pastebin? The code you’ve provided here looks sound so there must be something else at fault

Having re-looked over your code for bp_activity_add() above, try setting the activity type to new_blog_post

For example:

$activity_id = bp_activity_add( array(	
    'action'            => 'A link from NewsSite', // The activity action - e.g. "Jon Doe posted an update"
    'content'           => $post_content,        // Optional: The content of the activity item e.g. "BuddyPress is awesome guys!"
    'component'         => false,                  // The name/ID of the component e.g. groups, profile, mycomponent
    'type'              => new_blog_post,                  // The activity type e.g. activity_update, profile_updated
    'primary_link'      => 'false',                 // Optional: The primary URL for this item in RSS feeds (defaults to activity permalink)
    'user_id'           => bp_loggedin_user_id(),  // Optional: The user to record the activity for, can be false if this activity is not for a user.
    'item_id'           => false,                  // Optional: The ID of the specific item being recorded, e.g. a blog_id
    'secondary_item_id' => false,                  // Optional: A second ID used to further filter e.g. a comment_id
    'recorded_time'     => bp_core_current_time(), // The GMT time that this activity was recorded
    'hide_sitewide'     => false,                  // Should this be hidden on the sitewide activity stream?
    'is_spam'           => false                  // Is this activity item to be marked as spam?
  ), );

What are you hooking your bp_activity_add() function to?

Also it’s weird that the inserted post has a guid ending in /post-name, which is a different format to the rest of your posts. The guid is something you shouldn’t really need to override, it’s best to let WP handle it.

Try adding this to your theme’s functions.php file:

function valuser_add_new_post_activity( $ID, $post ) {

    $user = get_userdata( $post->post_author );

    $args = array(
        'user_id' => $post->post_author,
        'action' => $user->user_login . ' published ' . $post->post_title,
        'component' => buddypress()->blogs->id,
        'type' => 'new_blog_post',
        'item_id' => get_current_blog_id(),
        'secondary_item_id' => $post->ID,
        'recorded_time' => bp_core_current_time(),
        'hide_sitewide' => false
    );
    bp_activity_add( $args );
}
add_action( 'publish_post', 'valuser_add_new_post_activity', 10, 2 );

That’s how I’d add new blog posts to the activity stream. I’ve hooked bp_activity_add() to the published_post action which will fire each time a new post is added to the database.

Please note I haven’t tested.

Humm, that’s strange. Can you try posting a new post from the WP admin area so see if it works from there?

From http://pastebin.com/fMnJh5T0

Clicking on the ruby brings up http://imgur.com/jE3hUzD and clicking on “Home Place” effects the transfer and so far so good the transfer is inserted as a post in the users pblog

Can you paste the code which actually creates the post? For example, where does the following come from?

$post_id = wp_insert_post( array(
'post_author'	=> $user_id,
'post_title'	=> $post_title,
'post_content'	=> $apost_content,
'post_category'	=> $category_ids,
'tags_input'	=> $tags,
'post_status'	=> 'publish'
), $wp_error );

Right, I’m with you.

After this line in the plugin

echo 'Shared successfully to your Home Place with tags: '.$tags;

Can you add this?

do_action( 'newsbaby_after_insert_post', $post_id );

Then change my code you added to functions.php to:

function valuser_add_new_post_activity( $post_id ) {
    $post = get_post( $post_id );
    $user = get_userdata( $post->post_author );

    $args = array(
        'user_id' => $post->post_author,
        'action' => $user->user_login . ' published ' . $post->post_title,
        'component' => buddypress()->blogs->id,
        'type' => 'new_blog_post',
        'item_id' => get_current_blog_id(),
        'secondary_item_id' => $post->ID,
        'recorded_time' => bp_core_current_time(),
        'hide_sitewide' => false
    );
    bp_activity_add( $args );
}
add_action( 'newsbaby_after_insert_post', 'valuser_add_new_post_activity' );

That should do it 🙂

However a “normal” post via wp-admin came in just once onto activity.

Yeah, that’s expected because you’ve enabled site tracking.

did two new post transfers – they arrived but not in activity.

This bit isn’t expected because with my code in place, an activity entry should be created each time the wp_insert_post() function in your plugin executes.

There must be something going on elsewhere that we’re missing.

Just out of interest, plugins_loaded seems rather early. Try changing that to wp on line 15. And I’m not sure that a negative priority is necessary? So for example, try changing line 15 to:

add_action( 'wp', 'newsbaby_blog_addthis', 1 );

I’m not 100% convinced that’ll solve the issue though.

Going back to this, the following hook can’t be firing.

do_action( 'newsbaby_after_insert_post', $post_id );

If this fired, then the valuser_add_new_post_activity() function would execute and that would result in an activity item being created.

Hi again @valuser

Just read through the Pastebin text, and yeah the bookmark tool looks great. Worked perfectly! I’m still puzzled by why the activity item isn’t created when you create a post by clicking Home Place. My hunch is that valuser_add_new_post_activity() isn’t executing due to the newsbaby_after_insert_post hook not firing.