hi @fencer04,
thank for sharing your work. Well done, but it needs some revision (sorry).
At his activation on 2 test sites (one with 4.5.3/bp 2.6.1, other 4.6/bp2.6.2) i got a notice.
Array to string conversion in buddypress/bp-core/classes/class-bp-core-nav.php on line 279from
sbpp04_privacy_check( ) ..\plugin.php:525
sbpp04_privacy_redirect( ) ..\buddypress-profile-privacy.php:176
bp_core_remove_nav_item( ) ..\buddypress-profile-privacy.php:184
BP_Core_Nav->delete_nav( ) ..\bp-core-buddybar.php:798
Another point concerning UI/UX is the Private button appearing on buddybar.
On this tab, a default message says Friends Only.
USERNAME has chosen to limit profile access to friends only.
That’s wrong! Because this appear on each profile, even if the owner hasn’t setup anything about his profile privacy.
So far i understand its fonctionality, this plugin let each member decide to show or not his whole profile page to friends or members only or to everyone (bp default).
– imo this tab should show “This profile is private” to anybody who is concerned by a privacy setting and should not appear at all if “Everyone” is set.
– the original BP Add as friend button on profile header or members directory is still there. This means that there is no need to go on Private tab to ask forfriendship.
This is a little confusing !
If the plugin is to extend profile settings, it should appear in profile settings only. And as it doesn’t superseed BP, there is no real reason to give him an extra tab on buddybar outside of the settings scope. A template notice could be enough to tell visitors what’s going on on such a profile.
Just my 2 cents.
I really appreciate the review. I’ll look into the error on a fresh install and see what happens. I have a question about the “Private” button.
This should only appear if the person has selected Friends only. Is it appearing all the time for you?
Can you explain this comment further:
– the original BP Add as friend button on profile header or members directory is still there. This means that there is no need to go on Private tab to ask forfriendship.
This is a little confusing !
I’m not sure what you mean by this. Why is having the button in two places no good?
I agree with the location of the settings. That is on my list of changes to make shortly.
Turns out the error you pointed out is a bug that is being tracked in BuddyPress. It will be resolved in version 2.7. I will still see if I can alleviate it somehow:
https://buddypress.trac.wordpress.org/ticket/7203
Is it appearing all the time for you?
Yes !
If i see a direct access to a functionality like Add as Friend on the profile header, why would i go to a tab labeled Private to do that ? That’s not very logic imo.
When i go to a profile, i see the header first and (depending whats used on the site) a more or less long buddynav menu. 😉
No worry about the notice. I don’t activate wp_debug on a production site.
Thank you for the clarification. The “Private” tab should not appear unless you are being blocked. I posted an update that resolves that issue as well as some related to the Friends Component not being activated.
Can you install that and let me know if you still see Private all the time?
Updated to 0.6
It’s better now for friends but very restrictive for logged in user only.
When a user choose “only logged in users”, and myself as not logged trying to see his profile, i’m redirected to register page when i click on the member name.
– without a specific message telling me why i’m invited to register, it is un understandable. Also you can’t presume the status of a visitor. I can visit the site i’m a member of without login systematicaly. As non logged, but virtually a member, being leaded to registration is ambigous.
– could be as option, but as default for that status, it is too restrictive. I should see at least his activity. And if i click on the profile item, i may see “You must be logged in to access this user profile information”. Something like that.
We’re cross-posting ! 🙂 Hope you can follow !
– As non logged visitor, when i’m on a user profile who hasn’t set anything i don’t see Private.
– If i’m on a profile having a friend privacy setting, i see it.
– If on a profile set for “only logged in users”, i’m redirected to register.
I was thinking the same thing about the redirect. You may not understand why you are being redirected there. I’m planning on setting up a different message for that similar to the Friend’s Only message. Iw will also have an option to redirect since that was actually a request I got from a client.
The whole idea is that the profile is locked down completely so I don’t want the viewer to see the activity or any other part unless they fit the criteria laid out by the member.
Thank you again, if you are interested in testing out future versions let me know and I’ll contact you when I post them.
The whole idea is that the profile is locked down completely so I don’t want the viewer to see the activity or any other part unless they fit the criteria laid out by the member.
I understand that. But as the member appears on SWA and directories, you have to go deeper into BP and hide his activities, remove it from directories and so on. Or as already said, give this as “ultimate” option, with a big warning to site admins – and to the user. Something like: if you choose this option, your whole profile (activity, friends and group membership list) will be hidden to all members and visitors.
It was initially for a client of yours, ok, but that’s a specific use case. I would better leave that possible from inside the plugin code only (ie. a filter that a dev could activate) and give a smoother option for common community usage to the majority of BP users.
