Yes, you do. I also recommend switching your theme back to the default WP theme, to be on the safe side.
I learned from Andy that it’s helpful to:
1. Deactivate the buddypress plugin.
2. Backup your content (I didn’t need to, but better safe than sorry)
3. Purge the buddypress folder and its contents from the plugins folder.
4. Download the latest version. Upload the “buddypress” folder back into the plugins folder
5. Activate the plugin. Done.
It may seem like an extra step, but I’ve found it was most effective.
well, I admit that I’m new at both WP & BP so, i upgraded without first deactivating scripts. (in my defense, however, i did go tothe upgrades page but there were no instructions on how to go from 1.2 -> 1.2.1 and i assumed a minor upgrade might have only limited/isolated changes — ok, i was lazy. fortunately, i was on my practice site.
right off the bat, i see that one of my plugins in the practice area is broken (“Group Documents”) . As buddypress tries to restart, the error reported is “Call to undefined function is_site_admin()”. obviously, this worked before the upgrade so, i’m wondering…
1) has this function been deprecated and, if so, is there a replacement function?
2) where do i find what changes were included in 1.2.1?
But ‘is_site_admin()’ is a WP function not BP; seem to remember mention of a change to something like ‘is_super_admin()’ but things shouldn’t break – should they? if the function is deprecated that’s fine but the function should still work, it’s quite a critical thing really 
@pjnu –
about deleting the buddypress plugin folder – I assume you make a copy of your custom bpcustom.php file and copy that back into the folder after the fresh upload, or does that only apply to bp 1.0 & 1.1 installations?
You keep bp-custom.php within your BuddyPress plugin directory? I have mine in the root of /wp-content/plugins/
@ catinw12
Um, I’m not sure what you mean. Are you asking if I purge the older buddypress folder, upload the new one, then uploaded the any files I’ve customized? Yes. I left that detail out. That’s why the backup is essential! I made sure to overwrite some standard BP files with the saved customized files I’ve created.
Thanks to everyone for the quick feedback.
@dwdutch
@hnla
is_site_admin() is a buddypress function (defined in bp-core-wpabstraction.php) that is being called by Group Documents. This will throw an error if group documents remains activated after you de-activate Buddypress. Although this error will be fixed in the next version of Group Docs, in general, you should deactivate Buddypress plugins before deactivating Buddypress itself
@ peter-anselmo
Ah thanks for clarification I had thought is_site_admin() was a WP function, my mistake. So having a BP reliant plugin activated but not Buddypress throwing this error makes sense.
On a sidenote did I not read Andy mentioning that there is a method that is supposed to ensure BP plugins cannot error in this fashion if BP disabled? Are they not supposed to perform a check first to determine if BP is functioning.
just to close the loop… I commented out the is_site_admin() call in the plug-in Group-Documents.. et voila, my WP installation popped back up. sure enough, BP was deactived while Group-Documents was activated. I deactivated Group-Documents; removed my comments around the is_site_admin(); reactivated BP then reactivated group-Documents.
Everything works great!
Valuable lessons learned…
1) I’ll always deactivate plug-in before upgrading.
2) i know where to find the changelog
Thanks, ya’ll!
@xp02ed
@peter-anselmo
