Skip to:
Content
Pages
Categories
Search
Top
Bottom

User and options menus on directory pages in the Skeleton theme

  • Avatar of Simon
    Simon
    Participant

    @conceptfusion

    I’m having trouble identifying why in the skeleton theme the Blog, Group and Member directory pages include both the user and option bar navigation lists with their respective items “selected”… In the default member theme these menus don’t appear on the directory pages as one would expect with them not being actual member pages.

    I’m sure I could write some logic around the userbar and optionbar calls but I figure there must be a cleaner approach being utilised in the default member theme… I just couldn’t find it.

Viewing 10 replies - 1 through 10 (of 10 total)
  • Avatar of Simon
    Simon
    Participant

    @conceptfusion

    Just pinging this back to the top to see if anyone else is having this problem and knows of a fix? :-)

    Avatar of Ezd
    Ezd
    Participant

    @ezd

    I remember Andy said he would fix this in a different post. Althrough I do not think this has been resolved in the latest skeleton theme yet.

    Avatar of Roger Coathup
    Roger Coathup
    Participant

    @rogercoathup

    @Simon… just came across the same problem (the bars also seem to have meaningless links in them)… did you get anywhere with a fix?

    Avatar of Burt Adsit
    Burt Adsit
    Participant

    @burtadsit

    Roger, I haven’t looked at the skel member theme yet but perhaps it’s missing a :

    $bp->is_directory = true; declaration.

    That goes right before you do:

    wp_enqueue_script( )

    bp_core_load_template( );

    Which launches the directory template. Setting that var turns off the userbar and the options bar.

    Avatar of Jeff Sayre
    Jeff Sayre
    Participant

    @jeffsayre

    Also, I’m not too sure that the skeleton theme has been kept up to date with the recent changes–at least changes up to v1.0.1. Andy would know.

    Avatar of Roger Coathup
    Roger Coathup
    Participant

    @rogercoathup

    @burt: not sure where to look for those function calls, but the bp_is_directory() function is returning true. Is that fed off the same declaration?

    @Jeff: cheers… any pointers on other pitfalls to look out for with the skeleton theme would be appreciated. I’ve picked up on quite a few html / css markup issues. My theme (based on skeleton) is for a commercial client, so I’d like to make sure it will stand up to core upgrades.

    Avatar of Roger Coathup
    Roger Coathup
    Participant

    @rogercoathup

    Ok, I have the solution:

    header.php in the skeleton template directly calls:

    <?php load_template ( TEMPLATEPATH . ‘/optionsbar.php’ ); ?>

    This bypasses any checking to see if it is a directory.

    Instead, replace this line with:

    <?php bp_get_optionsbar(); ?>

    and everything works fine.

    The same applies to the userbar.

    Avatar of Burt Adsit
    Burt Adsit
    Participant

    @burtadsit

    Ha! Well that isn’t terribly optimal is it? Since the skel theme is distributed with bp I guess the best place to have this issue brought up is in trac. You found it and the solution. You get the credit and honor of reporting it with a patch.

    http://trac.buddypress.org/newticket

    Same credentials as here if you’ve never been there before.

    Avatar of Roger Coathup
    Roger Coathup
    Participant

    @rogercoathup

    @Burt: thanks, have registered it in trac

    Are there guidelines on what should be reported to the trac, and what belongs on the forums?

    Avatar of Jeff Sayre
    Jeff Sayre
    Participant

    @jeffsayre

    @Rogercoathup

    Not really. The standard operating procedure on the forums is that when a given issue is finally determined to be a bug, and that bug has been isolated, that it then gets posted in trac.

    But, if you think that you’ve found a bug, you can go right into trac and file a new ticket. If it is big enough of an issue, creating a thread in the forums and pointing to your new trac ticket may be in order.

Viewing 10 replies - 1 through 10 (of 10 total)

The topic ‘User and options menus on directory pages in the Skeleton theme’ is closed to new replies.