BuddyPress.org

done and works

Ah great. Thanks for clearing that up

For the time being, our groupwiki plugin requires multiple blogs anyway so I won’t rush out to change the code. I’ll make sure that the version that is released in a week or two is correct and up to date though.

Not at all. I was trying to provide credit for your code as I pretty much just copy-pasted it rather than work out the problem for myself.

Don’t be so touchy

( Trust me, once the groupwiki plugin is out and you see the dodgy code in there, it will be quite obvious that I wouldn’t critisize the code of the helpful people/plugin developers on here )

edit: Ah, I can’t edit my original post to make sure it’s clear that I’m not trying to be insulting about your code DJPaul. Apologies.

Update:

https://trac.buddypress.org/changeset/2472/trunk

Now dependent plugins can hook their code into bp_init and know that all plugins have been loaded.

If you’re a plugin author and are writing a plugin specifically for BuddyPress you will want to load your code by doing exactly what I describe above.

@JJJ

In the change sheet, I see you are calling this on “plugins_loaded” action, that too with default priority level, does that mean, we do not need setup globals/other things using “plugins_loaded” action in our plugins, and we have to stick with this “bp_init” action.

btw, It is a cool idea, I am going to test with the trunk, If it works, It will certainly help 3rd party plugin developers greatly

Edit: corrected a typo

hi Ray

plugins_loaded is the standard action which gets called when all the active plugins’s source code is included(loaded) by wordpress, so It tells you that all the plugins are ready, and you can call your functions now.

The advantage of using “plugins_loaded” action is that, it is the first action hook which gets called after your(/all other active plugins source code is loaded by wordpress) , so You can be sure your code is called quiet before anything else happens.

Investigate wp-settings.php for more.

JJJ has proposed a nice solution with the bp_init action(just introduced in the r2472).

Because wordpress does not guarantees which plugin gets loaded first( it has something like, the plugins consisting of bare files are loaded first, the the plugins which are inside their own directory loaded alphabetically, AFAIK,It might have changed recently), So a plugin which is dependent on buddypress, will have many issues detecting bp is loaded or not.

So, JJJ’s solution helps there as all the buddypress methods which are called on plugins loaded action have priority less than default(less means higher priority), so if we hook to bp_init, we can be sure buddypress is loaded and you are still calling at the same action, I am already trying my hand with this, and it seems to be working,still testing though.

btw, if you have your plugins, which uses the hook “plugins_loaded” and has priority greater than 10, i.e 11 or anything else, you don’t need to worry about this change.

@r-a-y

Using plugins loaded still does not promise that the user has BuddyPress installed on their site and activated on that particular blog, so you will still want to do the check for BP_VERSION.

It’s a dizzying setup, trying to make plugins off of plugins that may or may not be there, or are there but just aren’t loaded yet, or are loaded before yours because another plugin force loaded it out of order.

Going forward from BP1.2, we can avoid all of those issues. Remember too that bp_init has priorities too. If you need to make sure your plugin is loaded before any other BuddyPress extensions are, you can prioritize it’s load the same way as any other WordPress action.

I ran into a problem with the bp_init method of loading, and need some feedback.

‘bp_init’ is called on ‘plugins_loaded’ p10, but ‘bp_core_set_uri_globals’ runs on ‘plugins_loaded’ p3 which depends on $bp->root_components. So its not possible to add a root component using ‘bp_init’ in time for some of the setup calls.

Here is my hack to make it work right until a solution is agreed upon. You need an additional function:

function bp_foobar_setup_root_component() {

// Register 'foobar' as a root component

if ( function_exists( 'bp_core_add_root_component' ) )

bp_core_add_root_component( BP_FOOBAR_SLUG );

}

add_action( 'plugins_loaded', 'bp_foobar_setup_root_component', 2 );