Forum Replies Created
-
Thanks everyone! I had a good day, played some golf, can’t complain about that.
Thanks everyone! I had a good day, played some golf, can’t complain about that.
Nice – could you update it so it uses bp_init please? Thanks, all explained at the top of the first post:
https://buddypress.org/forums/topic/plugin-hall-of-shame-plugin-devs-please-read/
Also there are not “private hidden” groups. There are “private groups” that are private but not hidden, and “hidden groups” that are both private and hidden.
Installing and using BP has certainly become a lot easier since the 1.0 days, hopefully it will continue to get easier with each release.
There will be a 1.2 point release hopefully on the same day that 3.0 is released to fix any compatibility issues. 1.3 won’t be finished in time for 3.0. You can use the 1.2 branch to keep up to date with the fixes as they happen.
You can add them in the template to force override (create a child theme and override activity/activity-loop.php):
<?php if ( bp_has_activities( bp_ajax_querystring( 'activity' ) . '&scope=friends' ) ) : ?>@foxly – is_site_admin() does not exist in WordPress versions prior to 3.0. BuddyPress adds it for its own use, if BuddyPress is not active and your plugin calls is_site_admin() then the site dies.
Those users must become active to show up in member listings. If they log in to the site at least once they will show.
Thanks, this is fixed in the 1.2 branch and will be in the next release.
If you are using hooks that fire before bp_init then you can keep them in the loader file. You must be very sure that aren’t calling any BuddyPress functions though.
If you’re not sure just deactivate buddypress with your plugin active and see if it crashes.
This sounds to me like there is something broken in your theme. Can you try the default theme and see if it works?
Burned! Yes I need to fix it – but this is for plugins that break BuddyPress upgrades
A bit off topic but – yes, I’m committed to making this happen in 1.3.
Please update this plugin to work when BP is disabled. See:
https://buddypress.org/forums/topic/plugin-hall-of-shame-plugin-devs-please-read
@etiviti (rich!) – Modifying items before bp_init is fine in the main file, but you must be careful not to reference any functions in BuddyPress.
@etiviti (rich!) – Yes, but the code needs to move to a separate file as it’s as simple as referencing a BP function in that code and it will break. It’s risky.
@Magganpice – yes there is a fatal error catcher when activating plugins, but not when a plugin is deactivated on upgrade.
It’s a lighthearted hall of shame, I’m calling them out because it’s important. The updates take 5 minutes, we can’t continue to have BuddyPress crash because of plugins every time it updates.
It’s really easy to test, deactivate all plugins then activate the plugin in question. If your site gets a white screen or white screen with error then it’s not friendly. You can delete the plugin in wp-content/plugins to get your site back again.
Yes but you can’t be sure bp-core-wpabstraction.php is loaded until bp_init fires. Regadless, try to use current_user_can() instead.
I’ve checked all the plugins and updated the list.
$activity_id = bp_activity_post_update( array( ‘content’ => $content, ‘user_id’ => $user_id ) );
$activity_id = groups_post_update( array( ‘content’ => $content, ‘user_id’ => $user_id, ‘group_id’ => $group_id ) );
The functions above will post an update by the user on their profile, or in a group. It will return the activity ID which you can use to attach a comment:
$comment_id = bp_activity_new_comment( array( ‘activity_id’ => $activity_id, ‘content’ => $content, ‘user_id’ => $user_id, ‘parent_id’ => [optional] ) );
You could post a reply to that comment by using the same function and passing the $comment_id as the parent_id param.
This is not true of all activity though. For activity updates and comments it really does mean delete.
Let’s put our collective heads together and work out which plugins are breaking when BuddyPress is deactivated. I’ll update the list over time.