I’ve changed this to a class.
Not sure I’m getting all possible advantages of using a class.
If a dev sees this, any tips appreciated.
Thanks to mercime for the issue report re the first commit.
https://github.com/shanebp/BP-Member-Notes
@mercime
Thanks for the new issue report.
I can’t duplicate, but made a tweak.
Could you please test again ?
[ just posting here in case you aren’t rec’ing issue updates ]
>> just posting here in case you aren’t rec’ing issue updates
@shanebp Thank you for posting here. I’m not receiving issue updates from ghub. Fatal error could possibly be due to the fact that I’m running trunk versions of WP, BP, and bbP in that install. Will check out update.
@mercime
I’m curious about what caused the error on your install, while no errors on mine.
So I created a simple plugin to test for whether BP is activated here:
https://github.com/shanebp/a-bug-test
No biggee, just wondering…
@shanebp I deleted the old BP Member Notes which I had to rename to get wp-admin back and uploaded the new version via wp-admin and activated it. Deactivated BuddyPress plugin and no more fatal error. BP Member Notes is still activated in plugins installed page yet no more Users > BP Member Notes as is rightly so.
P.S. I did get the issue notice from github. I was looking in my other email account 🙂
P.P.S. Do I still need to do the bug test? Never seen this before:
Plugin Name: A Bug Test
This is for mercime only.
🙂
>P.P.S. Do I still need to do the bug test?
No need re BP Member Notes.
But it might be useful re the larger context of why the fatal error occurred.
The plugin file should never have loaded – due to the standard bp_include check in the loader.
If my guess is correct, the bug test plugin will load, on your install, even if BP is deactivated.
As I said, no big deal, just curious.
I’ll leave the bug test plugin up on git – it might be useful to you down the road.
Since you said feedback welcome 😉 I’ll give this a code review when I get a chance! 🙂
@shanebp in view that you made this bug test for mercime, I tested the plugin in the same installation and it’s working as expected. If BP is activated, I see the notice showing up right under the adminbar/toolbar and right above Dashboard menu. If I deactivate BP, there’s no notice.
EDIT – @djpaul awesome! 🙂
@mercime – thanks for reporting re the bug test plugin.
@djpaul – Blast away! Thanks.
