Topic: bp-templates/bp-legacy/buddypress/activity/index.php line 164

bp-templates/bp-legacy/buddypress/activity/index.php line 164

Mike Witt
Participant

@mike80222

1 month, 2 weeks ago

I’m having some trouble with line 164 of bp-templates/bp-legacy/buddypress/activity/index.php

I’m getting PHP errors about printf() only getting one argument instead of two. It looks to me like the parentheses aren’t right on that line, but honestly I’m having a little bit of trouble parsing it myself. I would be very grateful if someone more knowledgeable could take a look!

Viewing 7 replies - 1 through 7 (of 7 total)

Venutius
Moderator

@venutius

1 month, 2 weeks ago

Hi Mike,

It looks like we have repeated '%s new', and if you remove that is should work.

Are you able to give that a try?

Renato Alves
Moderator

@espellcaste

1 month, 2 weeks ago

Can you share the error and which version of BuddyPress you are using?

Renato Alves
Moderator

@espellcaste

1 month, 2 weeks ago

I see the problem, btw. But just trying to get more data about the BP version.

Mike Witt
Participant

@mike80222

1 month, 2 weeks ago

@venutius, yes that does appear to fix it. I guess I was reading the line wrong. This seems like a simple change. I can certainly patch it temporarily, but is there any chance of getting it fixed in the next release?

@espellcaste, actually I’m running different versions of BP on different sites. But I don’t think that file has change recently (it is legacy after all). The exact error depends on what PHP you’re running. Older PHPs give:

Warning: printf(): Too few arguments ... plugins/buddypress/bp-templates/bp-legacy/buddypress/activity/index.php on line 164

Newer PHPs give:

PHP Fatal error: Uncaught ArgumentCountError: 2 arguments are required, 1 given in ... plugins/buddypress/bp-templates/bp-legacy/buddypress/activity/index.php:164

and then a stack trace.

Renato Alves
Moderator

@espellcaste

1 month, 2 weeks ago

We have a fix in progress: https://buddypress.trac.wordpress.org/ticket/9221

Mike Witt
Participant

@mike80222

1 month, 2 weeks ago

I see it. Thank you!

Renato Alves
Moderator

@espellcaste

1 month, 1 week ago

This was fixed and will be released as part of BuddyPress 14.1. https://buddypress.trac.wordpress.org/milestone/14.1.0

Viewing 7 replies - 1 through 7 (of 7 total)

You must be logged in to reply to this topic.

BuddyPress.org

bp-templates/bp-legacy/buddypress/activity/index.php line 164

Topic Info

BuddyPress.org

bp-templates/bp-legacy/buddypress/activity/index.php line 164

Topic Info

Reply Search