Skip to:
Content
Pages
Categories
Search
Top
Bottom

Is the goal to strip html elements from core code?


  • peterverkooijen
    Participant

    @peterverkooijen

    Is the goal to strip html elements from core code as much as possible?

    Email Notifications looks a mess in my custom theme. It’s apparently generated by bp-xprofile, with table code like this:

    <table>
    <tr>
    <th class="icon"></th>
    <th class="title"></th>
    <th class="yes"></th>
    <th class="no"></th>
    </tr>
    <tr>
    <td></td>
    <td></td>
    <td></td>
    <td></td>
    </tr>...

    Every single element has its own class. This kind of thing breaks very easily.

    In my own theme I try to avoid tables where there are cleaner CSS solutions and minimize classes and ID’s as much as possible.

Viewing 6 replies - 1 through 6 (of 6 total)

  • Boris
    Participant

    @travel-junkie

    Tables for layout purposes should be avoided, but when you have tabular data, then you should use a table. That’s what these tags are for.


    peterverkooijen
    Participant

    @peterverkooijen

    I know, but titles and text are mixed in with the tabular data in a very weird way and without a lot of CSS the result is a mess. If you have to use tables, make sure it looks halfway presentable without any additional CSS. This doesn’t.

    That settings code has been around since 1.0, and we know it needs to be re-written so that page can be templated. Unless someone wants to contribute a patch, we will have to be patient.

    What do you suggest as an alternative? A table here is fine, it’s tabular data.


    peterverkooijen
    Participant

    @peterverkooijen

    A table is probably unavoidable in this case, but would it be possible to structure whatever’s in the core code in a way that doesn’t need any CSS? Or have the table in a template file?

    I don’t think that is tabular data actually. Tabular data is two dimensional. The settings page is a form. But forms have always been a tricky thing from both a semantic and styling point of view.

Viewing 6 replies - 1 through 6 (of 6 total)
  • The topic ‘Is the goal to strip html elements from core code?’ is closed to new replies.
Skip to toolbar