Skip to:
Content
Pages
Categories
Search
Top
Bottom

Newest BP upgrade won't protect feed with Wishlist Member


  • Pete Hudson
    Participant

    @pete-hudson

    Hi guys,

    I just upgraded to the newest version of BP and our Activity Stream page is no longer being protected with Wishlist Member.

    It shows all of the posts and replies, but there’s no options to comment. Before the BP upgrade the AF page would properly re-direct to a “You’re not a member yet page”.

    Is it possible to re-install a previous version of BP? Would the posts that are there now remain?

    Any other suggestions to get this fixed?

    Thanks.

Viewing 15 replies - 1 through 15 (of 15 total)

  • danbp
    Moderator

    @danbp

    Hi, maybe it’s Wishlist Member plugin wich is not ready for BP 2.2 ? Ask on their support for update or how to fix the issue.


    Pete Hudson
    Participant

    @pete-hudson

    WLM tells me to check with you guys. (I hate it when that happens :))

    They say, “WishList member has no true interaction with BuddyPress”… so it looks as though they think it’s not their job to keep up with BP!?

    BuddyPress is the only plugin that keeps WLM from protecting that page.

    Is there an easy way to go back to a previous version of BP on the site? I really don’t want to risk restoring the entire site unless absolutely necessary.

    Thanks for the help.

    We don’t really have sufficient information to help in any great details, but read this thread and if you’re comfortable editing files follow the suggestion on patching a WP file that r-a-y suggests as this may be the reason you’re having issues.
    https://buddypress.org/support/topic/profile-pages-disappeared-after-upgrade-to-2-2/


    Pete Hudson
    Participant

    @pete-hudson

    It would probably be a lot easier for us to just go back to v2.0.3.

    Can anyone tell me where I can download the 2.0.3 zip?

    Thanks.


    Pete Hudson
    Participant

    @pete-hudson

    We’ve confirmed with fresh installs of WP, Wishlist Member and Buddypress that Wishlist Member is not protecting the Buddypress feed since the update of 2.2. 2.1.1 protects the feed just fine.

    WLM support will not help because they say that it’s the code changes in BP’s 2.2 update that is the problem.

    I got a copy of BP 2.1.1, but just don’t know the best way to downgrade from 2.2. Are their any recommended procedures for downgrading? The website is enormous and we’d rather not do a full restore of the entire website unless absolutely necessary.

    Anything else I can do to get this fixed?

    Any help would be appreciated.

    Thanks.


    r-a-y
    Keymaster

    @r-a-y

    Wishlist Member is a premium plugin so we do not have access to debug the issue.

    BuddyPress 2.2.0 did make a change to directory pages that probably caused this issue to occur.

    hnla is correct that you should try patching the one line in a WordPress file to see if that fixes the issue:
    https://buddypress.org/support/topic/version-2-2-0-and-is_page/#post-234315

    Please give that a shot first and report back.

    The other thing I can think of is Wishlist Member is not properly doing redirects on the correct hook. They should use the 'template_redirect' hook at a priority less than 10 (preferably 0). This is just purely speculation at this point without looking at their code.


    Pete Hudson
    Participant

    @pete-hudson

    Thanks for the reply, @r-a-y … we did try the patch and it didn’t work.

    Just to clarify the patch. It should be done on the wp-includes/query.php file and we should change
    “if ( in_array( $page_obj->ID, $page ) ) {”
    with “if ( in_array( (string) $page_obj->ID, $page ) ) {”

    Is that correct?


    Pete Hudson
    Participant

    @pete-hudson

    I see the fix from Hugo:

    For the moment to your is_page checks add && ! bp_is_user()

    Can someone tell me where I would add that code?

    Thanks.

    bp_is_user() returns true for the users profile or account screens so probably won’t work in this instance, you might try is_buddypress() for a more generic check to see if this is a BP page.

    We can’t tell you where to add that though as we simply have no notion of how wishlist is effecting this re-direct, what file, what function etc etc.


    mikelopez
    Participant

    @mikelopez

    Hey guys,

    Did some investigation on the issue and here’s what I found.

    • BP creates a dummy post with ID=0. This throws off WLM.
    • WLM does not make use of template_redirect. Instead it uses the following filters: taxonomy_template, page_template, single_template, category_template, tag_template. This means that WLM’s redirect happens after BP creates the dummy post. So far, hooking to this filters work until the update.

    Does anyone know why BP has to create a dummy post with ID=0? Just thinking that this might also affect other plugins (though I know none at the moment except WLM)

    Thanks.


    mikelopez
    Participant

    @mikelopez

    @hugo

    My apologies, just saw your reply.

    I’ve submitted a patch on https://buddypress.trac.wordpress.org/ticket/6230 and I’m not sure how it will affect r9322

    @r-a-y, I’d love to hear your feedback on said patch.

    Thanks.


    mikelopez
    Participant

    @mikelopez

    Posted a new patch in #6230. Hopefully this settles it.

    Thanks!


    Pete Hudson
    Participant

    @pete-hudson

    The patch is working great for our site. We appreciate everyone’s help. Thank you.

    My apologies for the duplicate thread, @hnla … newbie error. Won’t happen again.

    @pete-hudson No problem, just there’s always the danger of splitting responses across threads and becoming difficult to follow, as it happens the ticket has become perhaps more relevant and necessary so going to suggest we now close this thread and everyone can follow along if they want to on the ticket below

    https://buddypress.trac.wordpress.org/ticket/6230

    @mikelopez 🙂 np, See ray has a response up following on after your patch submission – which you’ve probably seen notification of – so again think we can close this thread and focus on the trac ticket.

Viewing 15 replies - 1 through 15 (of 15 total)
  • The topic ‘Newest BP upgrade won't protect feed with Wishlist Member’ is closed to new replies.
Skip to toolbar