-
Andrea Fercia replied to the topic bp live notification plugin in the forum Third Party Plugins 10 years, 12 months ago
hi @jigesh
yes you’re right also @nacin says in his post “You should insteadthequery directly, as there are no inputs”.
So as long as you don’t have user inputs to sanitize, you’re safe.Btw the latest version 1.0.4 of the plugin already solved this, keeping prepare and correctly passing at least 1 argument on both cases (there are 2 query with…[Read more]
-
Andrea Fercia replied to the topic bp live notification plugin in the forum Third Party Plugins 11 years ago
@jigesh hi
you should never remove $wpdb->prepare, is there for a reason 🙂
The reason why the plugin doesn’t work with wordpress 3.6, 3.7 and later, it’s clearly explained here: https://codex.wordpress.org/Class_Reference/wpdb
see where they wrote:
“Please note: As of 3.5, wpdb::prepare() enforces a minimum of 2 arguments.”
more details…[Read more] -
Andrea Fercia replied to the topic bp live notification plugin in the forum Third Party Plugins 11 years, 3 months ago
@jigesh
sorry I was wrong, I was focused on the admin bar notifications and they work for me, but the “growl style” notifications… no no, they don’t : -
Andrea Fercia replied to the topic bp live notification plugin in the forum Third Party Plugins 11 years, 3 months ago
1.0.3 as I wrote above 🙂 after I modified that line, it’s working for me with WP 3.6 and BP 1.8
-
Andrea Fercia started the topic bp live notification plugin in the forum Third Party Plugins 11 years, 3 months ago
@sbrajesh 🙂
testing bp live notification 1.0.3 plugin, I’m not sure maybe this may vary depending on your PHP error reporting setting, btw it didn’t work for me so I checked the ajax response in Firebug and it started with some html (PHP warning):
<br /><b>Warning</b>: Missing argument 2 for wpdb::prepare() … etc. and then the actual JSON…[Read more]
@afercia
Active 3 weeks, 4 days ago