That might be your opinion, but I going to disagree. Why make a round trip to the DB if you already have the info in your object?
As for your filter, I have checked it out, but decided to go a different route that made a little more sense to me, then having to override more templates.
I already override: single-bp-email.php so in the template itself I just replace the function bp_email_the_salutation() with my own function. I added some logic as needed, and now it works OK.
I say OK because I am still unable to override {{recipient.name}}. I supply bp_send_email() with a WP_USER, and it’s a little frustrating that it does not take the info from the object.
Thanks for the direction though, you have helped me come to a solution that is sufficient for now.
I like it but their are some features missing, like forcing the loading of hidden posts.
Maybe I can take it and build upon that, I dont know.
From the lack of replies I’m assuming their isn’t a straight forward approach at replicating the exact structure of the activity (or even other aspects or the plugin).
I guess it would be something like bp_buffer_template_part( ‘activity/index’, null, false ), maybe something little more customizable with filters and stuff.
