Forum Replies Created
-
If you look at the “View” link output, it is fine–no double comment reference. It is only the Blog title link that has the doubling error.
The error is caused by the Comment ID being passed twice into the sprintf() function. One time from the line above via the $comment_link variable, and the second time directly within the function via ‘#comment-‘ . $comment->comment_ID. Therefore, removing the second reference is the better option.
The way that you are currently doing it may work, but once you upgrade BuddyPress, your changes will be lost. That is why it is important to file bug tickets and get the bugs correct in the core files!
Well, I can’t solve the issue of not being able to post codeblocks. So, here’s another way to display what I’m saying. On line 431, the end of the code starting just after the link tag is this:
$comment_link . ‘#comment-‘ . $comment->comment_ID . ‘”>’ . $comment->post->post_title . ‘‘ );
Remove this from that line:
‘#comment-‘ . $comment->comment_ID .
Make sure to remove that last dot.
Sorry about all the hassle. We’re trying to work out some kinks with the new forum.
Okay, crap. I did post the proper code line but the new forums are not allowing me to post code so it is turning it into a link. Give me a few minutes…
Okay, I did not include the entire code line in my post above. Line 431 (430 for you) should read as follows:
`$comment_link = get_permalink( $comment->comment_post_ID ) . ‘#comment-‘ . $comment_id;
$activity_action = sprintf( __( ‘%1$s commented on the blog post %2$s’, ‘buddypress’ ), bp_core_get_userlink( $user_id ), ‘comment_ID . ‘”>’ . $comment->post->post_title . ‘‘ );`What you need to do is this:
`$comment_link = get_permalink( $comment->comment_post_ID ) . ‘#comment-’ . $comment_id;
$activity_action = sprintf( __( ‘%1$s commented on the blog post %2$s’, ‘buddypress’ ), bp_core_get_userlink( $user_id ), ‘‘ . $comment->post->post_title . ‘‘ );`Keep (or replace) the first line as is. Make the small change to the second line. You are removing this from the end of the string:
` ‘#comment-‘ . $comment->comment_ID .`
Code:testingGlad that worked!
When you’ve created the ticker, would you please post a link to it within this thread. It will help close the circle, so to speak.
Need a link to your forum threads (started and replied to) as well as an option to favorite a thread as before. Both of these were powerful tools for me as a moderator.
The Codex page ( https://codex.buddypress.org/ ) still has the old-style menus–“Forums”, “Developers”, etcetera. On a positive note, it’s the only place where there is a direct link to Trac! I miss the Trac link on the old Forum homepage.
Here’s another Support Forum issue. The old-style forums allowed for a status display for forum threads–I believe via a bbPress plugin. The red and green light indicator was a very useful tool, especially as a forum moderator. You could focus on those threads that still had a red light.
This is an issue with the new BP-Follow plugin. Since it does not yet have a group, I’m posting it here.
When notified that someone is now following you, it would be nice if you were taken to a page that showed just the new person or people following you. Currently, you are taken to your overall listing of followers which does include the new person/people. But as your list grows longer, you have no way of easily determining your new followers. The only way I can do this with ease is by checking my email and looking for any new BP.org sent emails.
Missing the various bbCode options to format forum post content. For instance, when quoting a codeblock, the old ““” symbols do not work anymore. See this post as an example: https://buddypress.org/community/groups/how-to-and-troubleshooting/forum/topic/blog-comment-link-in-activity-stream-broken-has-id-twice/#post-50447
@mercime-
The doubling appears in the browser’s status bar.
It appears that some code in function bp_blogs_record_comment() of bp-blogs.php is causing the issue. In BP v1.2.3, if you look at line 430 and 431, you can see the culprit.
`$comment_link = get_permalink( $comment->comment_post_ID ) . ‘#comment-‘ . $comment_id;
$activity_action = sprintf( __( ‘%1$s commented on the blog post %2$s’, ‘buddypress’ ), bp_core_get_userlink( $user_id ), ‘comment_ID . ‘”>’ . $comment->post->post_title . ‘‘ );`If you look at line 431 near the end, the comment ID is appended to the built string. But, that comment ID has already been included in the variable $comment_link which is built above on line 430. So, you get a doubling of the comment ID.
In the trunk version of BP, the latest working copy version, function bp_blogs_record_comment() is located in a different place and these two code lines appear at 371 and 372.
Please log into Trac and report this as a bug ( create a new ticket ) as it will simply get lost in the support forums. You log into Trac using the same credentials as you use to log into this site.
You can post a link to this thread to provide more details.
In reply to: WordCamp San Francisco – Any BP Peeps Going?I will not be there. Instead, I’ll be attending WordCamp South Bend in my house–of course, I’m the only attendee.
Have fun in SF!
When in your Profile page looking at your follower list, if you reciprocate (follow someone back), the count does not update on the “Follow (n)” tab unless you refresh your browser. Not a serious bug.
Need a way for Support Group threads to be moved to the proper group. For instance, this thread should be moved to the Localization Support Group. https://buddypress.org/community/groups/creating-extending/forum/topic/creating-mo-file/#post-50310
However, there is no current, easy way to do this with the group-based support forum setup.
In reply to: Creating .MO FileThis thread should be moved to the Localization Support Group.
* Website URL and Job Title do not display on profile
* It would be nice for a reply box to be located at the bottom of each forum thread page instead of at the end of the forumNot a problem, just an observation. There is no link to your saved, favorited forum threads. Did these get copied over or is that concept now moot. I use saved threads quite extensively. I save notable support threads so that I can quickly find a forum resource and provide a link to someone who has asked the same or similar question. It beats search.
As r-a-y just pointed out, it is called an external install of bbPress because it is external to BuddyPress. So, there is no secret BP code to make it work. You need to integrate bbPress into WordPress.
Once that is successfully accomplished, you then place a link to your separate, external forums within your BuddyPress site. Now, if you want to make your bbPress site look as if it is part of BP, then you have to theme your bbPress to look like the BuddyPress theme you are using.
That is all that was done on the BP.org site–an external install of bbPress with a theme that matches that of the current site theme so that the two appear integrated. In reality, bbPress is not integrated with BuddyPress at all. The bbPress theme does need a function call or two to make the BP menus work within bbPress, but that is covered in a number of other threads.
Have you seen this thread? Perhaps this will provide more insight on how to integrate bbPress into WordPress: http://www.wpmods.com/integrate-wordpress-bbpress
In reply to: How do I find my tickets/bug reports I submitted?Search for your username by pasting it in the search box in the upper right-hand corner.
https://trac.buddypress.org/search?q=catwebweaver
If you file more Trac tickets in the future, you should check the “Add to Cc” checkbox in the “Change Properties” section. This will email you whenever there is a change to your ticket. This last point assumes that you have set up your email address in Trac preferences.
In reply to: bp_setup_nav not firingI just added a patch to Trac that will fix this issue and more like it: https://trac.buddypress.org/ticket/2325
In reply to: How do you access SVN?I also have briefly tried out Versions, but I just liked the Cornerstone client a little better.
In reply to: How do you access SVN?Which OS do you run? I’m on OS X and have just (as in yesterday) switched from using the archaic Xcode SVN tools to a very cool SVN client that actually works amazingly well. http://www.zennaware.com/cornerstone/
@viau5-
If you’ve discovered the plugin(s) that was causing your issue, please list it here so that if others have the same issue, it may help shed some light on their problem.