Forum Replies Created
-
In reply to: Themes broken after 1.5.1 upgrade
Child themes appear to be working fine for me. There should have been no changes in 1.5.1 that affect how child themes work.
I try to go to any BP theme, it’s simply broken and won’t work
Can you be more specific? Does “go to” mean “activate”? In what sense won’t it work? Do you get white screens? Do you only get WP errors, with the theme reverting to a default? What happens when you activate bp-default itself?
In reply to: Language files deleted after upgrading #2That *is* how it’s supposed to work. When you upgrade a WordPress plugin like BuddyPress, everything in the plugin folder is deleted and overwritten by the new content.
Language files should be stored in wp-content/languages (if you don’t have that directory, create it), where they will not be overwritten during upgrades.
In reply to: BuddyPress 1.5 user fullname save/show errorsThanks for the details, @rossagrant. I’ve created a Trac ticket for the dev team to look into it. https://buddypress.trac.wordpress.org/ticket/3683
In reply to: Couple ThoughtsNo, I meant that you should use it for debugging, somewhere where $activities_template was defined.
Try this.
`function bbg_remove_self_replies( $has_activities ) {
global $activities_template;foreach( $activities_template->activities as $activity_key => $activity ) {
//var_dump( $activity->type );
if ( ‘activity_comment’ == $activity->type ) {
// Get the parent item
$parent_id = $activity->item_id;if ( empty( $activities_template->activity_parents[$parent_id] ) ) {
return $has_activities;
} else {
$parent = $activities_template->activity_parents[$parent_id];
}// Is the activity author the same as the parent author? If so, remove
if ( $parent->user_id == $activity->user_id ) {
unset( $activities_template->activities[$activity_key] );$activities_template->activity_count–;
$activities_template->total_activity_count–;
}
}
}// Reset indexes
$activities_template->activities = array_values( $activities_template->activities );return $has_activities;
}
add_filter( ‘bp_has_activities’, ‘bbg_remove_self_replies’ );function bbg_dont_remove_self_replies_on_ajax() {
remove_filter( ‘bp_has_activities’, ‘bbg_remove_self_replies’ );
}
add_action( ‘wp_ajax_new_activity_comment’, ‘bbg_dont_remove_self_replies_on_ajax’, 1 );`I agree. That’s why I said it was a good idea for an enhancement ticket.
In reply to: Couple ThoughtsCan’t reproduce this on my setup. Strange. Probably has something to do with a total count in $activities_template. You might try var_dump( $activities_template ) inside of that function I gave you to see if there’s anything obvious to change.
In reply to: when setting ” register ” page as the homepageIf you have WP_DEBUG (underscore, not hyphen) set to true, there will be a line in your wp-config.php that says
`define( ‘WP_DEBUG’, true );`Then, you will see warning messages at the top of the screen when something goes wrong.
If you don’t have a page associated with the Activity component, I don’t think activity permalinks will work (though that needs checking).
At the moment, there is no simple way to remove the message. (Though you could remove it from the $bp global at admin_init if it bothered you that much.) It’s a good idea for an enhancement ticket, though http://trac.buddypress.org
In reply to: Couple Thoughts@alanchrishughes I can’t reproduce your exact problem (I don’t see them at the bottom of the screen) though I was able to create at least some kind of error when posting new activity replies via AJAX. Try adding the following to your bp-custom.php in addition to the other stuff:
`function bbg_dont_remove_self_replies_on_ajax() {
remove_filter( ‘bp_has_activities’, ‘bbg_remove_self_replies’ );
}
add_action( ‘wp_ajax_new_activity_comment’, ‘bbg_dont_remove_self_replies_on_ajax’, 1 );`As I said in the ticket, I don’t think that @alanchrishughes is making a bad suggestion. Just that it’s probably not wise to implement in BP today, without making several further modifications. In the meantime, anyone is welcome to take the code suggested so far and turn it into a proof-of-concept plugin.
In reply to: when setting ” register ” page as the homepageThe latest BP trunk is working fine for me on the latest WP trunk. Have you activated the plugin on a single blog first? If so, you might try deactivating it there first. If this is a test install, you might also try setting WP_DEBUG to true in your wp-config.php file, to see if any errors pop up during the activation process.
In reply to: Couple ThoughtsThe code I provided works fine on my BP 1.5 installations. What version of BP are you using?
IMO, @alanchrishughes suggestion is only advisable if we also implement something that pushes an activity item to the top of the activity stream when it has been commented on. Otherwise new activity comments will get buried in the pile. This is not a trivial thing to do, however; I’m not sure it can be easily done with our current activity data schema. A plugin could be written for the purpose right now, but it would probably have to do some funny business with BP’s MySQL queries.
In reply to: when setting ” register ” page as the homepageFYI, this filter has been added, and will be in 1.5.1. See https://buddypress.trac.wordpress.org/changeset/5237
In reply to: BuddyPress 1.5 user fullname save/show errors> the URL I provided is more than adequate proof that this problem occurred
It’s evidence that a problem has occurred, but not that data has been deleted from your database. There is nothing in the BP 1.5 database upgrade routine that should change display names. Again, I’m guessing that the problem lies in the logic that determines what counts as the “display name”; we don’t just pull something out of a certain field in the database, but instead use a number of settings to determine which content should be shown in the ‘display name’ areas.
> obviously something went amiss during the database upgrade for both Juan and myself
My guess (and it’s only a guess, as I’m not able to reproduce) is that it’s arising not as a result of the database upgrade, but as a result of a particular combination of local parameters that we haven’t nailed down yet. For instance, are either of you using BP_ENABLE_USERNAME_COMPATIBILITY_MODE?
> At no point did I receive an error or anything indication the 1.5 upgrade wizard did not complete successfully.
Can you say more about this? In what sense did it not complete?
No time wasted – thanks for your help and patience debugging
https://buddypress.trac.wordpress.org/ticket/3639No time wasted – thanks for your help and patience debugging
https://buddypress.trac.wordpress.org/ticket/3639In reply to: BP_USE_WP_ADMIN_BAR does not workWhat @zacechola said. Make sure that you put the code *above* the “That’s all” line.
In reply to: BP_USE_WP_ADMIN_BAR does not workWhat @zacechola said. Make sure that you put the code *above* the “That’s all” line.
I just tested and it mostly works. I did realize that you are correct that the reported URLs are incorrect, ie that it says
`Automatically create a page at: http://domain.com/members/`
instead of
`Automatically create a page at: http://site2.domain.com/members/`However, when the pages are actually created, they are created properly on the secondary site. The BP installation works correctly on http://site2.domain.com when finished.
I just tested and it mostly works. I did realize that you are correct that the reported URLs are incorrect, ie that it says
`Automatically create a page at: http://domain.com/members/`
instead of
`Automatically create a page at: http://site2.domain.com/members/`However, when the pages are actually created, they are created properly on the secondary site. The BP installation works correctly on http://site2.domain.com when finished.
An update. I ran through a few tests this morning, with
`define( ‘BP_ROOT_BLOG’, 2 );`I tested on two kinds of MS installations: one with subdomains and one with subdirectories. In each case, I installed BP 1.2.10, then upgraded to 1.5. In each case, everything worked fine. The pages in the wizard dropdown were from blog 2, *not* blog 1. This is as expected; see https://buddypress.trac.wordpress.org/browser/tags/1.5/bp-core/admin/bp-core-admin.php#L535
For now, I have closed https://buddypress.trac.wordpress.org/ticket/3602. If anyone can give steps to reproduce (perhaps I’ve misunderstood something about the process), please do so on that ticket.
In reply to: BuddyPress 1.5 user fullname save/show errors> ALL Full Names were suddenly replaced by the username field data, seemingly deleting full name data
What’s your evidence for that? It would be *very* surprising if it were true. Probably the correct diagnosis is that some logic was causing the username to be displayed instead of the display name.
Do you have the Extended Profiles component enabled?
In reply to: idea to improve theme integration processInteresting idea. Patches welcome
In reply to: BuddyPress 1.5 user fullname save/show errorsI can’t reproduce it on my installations. The changeset that you point to as having fixed the issue has not been rolled back, so there’s no obvious reason why it should have stopped working.
Just to be clear:
– I changed the name of profile field #1 to something other than ‘Name’
– I went to Edit Profile on the front end, made a change to the field, and saved
– Everything saved correctly. I got no errors, and the name is properly saved.In reply to: BuddyPress 1.5 user fullname save/show errorsCan somebody sum up the problem in a sentence or two? I’m confused by this thread.
In reply to: 1.5 and “Pages”The question about theming/shortcodes is not really related to the issue of WP pages in BP 1.5. BP 1.5 uses WP pages in order to integrate into WP menus, to make it easier to change permalinks, etc. There is no integration with the page templates in your WP theme.
In the future, there will be better integration with a wider variety of WordPress themes. Test out the new bbPress to get a sense of what it might look like. It might not involve shortcodes, but it will be something equally easy. In the meantime, the Template Pack is your best bet.
