[Marj Wyatt]

Oh, thanks @henrywright. I do endeavor to be thorough and I would like to see a solution or, at least a direction.

[Marj Wyatt]

Genesis Framework is now at v2.0.2

[Marj Wyatt]

Nope … sending @webauthor off to start all over isn’t an answer. That site has been updated to WP 3.8/BuddyPress 1.9.1 and the problem still exists.

[Marj Wyatt]

Thanks. That worked!

So I’m clear on what fixed it … the “999” at the end prioritizes the addition of the action? I’ve looked high and low for an explanation of this number. Since I put bp-custom.php in mu-plugins, it probably was executing prior to crating the nav items.

As long as I have your attention, have you got a link to a tutorial on how to make the dropdown item labels on the wp-admin bar match those in the profile page?

Thanks again for the fix and thanks, in advance for answering the subsequent questions.

[Marj Wyatt]

I keep thinking about this issue, mostly because it “bugs me” to change core files in a major plugin like BuddyPress. I opened a ticket at the recommended location and I can find no record of it so it has most likely been closed.

My question for the group here is this. Would the above modification applied to bp-custom.php overried the core template? If so, can someone tell me what to unhook and re-hook to make that work?

Thanks, in advance, for any replies that are helpful.

[Marj Wyatt]

Fair enough, and I don’t disagree that there may be more robust requirements. I tend to “resist” the use of plugins where code will do the trick through. For Woocommerce, all their shortcodes could be dropped into the appropriate BP template and/or your child theme’s code.

My development is different. We are letting the Wishlist Member plugin manage registrations.

[Marj Wyatt]

@Norm … Thank you! Very helpful reference link and precisely what I was looking for. I actually added my code to bp-custom.php instead of the theme’s functions file.

[Marj Wyatt]

I read this thread with some interest and see that there are recommendations to use a Premium Plugin to accomplish this.

I have a development in progress. I have developed a custom child theme using the Genesis Framework. I’ve successfully integrated buddypress with this theme. I am using X-profiles and registration is handled and managed by Wishlist Member. I have since determined that WooCommerce is the best tool for my client and the software slid right into the mix with no problems at all.

The above mentioned premium plugin does not appear to function with X-Profiles, and X-Profiles was the method that I used to secure details of the profile at the member’s choice.

What I’m wondering is maybe something I should be asking at Woo but why haven’t any of you tried the “simple” solution of using the wordpress do_shortcode function to add the shortcodes to the templates where you want that code to show? I added the [woocommerce_my_account] shortcode to the general.php template which was copied into the child theme folder (bp-legacy template) and it works just fine. Am I missing something?

[Marj Wyatt]

Clarification:

This template file is found in the base BuddyPress plugin folder under the bp-members folder.

[Marj Wyatt]

I just upgraded a BuddyPress site to v1.8.1 and did a cursory check to see if this search issue had been resolved yet. It has not, which sort of mystifies me because the problem is more than two years old and requires a modification to BuddyPress core code.

Here is the segment of code that I’ve changed (again) in the bp-members-template.php script found in the plugin’s “core” folder:

 // Pass a filter if ?s= is set.
  // ref link: https://buddypress.org/support/topic/wp-search-results-page-kills-bp-member-widgets/
  // ref link: http://buddydev.com/support/forums/topic/wp-search-results-page-kills-bp-member-widgets/

 // Original code on lines 313-318 remarked out in favor of Modified code on lines 320-322
	//if ( is_null( $search_terms ) ) {
	//	if ( !empty( $_REQUEST['s'] ) )
	//		$search_terms = $_REQUEST['s'];
	//	else
	//		$search_terms = false;
	//}

    /******* Modified search code *******/
    if ( !is_search()&&isset( $_REQUEST['s'] ) && !empty( $_REQUEST['s'] ) )
        $search_terms = $_REQUEST['s'];
    /******* End Modified Search Code *******/

Has anyone on the core development team considered making this into a “hook” that we can remove and rewrite for our child themes?

[Marj Wyatt]

@meg@info … thanks for the suggestion and the ref over to the Select2 page.

[Marj Wyatt]

Ok. I went back to the BP Template pack on my custom Genesis theme and disabled this:
Disable BP Template Pack JS / AJAX

With that disabled, everything works the way it should work, even with Wishlist Member installed. I no longer need to panic about having to start all over again. This client is very particular about the styling at the site.

The BP Compatibility Plugin has not been updated for over a year. Could it need an update or is this a conflict between it and the Genesis Framework?

In any case, I’ve gotten my problem solved and if my trials and tribulations are of assistance to anyone else doing something similar, then I’m glad to be of assistance.

[Marj Wyatt]

Correction
this:
“The requests.php template looks to be is not loaded with code having only 60 lines or so. ”

Should say this:
“The requests.php template is not loaded with code having only 60 lines or so.”

[Marj Wyatt]

I created a new instance on local Xampp. Systematically, I disabled plugins and tested functionality. I was able to make it work with all my plugins activated, including Wishlist, but only with the Buddypress Default Theme activated.

That’s a “nice” discovery except for the fact that weeks have gone into the development of the custom theme on the Genesis framework. I chose that framework because of the abundance of experience that I have with it. I admire all the work that has gone into creating as elegant a plugin as Buddypress but it should not be imperative to do development on the Buddypress theme base. Genesis is pretty popular…

The requests.php template looks to be is not loaded with code having only 60 lines or so. This section of code in the BP Compatibility Pack seems to be what handles the actual list of friend requests:

<div class="action">
     <a class="button accept" href="<?php bp_friend_accept_request_link(); ?>"><?php _e( 'Accept', 'buddypress' ); ?></a> &nbsp;
     <a class="button reject" href="<?php bp_friend_reject_request_link(); ?>"><?php _e( 'Reject', 'buddypress' ); ?></a>

     <?php do_action( 'bp_friend_requests_item_action' ); ?>
</div>

The first two functions are links. I’m thinking it has to do with the action performed and I don’t know where to find that code. Is this something *we* should be looking at?

[Marj Wyatt]

I should clarify. All that comes included in the Genesis Connect plugin is STYLE SHEET code for their various plugin and play templates. What I’m describing is a FUNCTIONAL issue having nothing to do with CSS.

[Marj Wyatt]

The Genesis version is v1.9.2. The Genesis Connect plugin is free now. I did have it installed before but it did nothing so I went to the BP Compatibility pack instead. The Genesis Connect plug only seems to auto-styles a set of Genesis Templates. This is not one of their templates. It is a custom theme based on their framework and this set does not include the sample child that I began with.

That being said, I went through the hoops of disabling and removing the bp template compatibility pack and activating the Genesis Connect plugin. Aside from styling issues, there wasn’t even a button available to request friendship under those conditions. I’ve gone back to the BP Compatibility Pack. Genesis Plugins only work with standard Genesis offerings and the support in their forum will be of no assistance to me on a custom theme.

I activated TwentyTwelve theme. I cannot cancel the friendship request nor can I accept it.

From where I am sitting, this does not appear to be a missing plugin issue nor a Genesis issue. It is a core Buddypress problem that has been reported and those threads were closed with no real resolution.

The BP Compatibility pack is there for all other themes. My theme is only based on the Genesis Framework so it falls into that category.

Any more ideas?

[Marj Wyatt]

@shanbp … thanks for the link reference. I’m adept at WordPress customization but the missing sidebar was a puzzle.

[Marj Wyatt]

I went back to the original answer found here
http://buddydev.com/support/forums/topic/wp-search-results-page-kills-bp-member-widgets/

At this time, I do have the code working so that a wordpress search doesn’t wipe out buddypress member widgets and all the other functionality works on the members directory page too.

Here was my solution:
In bp-members-template.php, I remarked out lines 305-311 and replaced them with

if ( !is_search()&&isset( $_REQUEST['s'] ) && !empty( $_REQUEST['s'] ) )
        $search_terms = $_REQUEST['s'];

So I’m back to the question/concern of 4 or so hours ago. I don’t feel that modifying core code is ever a good idea. Has anyone come up with a better way to solve this that makes it more durable when plugin updates are applied?

[Marj Wyatt]

I guess I spoke to soon. That change breaks the functionality of the dropdown filter. I guess I could take the dropdown out of the theme entirely but I thought it would be useful…

[Marj Wyatt]

Thanks for this post! I was head-banging on this very issue and, up until the time I realized that the problem was only with the member widgets on search pages last night, I didn’t even know how to begin to troubleshoot it or what to search for.

As @leemour wrote in his reply, the code on line 309 of bp-members-template.php had to be modified at line 309. To get it to work, I replaced:

	// Pass a filter if ?s= is set.
	if ( is_null( $search_terms ) ) {
		if ( !empty( $_REQUEST['s'] ) )
			$search_terms = $_REQUEST['s'];
		else
			$search_terms = false;
            	}

With:

if ( !is_search() && isset( $_REQUEST ) && !empty( $_REQUEST ) )
        $search_terms = $_REQUEST;

I’m not completely comfortable altering “core code” though. Is this a Buddypress bug? Shouldn’t there be a better solution than hacking core code?

[Marj Wyatt]

This thread is quite interesting to me, and I do appreciate everyone’s thoughtful posts.

I may sound silly asking some of these questions so I would like to beg your forgiveness in advance,

1) Is WPMU still a base requirement for BuddyPress?
2) When a membership site is using BuddyPress, WordPress or WPMU (if required), 1ShoppingCart, and Wishlist Member, is the login seamless?

I guess further questions are relatd to the answers to these. Thanks in advance for your responses!