Topic: Let’s prepare the BuddyPress 12.0.0 next major release

Let’s prepare the BuddyPress 12.0.0 next major release

Mathieu Viet
Moderator

@imath

9 months ago

Hi everyone,

As explained into the following post, this forum topic is the place where you can ask us questions about the next BuddyPress 12.0.0 major release.

BP Classic 1.2.0

We’ll try to give you answers as soon as we can.

You can get latest 12.0.0 pre-version from there 👇

BuddyPress 12.0.0 Release Candidate

Viewing 25 replies - 26 through 50 (of 83 total)

← 1 2 3 4 →

Mike Witt
Participant

@mike80222

7 months, 1 week ago

I’ve finally gotten a test site up to try out 12.0.0-beta2. It looks (so far) like I can run without BP Classic. I am seeing a lot of Deprecated notices for things like bp_core_get_user_domain and bp_get_group_permalink, but maybe those just haven’t been cleaned up yet.

I do see something else, which is not new in BP 12, but I hope it’s OK if I just mention it here. It seems to be an interaction between BP and bbPress. When my site is set to UTC the BP notifications for bbP posts have the right times. But if, for example, I set my WordPress time to UTC+4, then the times of mention notifications look right, but the times of reply notifications are four hours off.

I don’t *think* there’s anything weird on my site that would cause this.

AWOL
Participant

@awol

7 months, 1 week ago

@mike80222, Thanks, I will probably do that once I have adapted anything I need to for the new BP. Changing from the default theme to Nouveau is probably presenting more challenges than BP 12 is though, but it is difficult to know what might be causing issues as I test it though – my main theme, my own php functions, Nouveau or new BP!! Or another plugin of course.

AWOL
Participant

@awol

7 months, 1 week ago

Hi @imath, Thanks, I will have to see what is causing it to be missing; time for a trawl through my plugins again! If I find a culprit I’ll report it here and to the author.

david00116
Participant

@david00116

6 months, 4 weeks ago

Secondly, I found that it wasn’t possible to add a main menu link for the currently logged-in user that remains visible at all times. Although I created a custom link, it only appeared in the menu when viewing specific sections (such as Profile, Activity, etc).

Thirdly, I encountered difficulties in adding a sidebar to any of the Buddypress pages, despite my default Blocksy setting for each page to have one. Upon investigation, I discovered that in the Customizer, Buddypress pages were being counted as Blog Posts. Intuitively, I would have expected this setting to be configured in the Buddypress-specific sections. As it stands, without extensive CSS modifications, this means Blog Pages and Buddypress pages will always have to share the same layout.

I’m curious if you’re considering incorporating enhancements or additional features in the Customizer at some point. In my experience, I’ve needed to make a significant number of CSS adjustments to align Buddypress with my desired color scheme and preferences in previous versions. It would be immensely helpful if at least some of this could be achieved through Customizer settings or a dedicated settings page within the plugin. Historically, Buddypress hasn’t adhered to my theme defaults, but I’m uncertain if this is specific to the theme I use or if it’s a widespread experience.

AWOL
Participant

@awol

6 months, 4 weeks ago

Hi @david00116,
Can I assume that by quoting my earlier post that you are experiencing the same issues and agreeing with my point/question about the Customizer?
As regards the main menu link for Profile etc, this was solved for me by deactivating the BP Classic plugin. But the other points are still valid.

AWOL
Participant

@awol

6 months, 4 weeks ago

Hi @imath,
Further to my post on this thread (https://buddypress.org/support/topic/lets-prepare-the-buddypress-12-0-0-next-major-release/#post-331256) regarding the Reply button, I have tested and done all the troubleshooting I can, and there is nothing that brings the Reply link/button on comments back. From everything I have done I have eliminated all plugins, custom functions and css as being the cause, so this is a fairly major problem for me, that does not occur on the non-beta Buddypress. Unfortunately if I try to even preview another theme I get a critical error, so I can’t eliminate Blocksy as the cause; however on my live site the Reply link is there whether it is the Legacy or Nouveau theme, so something appears to be conflicting between Blocksy and the beta version of BP, given that your test with Twenty Twenty Two did not have this issue. Can you or someone talk to Blocksy and try to work out the various issues that exist between that theme and BP please? I have done what I can and really need some assistance now.

valuser
Participant

@valuser

6 months, 3 weeks ago

Some feedback on BP 12.0.0-beta2 though please treat with caution!

Local Install – Local, php 8.2.10 – MySQL 8.0.16 – WP 6.3.1 – BP Version 12.0.0-beta2

a lot of plugins!!

Buddyx theme NouveaU template only or Thaim theme i use Legacy template.

Not a coder or developer.

Just a general interest in BuddyPress
Not in any way dependent. a hobby!

1) Bottom line – With BP Classic all appears good.

2) When BP Classic is not active plugins like buddydrive, buddypress-group-calendar, buddypress-group-email-subscription and bp-idea-stream no longer appear in Group Navigation.

However Q&A from Anspress still appears in Group Nav & works when BP Classic is not active

https://imgur.com/P6gKRWq no-bp classic not active

https://imgur.com/b8yu3fi yes-bp classic active

3) The plugins (with exception of BuddyPress Group Calendar) do appear in the Group Nav —> Manage. (see https://imgur.com/DCYvcOT)

4) Also another (non-buddypress plugin) that interests me a reasonably popular (codecanyon) directory plugin ‘Sabai’ – well, essentially all its data vanishes when bp-attachments is active in BP 12.0.0-beta2 without BP Classic. The message is “it seems we can’t find what you’re looking for. Perhaps searching can help.”

5) If bp-attachments is not active (say replaced with mediapress or with mediatheque) in BP 12.0.0-beta2 the Sabai data is unaffected but the non updated plugins (mentioned in 2 above) are ineffective

6) In wp-admin/admin.php?page=bp-settings options–attachments the last two choices (see pic https://imgur.com/00yZYna) if clicked to include the choice is NOT saved. Also buddydrive appears in p-admin/admin.php?page=bp-settings options

However everything INCLUDING bp-attachments appears to work safely & pristine with BP Classic active

bp-attachments not used with legacy template

Many Thanks for all the work on BuddyPress.

Mathieu Viet
Moderator

@imath

6 months, 3 weeks ago

Hi @valuser

Thanks a lot for your feedback. I just discovered it now because it was hidden into the moderating queue (probably due to all the links you shared).

It’s very important news you confirmed everything is safe when BP Classic is activated. Thanks a billion for this information.

BP Attachments has been updated to 1.2.0, as 1.1.0 was causing issues with regular pages, that probably explains the problem you got with Sabai. It should be fine now.

I feel a bit bad about the fact BuddyDrive is not ready for 12.0.0 (as I was the creator of this plugin). I’ll try to find the time to suggest a PR to the plugin maintainer.

I’ll have a look at BP Idea Stream asap!

Thanks again for your help 😍

Mathieu Viet
Moderator

@imath

6 months, 3 weeks ago

@awol I’m not sure whether david00116 is a spammer or not. One of their messages was clearly a spam.

I’ll test Blocksy again with BP 12.0 to see if I can reproduce the activity comment/reply issue.

Mathieu Viet
Moderator

@imath

6 months, 3 weeks ago

Hi @awol

I just tested Blocksy and BP 12.0.0-beta3. About activity comments/replies, it behaves as expected:

I’ve also checked WP Nav Menus (Member links & directory links). It also behaves as expected.

If you still have issues, you’ll need to deactivate all plugins but BuddyPress, then reactivate plugins one by one to identify the one causing the issue.

AWOL
Participant

@awol

6 months, 3 weeks ago

Hi @imath,
I have written an extensive reply but it must be stuck in moderation as it includes several image links. Suffice to say after deactivating everything and with a virtually vanilla installation, the reply button still is not there.

AWOL
Participant

@awol

6 months, 3 weeks ago

Unrelated to my earlier posts, I was doing some debugging on another plugin, and was getting a lot of warnings and deprecated messages regarding a couple of BP functions, most of which I have been able to track down in my code; however one in particular persists, as follows;
PHP Deprecated: Function bp_core_get_user_domain is <strong>deprecated</strong> since version 12.0.0! Use bp_members_get_user_url() instead
It would be useful for me, and I am sure others, if the full list of deprecated functions is made available, as well as anything that uses them, because several of the ones I was using were not the exact function appearing in the debug log, but changing them (because I thought they might be the ones triggering the warning or deprecated message) did cut the number of messages in the debug log. I still don’t know for certain though. It would also be useful to have a complete list of available functions and what they do, particularly those that would be commonly used, all in one place – if this is available already, I can’t find it, so apologies if that is the case. Previous changes, inconsistencies and the sheer amount of old information that is still out there, including these forums, makes it extremely difficult to find the right function in the right circumstance, which I assumed, perhaps wrongly, was a part of why the new Buddypress is needed.

Mathieu Viet
Moderator

@imath

6 months, 2 weeks ago

Hi @awol,

Here’s the full list of 12.0.0 deprecated functions: https://buddypress.trac.wordpress.org/browser/trunk/src/bp-core/deprecated/12.0.php

You’ll see that if the BP Classic Add-on is active, a lot of these won’t show as this plugin is bringing backwards compatibility for plugins which are not ready yet for 12.0.0. If you’re getting the deprecated notice, then it means you need BP Classic to carry on using the plugin which is causing the notice.

punkaun
Participant

@punkaun

6 months, 2 weeks ago

Regarding the change from Pages to URLs, my current configuration of BP 11.3.1 has the directory pages located as children of another page. Therefore, the slugs read like follows:

somepage/activity/
somepage/members/
somepage/groups/

When I try to edit these slugs in 12.0.0, my changes don’t stick. Will it be possible to maintain my current URLs in 12.0.0?

punkaun
Participant

@punkaun

6 months, 2 weeks ago

Also, even after using BP Tools to restore the slugs to their default values, I’m unable to view the directory pages in staging. I’m using WP Staging Pro, which means that the Activity Directory page should be visibile on my website at https://gaelquest.com/stg/activity

However, the directory page is not being found and instead BP is treating it as if it were a blog post.

Sorry! I feel like I’m missing something really obvious.

Mathieu Viet
Moderator

@imath

6 months, 2 weeks ago

Hi @punkaun

Thanks a lot for your 2 messages. I’ll see if we can take in charge this URL schema in 12.0.0.

The second one is a bug we do need to tackle.

Could you do some additional testing?
– Come back to BuddyPress 11.3.1
– Make sure the directory pages are children of one of your WordPress pages.
– Activate BP Classic (BP Classic is a backwards compatibility plugin that neutralizes the BP Rewrites API to use our legacy API instead)
– Upgrade to 12.0.0-beta3

Is this preserving your URL set up ?

AWOL
Participant

@awol

6 months, 2 weeks ago

Hi @imath,
Thanks for your response – I’m sure you are very busy. The problem I have is that the BP Classic plugin causes a problem with the menu, as noted earlier in this thread – https://buddypress.org/support/topic/lets-prepare-the-buddypress-12-0-0-next-major-release/#post-331198 – and acknowledged by you – https://buddypress.org/support/topic/lets-prepare-the-buddypress-12-0-0-next-major-release/#post-331239 – but I haven’t seen any more mention of it. It isn’t really an issue until those deprecated functions stop working, but it is an extremely tedious task to trace where they are being used if it is a plugin as the debug log gives no clues at all except when the function was used. I will have a look at the list (thank you) to see if that is any help. If the issue with the BP Classic plugin can be looked at and fixed in the meantime I would be grateful – this could be another Blocksy issue so again, if you can speak to them it would be most appreciated, as they don’t want me to tell them until the non-beta version of BP is released, whereas you will have a clear idea what is and isn’t going to be in the final version and can raise it with them to look at – they may highlight something you are not aware of that needs doing before final release that might be something that affects many other themes. Can you also let me know what has happened to my post regarding the comment reply link? It still hasn’t appeared.

AWOL
Participant

@awol

6 months, 2 weeks ago

Hi @imath,
Even though I have already done this, I have done it again. With all plugins deactivated apart from Buddypress, the reply button still does not display. I have also wiped the style.css of my child theme, removed all functions from the child theme functions.php, renamed bp-custom so it is not in play, and removed any buddypress files I had in my child theme – still no reply button. I have removed everything extraneous. I have switched to the parent Blocksy theme and it still isn’t there. When I examine the html in the inspector, the code just isn’t there to generate the reply button. Attached are two images showing this while in my child theme and everything else turned off apart from Buddypress. But it is the same with just Blocksy parent theme

I have also tried with the 2023 theme, attachments below.

This is all with the beta 3 that I upgraded yesterday, on the latest Firefox on a Mac running the latest OS. Just to make sure it was neither browser or device, I also looked on my Android phone using the Opera browser, and that screenshot is attached below.

So, please, what do I do now?

punkaun
Participant

@punkaun

6 months, 2 weeks ago

@imath Using BP Classic with 12.0.0, the child URL paths are supported.

Mathieu Viet
Moderator

@imath

6 months, 2 weeks ago

@punkaun Thanks a lot for your feedback and for confirming BP Classic is a possible plan B 😍.

@awol I’ve just tested there are no issues for me with BP 12 + BP Classic and Menu Administration Screen or front-end generated menus. When BP 12.0 performs its upgrade task, it transforms regular pages into custom post types. So I feel if you create a menu with these post types, you probably need to remove first the menu item and add it again once BP Classic is active, have you tried this ?

PS: I’d like to have time to contact every possible Theme authors, unfortunately I cannot take this road, sorry.

AWOL
Participant

@awol

6 months, 2 weeks ago

Hi @imath,
I have set up a second staging site to test because of the issues I was having with my first one, to see if any are replicated; the good news is that the Reply button on activity comments is visible on this new stage, so it must be some weird anomaly with the first one which I doubt I will ever be able to figure out, much like my missing post that showed in detail the problem there.

However there is one issue that is still apparent, which is that, in Blocksy I have it set so that the main site menu highlights whichever page you are currently on (a fairly common feature on most sites), and if you are on a page that is a dropdown menu item, it highlights the parent menu item that it drops down from, as well as itself when the dropdown is visible. Unfortunately it seems that the new BP doesn’t play well with this setup (as I tried to explain earlier in this thread), so I had parent menu links to Activity (with Members and Groups as child menu items) and Profile (with several other child menu items such as Friends etc); when I visit the Profile page, the Profile parent item is not highlighted, but Activity is, and when I visit a child menu item of profile, both Profile and Activity are highlighted. If I move the Members child item to be a parent item, this is the one highlighted instead of Activity.
I looked more deeply, and discovered that in my setup, Activity, Members and Groups all have distinct page id numbers when you examine the html body class, while all pages connected to the Profile and associated links have the same page id as Members (logical as they are sub pages of Members in the BP urls), and individual groups have the same page id as Groups etc. Is there any way to have Profile separated from Members so that it has its own page id and distinct url? I think this is probably where my menu issue stems from, and I would assume this would be the case for others as well. There doesn’t seem to be any way (yet?) to create my own Profile pages using blocks which might be another way around this, or even a custom Members page (the blocks currently available don’t have an option to show an alphabetical or sortable list/grid). I’m sure I’m not alone in wanting a main menu link to the registered users individual pages, a dashboard, and having the menu show them where they are.

AWOL
Participant

@awol

6 months, 2 weeks ago

@imath, I edited the above post but it didn’t stick. I tried with BP Classic active, which partially solved the issue – Members (or Activity) are no longer highlighted when on a Profile or child of it, but Profile does not highlight unless you are on a child of it. Also you lose the settings in the admin for BP when Classic is active, so not really a solution.

AWOL
Participant

@awol

6 months, 2 weeks ago

@imath, another problem with BP Classic active is that the Profile parent menu item and children disappear from the menu when you move to any other parent menu item. I did raise this before but this is now happening on the second staging site as well.

Mathieu Viet
Moderator

@imath

6 months, 1 week ago

Hi @awol

About the reply button, I believe it’s due to your discussions settings. You need to allow threaded comments.

About the issue with BP Classic and missing Dynamic Member nav items when not viewing a member, we’ve discussed about it during our latest dev chat, and I was able to replicate the issue. I’ll fix it soon.

AWOL
Participant

@awol

6 months ago

@imath,
Thank you for your response and apologies for my tardiness – I had no idea that the Discussion settings had any impact on Buddypress Activity but you are correct, this was what was causing the issue. Is this documented anywhere in the Buddypress docs/codex? I made the mistake of assuming that Buddypress activity was a separate entity to the blog posts and comments but obviously it isn’t, so do all the other Discussion settings impact it as well? I can obviously test myself but if there is any resource on this that would be very useful.

Regarding the BP Classic issue, thank you, although I have now made a significant design change and workaround so I don’t think it will impact me any more, and that also applies to the issue I reported with the nav menu highlighting, although that will impact others. Basically I have created a custom Members directory page on a WP page so that when that is a sub menu item of Activity any visit to a Profile page does not highlight the Activity menu item as was happening with the standard Member directory. Also from my testing I have not encountered any issues that will require BP Classic to be activated, and if I do I will probably devise another workaround.

Good luck with preparing to launch the release of BP 12!