[@johnjamesjacoby Keymaster 16 years, 4 months ago]

@nuprn1 Most of my plugins will have that issue, so they will need an update for 1.2.5 also. :sigh: haha

@erich73 Fixed thanks

@hnla @jeffsayre almost had me hunting giraffes. That would have been bad because they’re too cute to hunt.

[@johnjamesjacoby Keymaster 16 years, 4 months ago]

Very kind of you to say. And you’re very welcome. Stay as long as you’d like.

Cheers

[@johnjamesjacoby Keymaster 16 years, 4 months ago]

Can’t duplicate it myself, but let’s get some feedback.

[@johnjamesjacoby Keymaster 16 years, 4 months ago]

That’s coming next, or have at it yourself if you’d like. First I need to get some coffee.

[@johnjamesjacoby Keymaster 16 years, 4 months ago]

Changes to bp-default won’t happen very often, and if your theme is a child of bp-default, then you inherit these changes automatically. If not, then it’s your choice to adopt these changes or not.

I get what you’re saying, and it’s a valid concern. The ‘zebra’ class was added only because the JavaScript that was doing the striping was striping things all over the place that it shouldn’t have been. The only way to get it to stop reliably was to tell it exactly which tables it should stripe, hence the zebra class was born.

If you have problems or questions about it, ask them here or in IRC and I’ll try to help.

[@johnjamesjacoby Keymaster 16 years, 4 months ago]

1.2.5 has just been tagged. Blog post coming soon!

[@johnjamesjacoby Keymaster 16 years, 4 months ago]

@hnla It’s a silly code thing. The first row is 0, which is an even number. The second row, is row 1, which is odd.

[@johnjamesjacoby Keymaster 16 years, 4 months ago]

@nuprn1 I think I’ve got the zebras wrangled now. Please give it a go and let me know what you think. This is the last thing stopping us from a 1.2.5 release which will be sometime today.

[@johnjamesjacoby Keymaster 16 years, 4 months ago]

@hnla I agree with you, and that is what I’d like to do for 1.3.

@nuprn1 And you deleted the old files, and uploaded the new ones in their place? Can you get some screen shots up for me to see?

[@johnjamesjacoby Keymaster 16 years, 4 months ago]

@hnla Can you take a screen shot of what you’re experiencing and attach it to the original ticket? My fix to this issue is not the same as yours and Jeff’s. Mine only applies alt styling to rows that are inside a tbody. Table headers are styled independently, which was always the original intent.

[@johnjamesjacoby Keymaster 16 years, 4 months ago]

@nuprn1 https://trac.buddypress.org/changeset/3102/branches/1.2?old_path=%2F&format=zip

[@johnjamesjacoby Keymaster 16 years, 4 months ago]

The alt styles are now setup correctly, with odd rows getting the alt class all through-out the installation. This includes forums, topics, and settings, all of which were previously working in different ways or not at all. I also added theads and proper th’s so their style would be applied correctly, which they previously were not.

It will look differently than it did before, but this is the way it was always supposed to look.

[@johnjamesjacoby Keymaster 16 years, 4 months ago]

Made what I think are the final few changes. I’m unable to duplicate the forum alt-striping issue.

bbPress won’t be included in the Trac zip, because it’s setup as an SVN external. It will be in the final zip though.

[@johnjamesjacoby Keymaster 16 years, 4 months ago]

@hnla The alt striping was off in a few places, so I fixed it in a different way.

@lincme Glad you got it running.

@nuprn1 Will take a look thanks. Can you try refreshing/clearing your cache? I made some changes and haven’t bumped the CSS version yet.

[@johnjamesjacoby Keymaster 16 years, 4 months ago]

@lincme A few things have changed. Try a full and complete BuddyPress file replacement and report back. I am running the 1.2.5 version (same as you) with the BP Edit Group Slug plugin (which appears to be giving you trouble) and I am receiving no errors with it.

[@johnjamesjacoby Keymaster 16 years, 4 months ago]

@nuprn1 Just patched the branch for that issue. Care to test?

The style.css will get bumped when 1.2.5 is tagged.

[@johnjamesjacoby Keymaster 16 years, 4 months ago]

@hnla Awesome thanks!

@arturo84 Good question… If there are, they are very few and probably tweaks to %s or %d that were incorrect. Could run a diff of fhe buddypress.pot and see what comes up different.

[@johnjamesjacoby Keymaster 16 years, 4 months ago]

If your theme isn’t 100% complete, then it won’t get accepted into the repository. It isn’t due to lack of responsibility, but quite the opposite. Themes in the WordPress.org repository are available to more than 10 million blogs all around the world. If 1% of those blogs try to download and install a broken theme, that’s 100,000 people that are frustrated instantly.

When the bp-default theme has broken bits and pieces in it, look what happens in these forums!

The best way to put your theme out there and get feedback on it, is to post it up on your own website, and use it. Setup a test installation and let people see what it can do, and have them use that website to give you that feedback. You can even setup your own group on this site too if you’d like.

Save uploading your theme to the WordPress repository as the icing on the cake; your reward for a job well done and a theme well created. Your audience, and your spare time, will thank you for it.

[@johnjamesjacoby Keymaster 16 years, 4 months ago]

@hnla That is correct. The 1.2 branch of code is what we’re working with. Anything up until 1.3 will exist in that branch of code. SVN can be confusing, but it works really well for large project development with multiple developers and various states of progress; projects like WordPress and BuddyPress would be a nightmare without it.

@lincme Awesome; look forward to your response

[@johnjamesjacoby Keymaster 16 years, 4 months ago]

There is no way this is a problem with the zip. I’ve checked it a few times now and it’s perfect.

There is guaranteed no PHP code in the readme.txt. This has to be a problem with your installation.

Try to download the zip again, and open readme.txt in a text editor. It is the standard readme.txt.

[@johnjamesjacoby Keymaster 16 years, 4 months ago]

You may want to try your download/upload again, as it appears something might have occurred during your file transfer.

Just checked the readme.txt and the files you show throwing an error, and they don’t contain anything like you’ve mentioned.

I updated the link in the first post to take you to the trac source page rather than the zip directly. Maybe try it that way?

[@johnjamesjacoby Keymaster 16 years, 4 months ago]

Yep, there are plans.

[@johnjamesjacoby Keymaster 16 years, 4 months ago]

Yeah the trunk needs to be merged with the branch after 1.2.5. Thanks guys for helping out.

[@johnjamesjacoby Keymaster 16 years, 4 months ago]

Enough is enough. BuddyPress, not dying. Devs, more communication. We’re all on the same page and this topic is losing it’s productivity so I’m closing it down.

Thanks everyone for chiming in and for helping out

[@johnjamesjacoby Keymaster 16 years, 4 months ago]

Long story short, everyone wants more communication, and I’ll do a better job at it going forward.