[@mrmaz Participant 16 years, 8 months ago]

This bug was fixed after RC was released.

https://trac.buddypress.org/ticket/1815

[@mrmaz Participant 16 years, 8 months ago]

@Grosbouff

I’m curious why you are filtering the enqueued files? Do you want people to be able to totally override your plugin’s stylesheet?

[@mrmaz Participant 16 years, 8 months ago]

There are a lot of new actions in RC so you can put your custom tabs anywhere you want.

[@mrmaz Participant 16 years, 9 months ago]

UPDATE:

The filtering has been consolidated and drastically improved as of revision 2580. Here is an updated example:

function my_activity_filter( $query_string, $object, $filter, $scope, $page, $search_terms, $extras ) {

global $bp;



if ( $object != 'activity' || $scope != 'myclass' || !is_user_logged_in() )

return $query_string;



$args = array();

parse_str( $query_string, $args );

$args['object'] = $bp->groups->id;

$args['primary_id'] = function_to_get_group_id_for_logged_in_user();



return http_build_query( $args );

}

add_filter( 'bp_dtheme_ajax_querystring', 'my_activity_filter', 1, 7 );

As you can see a TON more information about the request is being passed to the filtering, so you can more easily determine what you need to do to handle it properly.

[@mrmaz Participant 16 years, 9 months ago]

@Grosbouff

Make sure you use a path that is NEVER going to match anything else. It is very important that you use a unique starting path, or you might match some other plugin’s template.

[@mrmaz Participant 16 years, 9 months ago]

I opened a ticket a few days back with a patch to add an action BEFORE the mentions tab to avoid having to copy the template. This also puts it inside the login check if statement, so you don’t have to check if the user is logged in.

https://trac.buddypress.org/ticket/1715

[@mrmaz Participant 16 years, 9 months ago]

Andy just moved all of the request functions into the global scope! Wooooot! Take a look at the trunk.

[@mrmaz Participant 16 years, 9 months ago]

done and works

[@mrmaz Participant 16 years, 9 months ago]

Has anyone come up with a better solution for this yet? I don’t want to start duplicating JS just to get it into scope.

[@mrmaz Participant 16 years, 9 months ago]

@Dave8057

I am trying to get a beta done for the end of the week. I have it mostly working, just dealing with feeds and some minor bugs, etc.

[@mrmaz Participant 16 years, 9 months ago]

I posted the patch to your ticket here: https://trac.buddypress.org/ticket/1628

[@mrmaz Participant 16 years, 9 months ago]

I just posted a solution to this ticket if anybody would like to test it out.

[@mrmaz Participant 16 years, 9 months ago]

I just ran into this same problem myself and came to the same conclusion as Brajesh. I ended up duplicating the function, which bugs me, but I can’t think of a *simple* workaround.

The really annoying part is that it only needs to be in the global scope for the initial page load. Everything else works fine.

The only way I can think of would be to use jQuery to bind events (or data arrays) to a globally available element, and then have the core code execute the events or retrieve the data arrays to get the custom filter parameters, which it would then pass to bp_filter_request() in a loop in its own scope.

[@mrmaz Participant 16 years, 9 months ago]

@Peterverkooijen

If you are comparing an open source project to a car manufacturer then you don’t get it. Did you pay for BuddyPress? Andy is right, you sound like a troll. You should word your posts to sound more constructive and stop taking shots at the developers.

There are many ways to contribute besides writing code. You can write documentation, help organize developers, write specs for plugins/features and put together a team of people to make it happen.

[@mrmaz Participant 16 years, 9 months ago]

@Andy

I have been working on porting BP Links to 1.2 for the past few days and I am very impressed with the refactoring you have done. Especially dropping the redundant “the_site” template classes and tags. The filtering code is also now much cleaner and re-usable. The new theme is a dream to work with and I think will make it EASIER for developers to add new features via plugins and relieve some of the pressure on the core team to provide so many features.

So what I have to say to people that are complaining about missing features in the core: Start writing code.

[@mrmaz Participant 16 years, 9 months ago]

This is such a massive improvement. I am pretty excited.

[@mrmaz Participant 16 years, 9 months ago]

@daweed

Thanks very much for that! This issue has been making me a bit crazy because I have found at least two ways for this problem to crop up.

1. Not updating the theme files after upgrade.

2. Trying to use BP Links with BP 1.2 (not supported yet)

and now

3. jQuery conflicts

I would appreciate a PM with any more details you have on how to reproduce this jQuery conflict.

[@mrmaz Participant 16 years, 9 months ago]

@webbimperiet

It appears that your theme is not compatible with the links plugin. Your best bet is to contact the author of the theme for help or have them customize it for you.

[@mrmaz Participant 16 years, 9 months ago]

@webbimperiet

That create link should be showing up regardless of the theme, unless there is something with the cosmicbuddy theme that is modifying the profile menus.

[@mrmaz Participant 16 years, 9 months ago]

@Brajesh

I agree with your post and that is probably the direction I will take. I only have so much time to develop my plugin, and will wait until there is a demand for classic theme support before I burn up any brain cells on it.

@Ruben

Thanks for that. Sounds like a case of bad timing! I will update my local copy and hopefully that problem will be resolved.

Btw, I am not complaining about classic. I think the core dev did an awesome job with backwards compatibility so far. You can tell that a lot of effort went into it.

I am still interested what other plugin developers have to say about bp-classic support in 1.2 and how their efforts are going and what their users are telling them.

[@mrmaz Participant 16 years, 9 months ago]

TO: Anyone who is getting the “Please fill in all of the required fields” error after upgrading.

I am 99% sure this is because you didn’t update the required links theme files in your theme.

Triple check to make sure that you copy the /../plugins/buddypress-links/links directory into /../themes/bp-default/

If your theme has a different name than bp-default, copy into that directory instead. If you customized the theme files, you should backup the exisiting folder BEFORE you copy.

In the next version I am going to make the necessary changes so there doesn’t need to be any more of this pita copying of files every upgrade

[@mrmaz Participant 16 years, 9 months ago]

@andy

Since you aren’t actually storing the @ tag, then I don’t see any problems with throwing this feature out there and see what happens. Let the end users dictate its success

[@mrmaz Participant 16 years, 9 months ago]

@SlaFFik

Thanks for the report on the non-translatable string. I will fix that asap.

And also thank you very much for the RU translations. I just committed them to trunk.

[@mrmaz Participant 16 years, 9 months ago]

@rvenable

Your post is so good its scary. It makes no sense to me to use a Twitterism of jumbling together meta data with post content. People do this on Twitter because they have no choice.

It works for Twitter, but they must be parsing out all of these tags and storing the relationships between the “embedded” meta tags and the “parent” post somewhere else for searching and whatever else.

This is a very dangerous direction to take. The core developers should tread very carefully.

I think rvenable’s solution is genious and satisfies all parties.

[@mrmaz Participant 16 years, 9 months ago]

@PH

I sent you a PM with instructions for how to gather some data so I can look into your issue