[@mrmaz Participant 16 years, 7 months ago]

@Squashroby

Which version of PHP are you using? Which version of buddypress-links do you have installed?

[@mrmaz Participant 16 years, 7 months ago]

@4thofficial

BP Links is totally separate from any of the WordPress links functionality. Members can add links from their profile page. There is a Links menu item directly under the Groups menu item.

[@mrmaz Participant 16 years, 7 months ago]

I have been receiving a lot of bug reports and comments on l10n issues that have already been fixed. Please make sure you are looking at the code for the latest version before sending me a bug, and also double check the trunk to see if it has been patched already.

Trunk source

https://plugins.trac.wordpress.org/browser/buddypress-links/trunk

Revision log

https://plugins.trac.wordpress.org/log/buddypress-links

Also, I am working hard on making l10n work properly. The goal is to be 100% compliant, and I think we are close, but its not going to happen overnight, so please be patient

A lot of people seem anxious to use this plugin in production. Please keep in mind that its still just a baby and it may be a while before it works perfectly for everybody.

Thank you!

[@mrmaz Participant 16 years, 7 months ago]

@Bowe:

The most recent .pot file is in the latest version which is available for download from the plugin page.

[@mrmaz Participant 16 years, 7 months ago]

Just tagged v0.1.2 which has quite a few l10n fixes and some bug fixes. Voting should work for everyone now!

[@mrmaz Participant 16 years, 7 months ago]

@21cdb:

Thanks for the kind words!

There is another developer, GIGALinux, from #buddypress-dev that is working on a German translation already! Maybe you can contact him and work on it together?

Also a word of caution that this plugin is still in heavy development, so please don’t put your reputation on the line with it yet! I do plan to create different branches if development could introduce instability or backwards compatibility issues, so you are probably safe from a theming standpoint.

If you find any layout or CSS issues while theming, please let me know so we can make improvements!

[@mrmaz Participant 16 years, 7 months ago]

A big thanks to Chouf1 and everyone else who is providing feedback on l10n issues. Thanks to Chouf1, I found a filter loop in the bp_links_load_textdomain() function so I have just committed a fix for that to trunk. In addition, there are now two new filters to give more control over the locale string and .mo file path as well, just in case you really don’t like how I am handling things, lol.

I also found a strange issue where MU code is returning an empty locale string if the option in empty in the database, so I also make sure the locale is not empty before wasting a file check (stat).

You can check out the diff here:

https://plugins.trac.wordpress.org/changeset/171526/buddypress-links

I am going to tag a new version tomorrow, hopefully by 1pm EST.

[@mrmaz Participant 16 years, 7 months ago]

@Porscheheritage:

Did you move the “links” directory which contains the required template files into your theme folder?

I have not had a chance to test a dashboard install yet, I will try to do that soon.

What does everyone think about changing things around so the core theme files stay in the plugin folder, but can be overridden in the theme folder if a file of the same path/name exists there?

This is not the BuddyPress convention, but it seems to make more sense from an upgrade/maintenance angle.

[@mrmaz Participant 16 years, 7 months ago]

Props to SlaFFik for pointing out a nasty bug which was breaking wire posts. The fix is in trunk, but until I have time to tag a new version here is the fix.

In bp-links.php change line 1546 from:

require_once ( BP_LINKS_PLUGIN_NAME . ‘/bp-links-notifications.php’ );

to

require_once ( BP_LINKS_PLUGIN_DIR . ‘/bp-links-notifications.php’ );

[@mrmaz Participant 16 years, 7 months ago]

BuddyPress creates two images for avatars. 150×150 and 50×50. Any other sizes you see are scaled by CSS.

If you really know what you are doing, you can define these with custom values in wp-config.php to change the real sizes of the files that are created, but I am not sure of any side effect that may occur.

define( ‘BP_AVATAR_THUMB_WIDTH’, 50 );

define( ‘BP_AVATAR_THUMB_HEIGHT’, 50 );

define( ‘BP_AVATAR_FULL_WIDTH’, 150 );

define( ‘BP_AVATAR_FULL_HEIGHT’, 150 );

If you are going to do this make sure you test extensively on a sandbox install first!

[@mrmaz Participant 16 years, 7 months ago]

To manually call a widget you need to do something like this:

<?php

$w = new BP_Activity_Widget();

$w->widget(array(‘widget_name’ => ‘Hello World’));

?>

Did not test this

[@mrmaz Participant 16 years, 7 months ago]

I think relying on a 3rd party service is a bad idea. I also think re-inventing the wheel is a bad idea. Media manager is a huge project. We need to find an existing open source media manager framework or library of some kind and adapt it to BP.

[@mrmaz Participant 16 years, 7 months ago]

@nexia:

Thank you for the bug report on the categories. I had been working on that several weeks back and ran into an issue with the redirect after save and obviously forgot to go back and complete it.

There is no way to make everyone happy with one slug name, so developers should be able to change it to whatever they like. In theory it should be possible for you to rename the slug by defining BP_LINKS_SLUG in wp-config.php, but I have not done any testing yet. If you want to be the first to test it, I would be happy to address any bugs that you might find.

[@mrmaz Participant 16 years, 7 months ago]

I just tagged 0.1.1 which fixes the bugs mentioned in this thread so far, as well as some tweaks to the translatable strings to support argument swapping.

You will also now find a .pot file in the languages/ directory.

-M

[@mrmaz Participant 16 years, 7 months ago]

To fix the smiley issue you need to move the two ‘convert_smilies’ filters all the way to the bottom of the list in bp-links-filters.php. I updated my local copy and that will make it into the next commit.

I am scared of XSS so you can see that I ended up just escaping all html for now until someone can help me figure out the best filtering strategy.

[@mrmaz Participant 16 years, 7 months ago]

stwc,

I have been having trouble with messaging as well!

That is strange that you aren’t seeing the filter button on the sitewide activity widget. That button html is automatically generated by the activity filter widget. The only thing in the plugin related to that is the CSS on line 36 of links/_inc/css/screen.css (v0.1)

Are you sure that link activity has been recorded? Is your site publicly accessible so I can take a look?

-M

[@mrmaz Participant 16 years, 7 months ago]

stwc,

Thanks for the kind words and the bug report. I’m thinking I need to make it so the filter buttons wrap, unless anyone else has a better idea for how to lay out that directory header? I didn’t really spend much time on the layout of that one to be honest. It could be a lot better.

-M

[@mrmaz Participant 16 years, 7 months ago]

JJJ,

I read your post about i18n, and followed it to the letter Thank you for saving me the leg work.

Every string is already in the text domain ‘buddypress-links’ (great minds think alike). I guess it must be up to the translators to use their translation tools in a way that avoids duplicate work, because it seems like a tall order for a plugin developer to monitor which strings are duplicates and constantly add and remove strings from their custom domain as the parent plugin changes (in this case BuddyPress and WordPress).

I really need to read up on this, lol.

-M

[@mrmaz Participant 16 years, 7 months ago]

@r-a-y: believe it or not, all of those submissions were manual, although they were imported from the first version of my site that supported remote submit via a custom bookmarklet. I plan to incorporate some sort of remote submit and/or bookmarklet features soon.

[@mrmaz Participant 16 years, 7 months ago]

@r-a-y:

Originally this plugin was inspired by social bookmarking and news sharing from more of an editorial standpoint than an automated one. There are many WordPress plugins that handle external RSS feeds, so I am curious what it is about Links that makes you want to use it for slurping RSS?

[@mrmaz Participant 16 years, 7 months ago]

@Chouf1:

I am happy that you are interested in helping with the translation of BuddyPress Links. I am new to i18n and I want to make sure I am doing it right.

I have a .pot file, but many of the strings are the same as the ‘buddypress’ text domain. Is there a way to avoid this when generating the .pot file, or do the translation tools automatically ignore these overlapping strings?

I would like to send you the .pot file so you can go over it and give feedback, what is the best way to get you the file?

[@mrmaz Participant 16 years, 7 months ago]

@Bowe: Thanks, I put a ton of work into it!

@ Erich73: Originally I had that idea, but my site has 100s of groups and I could not come up with an easy way to quickly select which group(s) to associate with the link. In the future I plan to add a feature where you can “tag” a link with a group so they it can be associated in that way. Either way, I have plans for a lot of Link/Group/Forum synergy.

@Chouf1: According to the WordPress.org docs a .pot file is supposed to be generated automatically, but I appears that it wasn’t. I will make sure there is a .pot file in the next release. In the meantime if you want to generate your own, the text domain is ‘buddypress-links’

Thanks for the feedback everybody!