[@djpaul Keymaster 10 years, 8 months ago]

I can tell right now that anyone using the “Easy WP SMTP” plugin are going to have problems with BuddPress 2.5+, but I think we can fix it.

@fidelleon – you sound like you’re up for experimenting! – can you download this file https://gist.github.com/paulgibbs/5e69eb7d080e992a8bc7 and add the .PHP file to your mu-plugins folder and test again?

For anyone else: don’t try this yet.

[@djpaul Keymaster 10 years, 8 months ago]

@lanvalencia I and others will try to get to help you as soon as possible.

None of us gets paid for contributing to BuddyPress. It’s the weekend. I have about 6 other forum discussions open where I’m trying to figure out why emails aren’t being sent at *all*, and that’s my current (personal) priority.

[@djpaul Keymaster 10 years, 8 months ago]

People with email delivery problems: who’s your webhost?

[@djpaul Keymaster 10 years, 8 months ago]

Hi @nkeatign

It ought to be totally do-able, but you’ll need to write it. If BuddyPress detects that something has re-implemented WordPress’ wp_mail function (like the Sendgrid plugin does), then it’ll use the plain text version of the email and pass that to wp_mail to let the custom wp_mail implementation deliver the email.

I am not aware of anyone who’s written a Sendgrid implementation for BuddyPress 2.5 yet, because the 2.5 release is still pretty new! Maybe you could write an integration plugin and be the first!

Here’s what you need to do (we can document this process more formally if this works for you): — off the top of my head, not tested, be wary of unexpected dragons, etc —

1) Add add_filter( 'bp_email_use_wp_mail', '__return_false' );
2) Add add_filter( 'bp_send_email_delivery_class', function( $delivery_class ) { return 'Your_Class'; } );.

These steps tell BuddyPress to always use its own email APIs, and tell it to use the class named Your_Class to handle the email delivery. The default delivery class is BP_PHPMailer which uses PHPMailer. I strongly suggest you use it as a reference for implementing a Sendgrid implementation.

Your_Class needs to implement the interface BP_Email_Delivery which provides a method bp_email(), which receives a BP_Email object. Everything about the email is contained inside the BP_Email object.

What your bp_email() method will need to do is call the Sendgrid’s plugin email-sending function. You can get all the information you need (recipients, HTML body, plain text body, etc) from the BP_Email object.

[@djpaul Keymaster 10 years, 8 months ago]

People who are having problems: as far as I know, we have never seen this problem before during testing. If someone like you had helped us test BuddyPress 2.5 in beta or release candidate stage about four weeks ago, we’d have fixed it prior to release.

We’ll get it fixed as soon as we figure out what the problem is.

I was just thinking about it and have one question which would be interesting: in wp-admin Settings > General, the value for the Email Address — is it a REAL email address? For example, if you were to send an email to that address, would it receive it?

[@djpaul Keymaster 10 years, 8 months ago]

Cool!

@jgob https://github.com/WordPress/WordPress/blob/ef7a559e2e7804844f99034e4ec018c5ffbf66c9/wp-includes/pluggable.php#L1700

There’s no way to filter or halt the action; I suppose it MIGHT be possible to intercept it inside wp_mail() but it’d be awkward.

[@djpaul Keymaster 10 years, 8 months ago]

Thanks for your feedback, @backpackersunion. I’ll let others chime in as I spent a long time working on the email feature, so it’s close to my heart, but here’s my thoughts:

• Decisions, not options.
• It’s much easier to add options than it is to remove options.
• It’s risky to add options or features unless you’re sure what your users want, so launching with a minimal feature set and listening to feedback and consensus helps us make informed decisions.

And the template, yes — you run the risk of the template going out-of-sync with the version distributed by BuddyPress. But this isn’t specific to the email feature, and could apply to any of BuddyPress thirty or so other templates.

We have some plans to add some communication around template changes in a feature release, like WooCommerce apparently does, which will help a bit.

[@djpaul Keymaster 10 years, 8 months ago]

@airsid

IF your translation file is up to date (have you re-downloaded the files to check?), those strings should be getting translated.

Otherwise, another option is to edit the email template. Copy buddypress/bp-templates/bp-legacy/buddypress/assets/emails/single-bp-email.php into your theme and make whatever changes you want.

[@djpaul Keymaster 10 years, 8 months ago]

BP emails enabled (the default) + WP Better Emails = email is sent in the WP Better Emails template.

BP emails disabled + WP Better Emails = email is sent in the WP Better Emails template.

I don’t know why you’re having problems with this — hopefully we’ll figure it out — but it seems like there’s something particular to your site or host that’s causing odds things to happen.

[@djpaul Keymaster 10 years, 8 months ago]

If the filter bp_email_use_wp_mail returns true, it’ll grab the “plain text” version of the email from BuddyPress, and send that to wp_mail(). BuddyPress does not re-implement wp_mail().

BuddyPress will also fall back to use wp_mail() if it detects that any other plugin has re-implemented that function (pretty common in email plugins), or if something’s configured WordPress to send HTML emails.

BuddyPress does not stop or block any other plugins’ emails from being sent, nor any emails sent by WordPress core (with a few exceptions for multisite-specific emails, but this has been implemented for about 6 or 7 years, so it’s not a new change).

I am just now testing this with WP Better Emails. Give me a minute.

[@djpaul Keymaster 10 years, 8 months ago]

I just updated the sample code on the thread you mentioned. I tested it and had to make a small change:

add_action( 'bp_email', function( $email_type, $email_obj ) {
	$email_obj->set_from( "custom@example.com", "Custom Website Name" );
}, 10, 2 );

This ^ works for me. I put it into a file in mu-plugins for convenience.

Note: the from address must be valid. If you put a fake address in there, your mail provider will probably reject the email and not sent it.

For example, if you use Google Mail via IMAP to send your site’s emails, Google will *force* the From address to be the account’s email address. You can see this by inspecting the raw email headers: http://cl.ly/42001Q2c142S

[@djpaul Keymaster 10 years, 8 months ago]

Those elements are hard-coded in the template, so the latter.

[@djpaul Keymaster 10 years, 8 months ago]

Are you using W3 Total Cache?

[@djpaul Keymaster 10 years, 8 months ago]

It ought to work. I wrote that code but it came with the disclaimer that I hadn’t actually tested it. 🙂

If someone wants to test it and correct if it necessary, that’d be helpful, else I will try to look this weekend.

[@djpaul Keymaster 10 years, 8 months ago]

About the language of the emails, please read https://buddypress.org/support/topic/read-this-first-buddypress-2-5-master-list/#post-250547

[@djpaul Keymaster 10 years, 8 months ago]

WP-CLI is nice.

[@djpaul Keymaster 10 years, 8 months ago]

What you basically need to do is:

1) rename the old plugins/buddypress/ folder to bp-backup
2) unzip BP 2.5.0 into plugins/buddypress/
3) go to your site, into wp-admin/plugins.php. This will start the update script (it should happen instantly and without displaying anything).
4) If the new BP is working for you, you can then delete the bp-backup folder.

If you find a problem, you can delete the new BP folder and rename bp-backup to buddypress, if that makes sense.

[@djpaul Keymaster 10 years, 8 months ago]

Is this the search widget built into bbPress, or does another plugin provide it?

[@djpaul Keymaster 10 years, 8 months ago]

HTTP 500 errors are pretty bad. We’re tracking one bug that might be the cause, but if you can look in your web server’s PHP error log (or ask your host to do this for you) and share with us any error or warning messages for the time period where you tried to update BuddyPress, we can look at it and find out for sure.

I’m very sorry 2.5 didn’t work for you, but we want to fix it.

[@djpaul Keymaster 10 years, 8 months ago]

The very last one might be an issue, but the others need to be fixed to be sure. Those others are to do with some other plugin you have active on your site; it’s doing something at the wrong time (too early), and BuddyPress and bbPress are both throwing warning messages.

I don’t think there’s a BuddyPress bug, you’ll need to look at those other plugins.

[@djpaul Keymaster 10 years, 8 months ago]

Can you submit a bug report for the issue? It’s probably a templating global variable getting overwritten by the custom loop.

[@djpaul Keymaster 10 years, 8 months ago]

@danbp The email subject and email body content are both intended to be translatable via .po/.mo.

@xxsemmiexx The Dutch translation of BuddyPress has not been updated for v2.5. Look here: https://translate.wordpress.org/projects/wp-plugins/buddypress — “Dutch” + “Stable” = 90%.

For example – the email in your screenshots – you can see the text is untranslated at the bottom of this screen of the translation tool: https://translate.wordpress.org/projects/wp-plugins/buddypress/stable/nl/default?filters%5Bstatus%5D=untranslated&sort%5Bby%5D=priority&sort%5Bhow%5D=desc&page=10

Once a language’s translation is 100% complete for the “Stable” version, a Language Pack is automatically built, and your WordPress will then prompt you to download it on its normal “Updates” screen.

Once THIS happen, THEN you can run the repair tool, and you’ll have Dutch emails. 🙂

—

You can see the latest available translation packs for all languages here:

https://translate.wordpress.org/projects/wp-plugins/buddypress/language-packs

[@djpaul Keymaster 10 years, 8 months ago]

Thanks for forwarding. I wanted to confirm that was a standard WordPress email (which it was), which would have been sent through the wp_mail() function, which proves your mail service does actually work.

You can get all previous versions of BuddyPress on https://wordpress.org/plugins/buddypress/developers/

Email delivery is a bit of black box. I am going to find or build a plugin to help us debug whether BuddyPress thinks it sent the email correctly or not.

Where is your site hosted? Is it http://intention.nl/ ?

[@djpaul Keymaster 10 years, 8 months ago]

> Then, I send a confirmation email (which was received)

Can you forward that email to me? I want to check something. You can find my email address on https://profiles.wordpress.org/djpaul/ thank you.

I’ll try to test this type of email before the weekend to confirm it should still work.
I fear this is going to be very tricky to find what the problem is.

[@djpaul Keymaster 10 years, 8 months ago]

I’ll try to test this type of email before the weekend. Can you paste me the translated text you’ve entered into the email title and email content for this type of email? Please put it on http://pastebin.com/ and then link to it here.

If all the other emails are working, it’s most likely that some custom text in the email is getting detected by your ISP’s email filters (etc) and blocking the email.

I will put your translation into my email of this type, and test it, and see if it works for me.