Forum Replies Created
-
@Andy Peatling – Very sad to be in hall of shame
1) Version 0.1.6 of BP Album+ that is posted on the WordPress plugin repository checks that BP is installed exactly as you have specified. Can you be a bit more specific about the defect?
2) I completely agree that current_user_can() is a better way to check for permissions in various plugin operations; and we will switch to the new function at the next BP Album+ release as per your request. In the meantime, why is using is_site_admin() so bad? Doesn’t current_user_can() just pass the call to is_site_admin() ?
/**
* Whether current user has capability or role.
*
* @since 2.0.0
*
* @param string $capability Capability or role name.
* @return bool
*/
function current_user_can( $capability ) {
$current_user = wp_get_current_user();
if( is_site_admin() ) <—- *NOTE*
return true;
if ( empty( $current_user ) )
return false;
$args = array_slice( func_get_args(), 1 );
$args = array_merge( array( $capability ), $args );
return call_user_func_array( array( &$current_user, ‘has_cap’ ), $args );
}
^F^
Regarding problems with the BuddyPress Links plugin…
Found the defect.
The problem is being caused by two blocks of code inside the BPLinks plugin that do not account for the situation where the BuddyPress administrator disables “friend” capabilities for the site.
When friend capabilities are disabled, calling the friends_check_friendship() function will crash the user thread. We handle this problem in BP Album+ by wrapping all calls to this function in a function_exists(‘friends_check_friendship’) statement, only calling the function if it is enabled.
This is a sneaky, subtle defect that could easily be missed during testing; fortunately, BPLink’s clean, well-documented source code made it easy to isolate and correct the problem.
Here’s a simple patch:
1) In “bp-links-classes.php” at line 650
REPLACE:
if ( $link_owner_user_id && $link_owner_user_id != $bp->loggedin_user->id && friends_check_friendship( $link_owner_user_id, $bp->loggedin_user->id ) ) {
$status_opts[] = self::STATUS_FRIENDS;
}
WITH:
if (function_exists(‘friends_check_friendship’)) {
if ( $link_owner_user_id && $link_owner_user_id != $bp->loggedin_user->id && friends_check_friendship( $link_owner_user_id, $bp->loggedin_user->id ) ) {
$status_opts[] = self::STATUS_FRIENDS;
}
}
2) In “bp-links-core.php” at line 1128
REPLACE:
return friends_check_friendship( $user_id, $link->user_id );
WITH:
if (function_exists(‘friends_check_friendship’))
return friends_check_friendship( $user_id, $link->user_id );
else
return null;
============================================================================
WordPress MU 2.9.2
BuddyPress Version 1.2.3
BuddyPress Links Version 0.3.2
BP Album+ 0.1.8 beta
^F^
@Mike Pratt – We are in serious dev mode…
^F^
@Tosh – The annoying activity stream problem you are experiencing is being caused by the edits you have made to the CSS file on your website. Basically, you’re telling the browser “Take every entry in the activity stream and float it over to the left” Because the thumbnail is the tallest element in the div, it sets the effective width, not the text, and so you end up with the images “catching” on each other instead of bumping down to a new line. You can probably fix this by setting the width of the containing element to 100%.
This sort of thing is why we encourage users to only test the plugin on the default theme.
@calvinhsu – probably a good idea. Fairly easy to add using the image meta tags.
@Jedbarish – The FaceBook and Flickr templates improve the look of thumbnails with diverse aspect ratios by rigidly enforcing layout. The difference between scale and resize is that resize works on a square canvas and scale works on an arbitrarily defined one. You can have “Widescreen” thumbnails using scale if you want.
@pcwriter – Oh yes, the tag links will be replaced with a thumbnail of the gallery’s first photo. The text links were just for the beta. *Click on the arrow to the left of the tag*
@Anointed – It’s certainly possible. We’ll look into it after we get the rest of the core features implemented.
@Mike Pratt – Good point.
Oh, one other thing I forgot to mention. You guys noticed that you could re-order your albums by clicking on the “arrows” below the thumbs, right?
^F^
