Forum Replies Created
-
I think the separation between BP’s default theme and the BP code is pretty good, actually. It’s not perfect
Yep it’s not perfect, it suffers from being too tied into the default theme, something I queried when 1.2 changed the location of the default theme to nestle within the BP core files – an odd thing for a theme in some senses.
This aspect has been raised though and there is no immediate short term answer, true and proper separation of model/controller from views or mid tier from presentational layer is doubtless a while off yet (Mr Mazz alludes to this aspect in his inner/internal thoughts section of the nextGenAPI paper)
It took WP an absolute age to get to a stage where it was possible to truly write themes with no fear that each and every upgrade would break custom themes and require hours of work to bring back into line, anyone who was trying to work with WP pre 1.5 era will remember the nightmare fondly
At the moment writing true themes (not simply skins) is a somewhat problematic issue the core can and will and does break your custom themes and involves having to trawl through presentational files finding those changes; this isn’t good and makes it difficult to have confidence in truly creating a theme – however the fact is that the default theme is actually pretty good, creating a child theme from it works pretty well, it will still break and you will still need to find those changes to theme files and transpose them to your child theme file copies, but generally that shouldn’t involve huge amounts of changes.
Issues need to be addressed but take heart that BP is a million miles ahead of where WP was at this stage and nowhere near as frustrating but you need to have lived through those early WP days perhaps to appreciate that
Upgraded my remaining 2.9.2 to BP 1.2.5 to run a test for you (bit late as it appears now
)I confirm above ‘Activate’ is not site wide, results in sub blogs sans BP , setting ‘Site Wide’ activation results in expected behavior.
Keep it quiet from JJJ as it just might be the straw that breaks the camels back… hmm camels don’t have stripes do they?
sorry finding this subject hard to take seriously now, striping, should be the simplest thing!Initially, and I would be surprised if anyone has yet to really take the plunge, one has to take the child theme route as trying to code presentational files from scratch with apps such as this would defeat even the best frontender, naturally one starts with the existing default theme folder structure, there’s nothing wrong with it and it’s how BP works, however with that copied over most of us with any experience are going to start very heavilly changing the markup (that is not critism of bp-default, which aint half bad )
There has to be a point where theme files do not suffer any changes, not that is in terms of hooks, functions, variables etc, the odd class not a huge problem as this is really not a core issue but a presentational frontend matter, and if I do not pick that change up no matter I deal with something like that my self or simply pass it by, look at the default theme in passing and realise it’s got a cool feature I lack
It’s a point better perhaps discussed at the dev chat? I raised an agenda topic along thses line as I know from experience if aspects like this are ignored for too long they never get dealt with – yes we have all written comments such /* ought to be improved */ or /* stop gap until better method found*/ and /* ought to be moved to…*/ I still come across them in work I and collegues have written and wince . In BP core files there are comments along the lines of /* must remove markup */ and indeed there is too much markup dotted around core files.
@nuprn1 thanks I’ll take a look at winmerge, sort of feel I’m missing a better way of using SVN but as I’ve said it’s been a while since I’ve used it and Tortoise and trying to get my head around it’s confusing series of commands is a lot of trial and error – no I’m I’m not about to rtfm
Nice touch on the mouseover.
Empty classes still generated, so I hack core again to overcome that as it’s offensiveNot sure how tr:odd produces alt token on even rows?
anyhoo appears to be better than before!
Fixes #2465 and #2475, for real this time. Now theres a confidant man!
I’ll give it a test run as well, but if it doesn’t work…
@nuprn1 I presume that you have seen Jeff’s ticket on the same issue -said for no particular reason
@johnjamesjacoby At risk of the subject becoming a tad boring
back to the zebras:For the moment, so I can move on I have adjusted bp-forums-templatetags.php – function bp_get_the_topic_css_class() ~580 to the snippet below to deal with the empty class attr:
if ( 0 == (int)$forum_template->topic->topic_open ):
$class .= ' closed';
else:
$class .= ' open';
endif;
and commented out the functions if($forum_template ->current_topic … $class .= ‘alt’ leaving the jQuery snippet to deal with alt class as in the short term it’s easier to let jQuery deal with this rather than $class hopefully when it’s sorted one or another changes should silently overwrite with no impact.
@Johnjamesjacoby your @mention name is too long
Erm I don’t really get what has gone wrong with this as I stated on that ticket of Jeff’s that I tested and all was ok now I look at the install that I made those changes on and see that all tr receive ‘alt’ which I wouldn’t have missed on initial testing so somewhat puzzled!
One thing could you change it from ‘odd’ to ‘even’ as Jeff’s point was pertinent it’s rather annoying to class the th parent tr with ‘alt’ or use my snippet and add a class specif to parents of th elements so we can easily remove/change styling, not that it’s the best approach.
