Re: Site Wide Activity stream not working
Andy, I’ve been working with someone else havign this exact same issues, and here’s what we’ve narrowed down (if it helps).
In bp-activity/bp-activity-templatetags.php, about line 491 or so: bp_activity_insert_time_since();
That function returns a value through a filter, which has a value created by the function bp_core_time_since();
That function is is ./bp-core.php, around line 1329 or so.
In this function, something quirky is going on, but not “always”.
Thus far, it only seems to be related to activity updates, although it could be more?
(Just created a group, it did it too, and shows 6 hours ago in the activity feed.)
So, I’m putting some echo’s and a die in the time_since function.
Here’s the output:
date passed: 1264065210
As passed into function. ($older_date)
date strtotime: 1264065210
The date passed is run through this:
<?php $older_date = strtotime( gmdate( 'Y-m-d H:i:s', $older_date ) ); ?>
This does nothing to the date passed. The string is the same.
This is generated if there is not a $newer_date passed into the function to compare the older_date to.
<?php $newer_date = ( !$newer_date ) ? ( strtotime( gmdate( 'Y-m-d H:i:s' ) ) + ( 60*60*0 ) ) : $newer_date;?>
This produces, for the first time, a different time string, which is 21600 seconds ahead of the current server time.
The difference between the newer_date, and the older_date.
21600 seconds, or 6 hours, which is the difference between my server time and GMT.
This is just time() from the server. (Matches what was passed in)
– The date passed into the function is the current server time.
– The “newer_date” is generated as GMT.
So now, the question is this.
Theoretically, if the server time is ahead of GMT, the following will fail:
<?php if ( 0 > $since ) ?>
This is checked right after the difference between the date passed (older_date) and the newer_date.
As the date passed in would be ahead of GMT (current server time), and newer_date will always be GMT if it is created within the function.
Soooo…… does this look trac worthy?